[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375961#comment-16375961
]
stack commented on HBASE-13916:
---
[~anoop.hbase] This bit of code needs more test. It does not seem to be
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591935#comment-14591935
]
Hadoop QA commented on HBASE-13916:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592113#comment-14592113
]
Anoop Sam John commented on HBASE-13916:
{quote}
-1 core tests. The patch failed
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592473#comment-14592473
]
Hudson commented on HBASE-13916:
FAILURE: Integrated in HBase-TRUNK #6583 (See
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591507#comment-14591507
]
ramkrishna.s.vasudevan commented on HBASE-13916:
+1 on patch.
Create
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591284#comment-14591284
]
stack commented on HBASE-13916:
---
Pardon my being dense on this [~anoop.hbase] Patch is
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591281#comment-14591281
]
Anoop Sam John commented on HBASE-13916:
bq.MBB is NOT a BB (because you can't
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591106#comment-14591106
]
Anoop Sam John commented on HBASE-13916:
MBB#get() will result in a BB#get() but
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591241#comment-14591241
]
Anoop Sam John commented on HBASE-13916:
{quote}
bq.May be all these byte[] and
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590132#comment-14590132
]
Hadoop QA commented on HBASE-13916:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590148#comment-14590148
]
stack commented on HBASE-13916:
---
What is difference between a MBB#get and a BB#get? They
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591276#comment-14591276
]
stack commented on HBASE-13916:
---
But when we call getVlong, are we not positioned at a
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14589644#comment-14589644
]
Anoop Sam John commented on HBASE-13916:
{quote}
-OK_JAVADOC_WARNINGS=4
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590075#comment-14590075
]
Anoop Sam John commented on HBASE-13916:
getVlong() has to take MBB only. It
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14589928#comment-14589928
]
stack commented on HBASE-13916:
---
Patch looks good.
Why BBUtils have ref to MBB?
import
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588003#comment-14588003
]
Hadoop QA commented on HBASE-13916:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588327#comment-14588327
]
Anoop Sam John commented on HBASE-13916:
When hasArray is true, the array() API
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588290#comment-14588290
]
Ted Yu commented on HBASE-13916:
{code}
+ * @return true if the MBB is made up of
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588346#comment-14588346
]
Anoop Sam John commented on HBASE-13916:
bq.-1 javac. The applied patch generated
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588407#comment-14588407
]
stack commented on HBASE-13916:
---
bq. We will have to add these counts to the approved
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588446#comment-14588446
]
Anoop Sam John commented on HBASE-13916:
bq,Is the fact that the nature of MBB
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588612#comment-14588612
]
Hadoop QA commented on HBASE-13916:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588951#comment-14588951
]
stack commented on HBASE-13916:
---
bq. Just because of this I thought of keeping this
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14589279#comment-14589279
]
Anoop Sam John commented on HBASE-13916:
bq.What did you think of an nio package?
[
https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14589282#comment-14589282
]
stack commented on HBASE-13916:
---
bq. Fine.
Was just asking what you thought. Leave as is
25 matches
Mail list logo
