[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097639#comment-15097639
]
Nick Dimiduk commented on HBASE-14221:
--
Looks like this was committed. Please update the Fix
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1508#comment-1508
]
ramkrishna.s.vasudevan commented on HBASE-14221:
Reverted and pushed with proper commit
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088872#comment-15088872
]
ramkrishna.s.vasudevan commented on HBASE-14221:
I think in commit msg I added the JIRA
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089213#comment-15089213
]
Hudson commented on HBASE-14221:
FAILURE: Integrated in HBase-1.2 #495 (See
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089293#comment-15089293
]
Hudson commented on HBASE-14221:
SUCCESS: Integrated in HBase-1.3-IT #429 (See
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089087#comment-15089087
]
Hudson commented on HBASE-14221:
SUCCESS: Integrated in HBase-1.2-IT #385 (See
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089261#comment-15089261
]
Hudson commented on HBASE-14221:
SUCCESS: Integrated in HBase-1.3 #487 (See
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089362#comment-15089362
]
Hudson commented on HBASE-14221:
FAILURE: Integrated in HBase-1.1-JDK8 #1723 (See
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089371#comment-15089371
]
Hudson commented on HBASE-14221:
FAILURE: Integrated in HBase-1.1-JDK7 #1636 (See
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089547#comment-15089547
]
Hudson commented on HBASE-14221:
FAILURE: Integrated in HBase-1.0 #1132 (See
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088395#comment-15088395
]
stack commented on HBASE-14221:
---
Patch looks fine. Whats with all the setting the row to null and the null
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088700#comment-15088700
]
ramkrishna.s.vasudevan commented on HBASE-14221:
bq.Whats with all the setting the row to
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088708#comment-15088708
]
stack commented on HBASE-14221:
---
Sweet. Add the above as a comment around the null setting on commit so
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088736#comment-15088736
]
ramkrishna.s.vasudevan commented on HBASE-14221:
Pushed to all 1.0+ branches. Added the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085428#comment-15085428
]
Hadoop QA commented on HBASE-14221:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085937#comment-15085937
]
stack commented on HBASE-14221:
---
bq. Should this be pushed to 1.0 branches as well?
Yes
> Reduce the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086844#comment-15086844
]
ramkrishna.s.vasudevan commented on HBASE-14221:
CAn i get a review on the branch-1
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083466#comment-15083466
]
Lars Hofhansl commented on HBASE-14221:
---
+1
(please use "lhofhansl" as alias, not "larsh" :) )
>
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085154#comment-15085154
]
Hudson commented on HBASE-14221:
FAILURE: Integrated in HBase-Trunk_matrix #613 (See
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084988#comment-15084988
]
ramkrishna.s.vasudevan commented on HBASE-14221:
Pushed to master. Thanks for the reviews
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082905#comment-15082905
]
Hadoop QA commented on HBASE-14221:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080920#comment-15080920
]
ramkrishna.s.vasudevan commented on HBASE-14221:
bq.I'm all for a smaller version of the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080742#comment-15080742
]
Lars Hofhansl commented on HBASE-14221:
---
I'm all for a smaller version of the patch.
Also from
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1506#comment-1506
]
ramkrishna.s.vasudevan commented on HBASE-14221:
[~stack] and [~anoop.hbase]
Do you have
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011495#comment-15011495
]
stack commented on HBASE-14221:
---
Did you mean an issue other than HBASE-14221 above [~ram_krish]? 14221 is
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012800#comment-15012800
]
ramkrishna.s.vasudevan commented on HBASE-14221:
bq.Did you mean an issue other than
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012807#comment-15012807
]
ramkrishna.s.vasudevan commented on HBASE-14221:
One way to decide if LoserTree is really
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008465#comment-15008465
]
ramkrishna.s.vasudevan commented on HBASE-14221:
In order to proceed with HBASE-14221, I
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008471#comment-15008471
]
ramkrishna.s.vasudevan commented on HBASE-14221:
One thing I can see is that when
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003338#comment-15003338
]
Lars Hofhansl commented on HBASE-14221:
---
The LoserTree did not work out in all cases, but in
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000293#comment-15000293
]
ramkrishna.s.vasudevan commented on HBASE-14221:
So for this JIRA we are not going to go
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956272#comment-14956272
]
ramkrishna.s.vasudevan commented on HBASE-14221:
+1 on trying it out. Need to explore
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956224#comment-14956224
]
Lars Hofhansl commented on HBASE-14221:
---
I think [~mcorgan] KeyValueScannerHeap is worth exploring
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953705#comment-14953705
]
stack commented on HBASE-14221:
---
bq. You mean the left hand side compare?
No. I was just making a
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954366#comment-14954366
]
Lars Hofhansl commented on HBASE-14221:
---
Agreed... I do think the most compares happen in the heaps
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954370#comment-14954370
]
Lars Hofhansl commented on HBASE-14221:
---
Might be time to look at HBASE-9969 again.
> Reduce the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1495#comment-1495
]
stack commented on HBASE-14221:
---
bq. Might be time to look at HBASE-9969 again.
That seemed like an
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952609#comment-14952609
]
ramkrishna.s.vasudevan commented on HBASE-14221:
Thanks for the review. Yes that is how
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952649#comment-14952649
]
ramkrishna.s.vasudevan commented on HBASE-14221:
Stack, not getting this
bq.Comment from
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952638#comment-14952638
]
stack commented on HBASE-14221:
---
Comment from left field: I've been profiling this w/e... and cutting down
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14950382#comment-14950382
]
Anoop Sam John commented on HBASE-14221:
Ram , this patch u have given, is for multi CF also
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946344#comment-14946344
]
Hadoop QA commented on HBASE-14221:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948057#comment-14948057
]
Lars Hofhansl commented on HBASE-14221:
---
I should make my patch compile fully. :)
The compare in
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948112#comment-14948112
]
ramkrishna.s.vasudevan commented on HBASE-14221:
I would say the biggest problem that I
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946682#comment-14946682
]
ramkrishna.s.vasudevan commented on HBASE-14221:
[~lhofhansl]
Thanks for the patch. I
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946298#comment-14946298
]
Lars Hofhansl commented on HBASE-14221:
---
Good find.
Although, isn't there a simpler way to do
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945966#comment-14945966
]
stack commented on HBASE-14221:
---
[~lhofhansl] For you...
> Reduce the number of time row comparison is
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935203#comment-14935203
]
Hadoop QA commented on HBASE-14221:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934995#comment-14934995
]
ramkrishna.s.vasudevan commented on HBASE-14221:
This patch tries to create an enum
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936378#comment-14936378
]
ramkrishna.s.vasudevan commented on HBASE-14221:
The failed tests shown above passes
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901980#comment-14901980
]
ramkrishna.s.vasudevan commented on HBASE-14221:
As am not getting notifications on the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14747288#comment-14747288
]
ramkrishna.s.vasudevan commented on HBASE-14221:
Ping for reviews. I would like to
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790692#comment-14790692
]
stack commented on HBASE-14221:
---
bq. . But atleast for a single CF case I think these comparison can be
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724865#comment-14724865
]
ramkrishna.s.vasudevan commented on HBASE-14221:
While doing some more tests with PE for
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716302#comment-14716302
]
ramkrishna.s.vasudevan commented on HBASE-14221:
Ping!!!
I could see that
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699486#comment-14699486
]
Hadoop QA commented on HBASE-14221:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699754#comment-14699754
]
Hadoop QA commented on HBASE-14221:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697329#comment-14697329
]
Hadoop QA commented on HBASE-14221:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697804#comment-14697804
]
stack commented on HBASE-14221:
---
Was going to suggest that added complexity not worth the
[
https://issues.apache.org/jira/browse/HBASE-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696960#comment-14696960
]
ramkrishna.s.vasudevan commented on HBASE-14221:
Withpatch -
60 matches
Mail list logo