[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429391#comment-15429391 ] Hadoop QA commented on HBASE-14450: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429143#comment-15429143 ] Vladimir Rodionov commented on HBASE-14450: --- lgtm. > HBase Backup/Restore Phase 3: Multiwal

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428970#comment-15428970 ] Vladimir Rodionov commented on HBASE-14450: --- This change I did understand: {code} ---

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428792#comment-15428792 ] Hadoop QA commented on HBASE-14450: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428501#comment-15428501 ] Hadoop QA commented on HBASE-14450: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428455#comment-15428455 ] Ted Yu commented on HBASE-14450: The following code is not capable of obtaining highest filenum among WAL

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428446#comment-15428446 ] Vladimir Rodionov commented on HBASE-14450: --- [~tedyu], can you clean up the patch a bit (too

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428444#comment-15428444 ] Hadoop QA commented on HBASE-14450: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428442#comment-15428442 ] Vladimir Rodionov commented on HBASE-14450: --- {quote} I found the cause for the missing WAL

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428392#comment-15428392 ] Ted Yu commented on HBASE-14450: [~vrodionov]: Can you take a look at the patch ? It contains version of

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428386#comment-15428386 ] Hadoop QA commented on HBASE-14450: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428367#comment-15428367 ] Hadoop QA commented on HBASE-14450: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427299#comment-15427299 ] Ted Yu commented on HBASE-14450: With more debug logging, the incremental restore failure can be

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427154#comment-15427154 ] Ted Yu commented on HBASE-14450: Looking at a failed run: {code} 2016-08-18 13:19:05,088 DEBUG [sync.4]

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426929#comment-15426929 ] Ted Yu commented on HBASE-14450: In log for successful run, we can see the following: {code} 2016-08-18

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425865#comment-15425865 ] Ted Yu commented on HBASE-14450: I was looking at WALInputFormat#WALRecordReader#nextKeyValue() Strangely

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423524#comment-15423524 ] Ted Yu commented on HBASE-14450: Gone through one test output from today looking for WALs involved with

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421955#comment-15421955 ] Ted Yu commented on HBASE-14450: Majority of 14450.roll-wait.txt is debug log. Will clean it up before

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-15 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421900#comment-15421900 ] Vladimir Rodionov commented on HBASE-14450: --- {quote} I temporarily add a pause following

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421289#comment-15421289 ] Ted Yu commented on HBASE-14450: After more debugging, walRoller.requestRollAll() should be called for

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418107#comment-15418107 ] Ted Yu commented on HBASE-14450: At the end of BackupdistCp#execute(), distcp job was marked

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418078#comment-15418078 ] Ted Yu commented on HBASE-14450: {code} 2016-08-11 15:43:58,313 DEBUG [ProcedureExecutor-5]

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417917#comment-15417917 ] Ted Yu commented on HBASE-14450: See my comment 4 hours ago. With 'FSHLog$SyncRunner(1275): syncing

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417912#comment-15417912 ] Vladimir Rodionov commented on HBASE-14450: --- Is it possible that we do not close WAL files

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417895#comment-15417895 ] Ted Yu commented on HBASE-14450: Please look at attached log. WAL files in src were listed under the line

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417885#comment-15417885 ] Vladimir Rodionov commented on HBASE-14450: --- [~ted yu] can you post the list of WAL files in

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417873#comment-15417873 ] Ted Yu commented on HBASE-14450: Manually verified that the 6 WAL files passed to setIncrBackupFileList()

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417826#comment-15417826 ] Ted Yu commented on HBASE-14450: This is related code in BackupDistCp#execute() when job.isComplete()

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417670#comment-15417670 ] Ted Yu commented on HBASE-14450: >From the same test: {code} 2016-08-10 15:46:24,236 WARN [Thread-2327]

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417594#comment-15417594 ] Ted Yu commented on HBASE-14450: I plan to dig some more into distcp code. But what confuses me was that

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417589#comment-15417589 ] Vladimir Rodionov commented on HBASE-14450: --- [~tedyu], is this reproducible? Seems like

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417539#comment-15417539 ] Ted Yu commented on HBASE-14450: In test output, I saw: {code} 2016-08-10 15:46:19,174 ERROR

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416189#comment-15416189 ] Ted Yu commented on HBASE-14450: Added more debug logging. {code} 2016-08-10 15:46:16,306 DEBUG [sync.3]

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415731#comment-15415731 ] Ted Yu commented on HBASE-14450: Trying to determine which WAL(s) is not picked up by incremental restore

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413943#comment-15413943 ] Ted Yu commented on HBASE-14450: Found the following in test output: {code}

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-08-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413813#comment-15413813 ] Ted Yu commented on HBASE-14450: After enabling multi-wal, I got the following test failures: {code}

[jira] [Commented] (HBASE-14450) HBase Backup/Restore Phase 3: Multiwal support

2016-03-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200142#comment-15200142 ] Vladimir Rodionov commented on HBASE-14450: --- Moved to Phase 3. > HBase Backup/Restore Phase 3: