[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383114#comment-15383114 ] stack commented on HBASE-14549: --- So, this stuff is no longer complex? Nothing to do based off your findings

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14951645#comment-14951645 ] Lars Hofhansl commented on HBASE-14549: --- OK... I get it now. In KeyValueHeap we always have the top

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946279#comment-14946279 ] Lars Hofhansl commented on HBASE-14549: --- Looking more at HBASE-5121, I think I do not understand

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942827#comment-14942827 ] stack commented on HBASE-14549: --- Not sure I understand but +1 on the change given this basis (smile). I'd

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942829#comment-14942829 ] stack commented on HBASE-14549: --- I looked a bit more... patch makes more sense now. +1 again if hadoopqa

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942825#comment-14942825 ] Lars Hofhansl commented on HBASE-14549: --- There is a slight performance improvement too. > Simplify

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942865#comment-14942865 ] Lars Hofhansl commented on HBASE-14549: --- Hmm... Yes, not quite right, although I do not understand

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942867#comment-14942867 ] Lars Hofhansl commented on HBASE-14549: --- See HBASE-5121 (and my _own_ suggestion to simplify fix

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942876#comment-14942876 ] Lars Hofhansl commented on HBASE-14549: --- Thanks for keeping me honest [~stack] :) > Simplify

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942848#comment-14942848 ] Hadoop QA commented on HBASE-14549: --- {color:red}-1 overall{color}. Here are the results of testing the

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942862#comment-14942862 ] Lars Hofhansl commented on HBASE-14549: --- TestScanner looks very relevant. Looking., > Simplify

[jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic

[ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942557#comment-14942557 ] Lars Hofhansl commented on HBASE-14549: --- TestAtomicOperation passes multiple runs (it mixes flushes