[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009997#comment-15009997
]
Hadoop QA commented on HBASE-14771:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004401#comment-15004401
]
Appy commented on HBASE-14771:
--
+1
> RpcServer.getRemoteAddress always returns null.
>
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004673#comment-15004673
]
Hadoop QA commented on HBASE-14771:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003108#comment-15003108
]
Appy commented on HBASE-14771:
--
[~a72877] Let's drive it to the end. Only need to copy-paste the code from
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999218#comment-14999218
]
Appy commented on HBASE-14771:
--
Perfect!
> RpcServer.getRemoteAddress always returns null.
>
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998683#comment-14998683
]
Abhishek Kumar commented on HBASE-14771:
thanks Appy for review, i m planning to write something
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993334#comment-14993334
]
Appy commented on HBASE-14771:
--
the patch looks good. Can you think of a unit test? Maybe using dummy
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993995#comment-14993995
]
Hadoop QA commented on HBASE-14771:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994418#comment-14994418
]
Appy commented on HBASE-14771:
--
Thanks [~a72877] for adding the test.
So we check that's it's not null, but
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992032#comment-14992032
]
Hadoop QA commented on HBASE-14771:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992161#comment-14992161
]
stack commented on HBASE-14771:
---
Good one. Hmmm. This used to work. Stuff got moved around? Do you know
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992714#comment-14992714
]
Appy commented on HBASE-14771:
--
getRemoteAddress() always returns null because CurCall is thread local
[
https://issues.apache.org/jira/browse/HBASE-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993165#comment-14993165
]
Abhishek Kumar commented on HBASE-14771:
it was mainly for logging purpose such as the use of
13 matches
Mail list logo
