[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-08-01 Thread Xiang Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401974#comment-15401974 ] Xiang Li commented on HBASE-14881: -- Thanks [~anoop.hbase] for the review and guide! Than

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-08-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401873#comment-15401873 ] Hudson commented on HBASE-14881: FAILURE: Integrated in HBase-Trunk_matrix #1334 (See [h

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-08-01 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401697#comment-15401697 ] Anoop Sam John commented on HBASE-14881: Ya I corrected those on my own.. Was fac

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401084#comment-15401084 ] Hadoop QA commented on HBASE-14881: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-31 Thread Xiang Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401075#comment-15401075 ] Xiang Li commented on HBASE-14881: -- Hi Anoop, thanks for the review again! I removed the

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-30 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400708#comment-15400708 ] Anoop Sam John commented on HBASE-14881: {code} } else { // Row is not immutable

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-29 Thread Xiang Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399047#comment-15399047 ] Xiang Li commented on HBASE-14881: -- Thanks for the comments [~anoop.hbase]! Regarding yo

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384314#comment-15384314 ] Anoop Sam John commented on HBASE-14881: Seems like other comments are not addres

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-19 Thread Xiang Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383982#comment-15383982 ] Xiang Li commented on HBASE-14881: -- [~anoop.hbase] could you please review patch 001 at

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381102#comment-15381102 ] Hadoop QA commented on HBASE-14881: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-16 Thread Xiang Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381072#comment-15381072 ] Xiang Li commented on HBASE-14881: -- I think this enhancement does not apply to {{Put(Byt

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-16 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380627#comment-15380627 ] Anoop Sam John commented on HBASE-14881: Oh ya.. we keep row as a byte[] with ou

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-15 Thread Xiang Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379541#comment-15379541 ] Xiang Li commented on HBASE-14881: -- Thanks for the comments, [~anoop.hbase]! In my humb

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-13 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375405#comment-15375405 ] Anoop Sam John commented on HBASE-14881: Why only 2 versions of new constructor?

[jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping

2016-07-13 Thread Xiang Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375253#comment-15375253 ] Xiang Li commented on HBASE-14881: -- [~jinghe], is the patch you are expecting to have?