[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212631#comment-15212631
]
Duo Zhang commented on HBASE-15389:
---
Add a simple description. HBASE-15400 will make this feature
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212599#comment-15212599
]
Andrew Purtell commented on HBASE-15389:
Can we get a description and/or a release note on this,
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212166#comment-15212166
]
Hudson commented on HBASE-15389:
ABORTED: Integrated in HBase-0.98-matrix #318 (See
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212113#comment-15212113
]
Hudson commented on HBASE-15389:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1191 (See
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211998#comment-15211998
]
Hudson commented on HBASE-15389:
FAILURE: Integrated in HBase-1.4 #55 (See
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211896#comment-15211896
]
Hudson commented on HBASE-15389:
FAILURE: Integrated in HBase-Trunk_matrix #808 (See
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211849#comment-15211849
]
Duo Zhang commented on HBASE-15389:
---
Oh I have fixed the checkstyle errors before committing. You can
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211828#comment-15211828
]
Sean Busbey commented on HBASE-15389:
-
In the future please fix checkstyle errors before committing.
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211800#comment-15211800
]
Hudson commented on HBASE-15389:
SUCCESS: Integrated in HBase-1.3 #624 (See
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211743#comment-15211743
]
Hudson commented on HBASE-15389:
SUCCESS: Integrated in HBase-1.3-IT #582 (See
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211479#comment-15211479
]
Duo Zhang commented on HBASE-15389:
---
Finally...
Will commit shortly.
> Write out multiple files when
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211466#comment-15211466
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210166#comment-15210166
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210141#comment-15210141
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210082#comment-15210082
]
Duo Zhang commented on HBASE-15389:
---
There is test failing introduced by HBASE-15475, and it is also a
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209978#comment-15209978
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209877#comment-15209877
]
Duo Zhang commented on HBASE-15389:
---
Oh I got it, the former should be DROP, not RETAIN. Let me fix it.
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209872#comment-15209872
]
Clara Xiong commented on HBASE-15389:
-
And the same for your current branch-1 patch.
> Write out
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209871#comment-15209871
]
Clara Xiong commented on HBASE-15389:
-
Yes, I gave that comments on RB before for the condition. But
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209829#comment-15209829
]
Duo Zhang commented on HBASE-15389:
---
{quote}
Since regression tests didn't find them, could you double
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209575#comment-15209575
]
Duo Zhang commented on HBASE-15389:
---
Oh, the patch for 0.98 should be stale. I will provide a new one
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208676#comment-15208676
]
Clara Xiong commented on HBASE-15389:
-
[~Apache9] Could you update your 98 patch with the latest
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207840#comment-15207840
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207649#comment-15207649
]
Clara Xiong commented on HBASE-15389:
-
This patch better go in first. I was talking about coupling
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206909#comment-15206909
]
Enis Soztutar commented on HBASE-15389:
---
bq. So let's set the fix version to 1.4.0? Then we have
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206221#comment-15206221
]
Duo Zhang commented on HBASE-15389:
---
Seems the findbugs and javadoc error is for the whole hbase
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206050#comment-15206050
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205689#comment-15205689
]
Duo Zhang commented on HBASE-15389:
---
And let's commit this first before HBASE-15400? Then I could start
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205653#comment-15205653
]
Duo Zhang commented on HBASE-15389:
---
So let's set the fix version to 1.4.0? Then we have plenty of time
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205646#comment-15205646
]
Clara Xiong commented on HBASE-15389:
-
I don't have any more code review concerns. Can we couple the
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205608#comment-15205608
]
Duo Zhang commented on HBASE-15389:
---
[~enis] [~davelatham] [~clarax98007] If no new concerns, let's
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204710#comment-15204710
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204438#comment-15204438
]
Sean Busbey commented on HBASE-15389:
-
oh! I bet this is YETUS-274. The workaround is to name it like
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204417#comment-15204417
]
Sean Busbey commented on HBASE-15389:
-
it should be either HBASE--0.98-v1.patch or
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198668#comment-15198668
]
Ted Yu commented on HBASE-15389:
+1, assuming tests pass.
> Write out multiple files when compaction
>
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201062#comment-15201062
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201832#comment-15201832
]
Sergey Shelukhin commented on HBASE-15389:
--
Why was TestStripeCompactor test removed? Other than
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202740#comment-15202740
]
Duo Zhang commented on HBASE-15389:
---
[~busbey] How should I name the 0.98 patch if I want to run pre
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202735#comment-15202735
]
Duo Zhang commented on HBASE-15389:
---
The testcase fail on branch-1 is unrelated.
I have checked the
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199227#comment-15199227
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202651#comment-15202651
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202702#comment-15202702
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202630#comment-15202630
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202616#comment-15202616
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202615#comment-15202615
]
Clara Xiong commented on HBASE-15389:
-
Thank you for the 98 patch. Will backport and test next week.
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200897#comment-15200897
]
Duo Zhang commented on HBASE-15389:
---
[~sershe] Any concerns on the modification of stripe compaction
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202553#comment-15202553
]
Duo Zhang commented on HBASE-15389:
---
{quote}
So HBASE-15400 sits on top of this, and without it, this
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202494#comment-15202494
]
Enis Soztutar commented on HBASE-15389:
---
bq. I will open new jira to address the duplicated code in
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202381#comment-15202381
]
Duo Zhang commented on HBASE-15389:
---
{quote}
Why was TestStripeCompactor test removed?
{quote}
I just
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196993#comment-15196993
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195880#comment-15195880
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195631#comment-15195631
]
Sergey Shelukhin commented on HBASE-15389:
--
I'll take a look this week.
> Write out multiple
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195604#comment-15195604
]
Dave Latham commented on HBASE-15389:
-
This is good work, Duo - I think it's really close. It would
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195045#comment-15195045
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194905#comment-15194905
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192859#comment-15192859
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187090#comment-15187090
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185420#comment-15185420
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184874#comment-15184874
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184570#comment-15184570
]
Clara Xiong commented on HBASE-15389:
-
1. We currently use DTCP with DefaultCompactor, which only
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184201#comment-15184201
]
Duo Zhang commented on HBASE-15389:
---
AFAICT, {{CompactionPolicy}} is only used to select files for
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184066#comment-15184066
]
Clara Xiong commented on HBASE-15389:
-
[~lhofhansl] I think it is generic and independent enough to
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184018#comment-15184018
]
Lars Hofhansl commented on HBASE-15389:
---
3. Is it possible to refactor compactions to make this
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184006#comment-15184006
]
Lars Hofhansl commented on HBASE-15389:
---
[~Apache9] thanks for looking into this. This is awesome.
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183355#comment-15183355
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183041#comment-15183041
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182963#comment-15182963
]
Hadoop QA commented on HBASE-15389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182916#comment-15182916
]
Duo Zhang commented on HBASE-15389:
---
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182745#comment-15182745
]
Duo Zhang commented on HBASE-15389:
---
Oh, typo, let me fix it.
> Write out multiple files when
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182741#comment-15182741
]
Clara Xiong commented on HBASE-15389:
-
Just a minor thing: DateTieredComparator should be
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182525#comment-15182525
]
Clara Xiong commented on HBASE-15389:
-
That is fine. Your prototype is enough for me to work on the
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182504#comment-15182504
]
Duo Zhang commented on HBASE-15389:
---
OK, you will include the StoreEngine in your patch? This is should
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182459#comment-15182459
]
Duo Zhang commented on HBASE-15389:
---
I think we can work parallel but to commit with two separated
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182264#comment-15182264
]
Clara Xiong commented on HBASE-15389:
-
What do you think if we keep HBASE-15389 and HBASE-15400 as
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182255#comment-15182255
]
Clara Xiong commented on HBASE-15389:
-
HadoopQA reported unit test failures in
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182079#comment-15182079
]
Duo Zhang commented on HBASE-15389:
---
Fine, let me write a testcase for the compactor and see how to
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182051#comment-15182051
]
Clara Xiong commented on HBASE-15389:
-
While keeping the discussion and patch on how to get DTCP work
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181530#comment-15181530
]
Clara Xiong commented on HBASE-15389:
-
Thank you very much for the new Compactor and MultiFileWriter.
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179326#comment-15179326
]
Duo Zhang commented on HBASE-15389:
---
{quote}
We can add sorting in DateTierCompactionPolicy that uses
[
https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179200#comment-15179200
]
Clara Xiong commented on HBASE-15389:
-
We can add sorting in DateTierCompactionPolicy that uses
80 matches
Mail list logo
