[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187005#comment-15187005
]
Ashish Singhi commented on HBASE-15433:
---
Planning to give a patch ? If not I can tr
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187024#comment-15187024
]
Jianwei Cui commented on HBASE-15433:
-
Thanks for your comment [~ashish singhi], I ma
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187030#comment-15187030
]
Ashish Singhi commented on HBASE-15433:
---
Great!
> SnapshotManager#restoreSnapshot
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187064#comment-15187064
]
Jianwei Cui commented on HBASE-15433:
-
I tried the patch on trunk and will try it on
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187210#comment-15187210
]
Jianwei Cui commented on HBASE-15433:
-
If the snapshot contains less regions than the
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188712#comment-15188712
]
Ted Yu commented on HBASE-15433:
{code}
112 return state != null ? state.getReg
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188919#comment-15188919
]
Jianwei Cui commented on HBASE-15433:
-
Thanks for your comments [~yuzhih...@gmail.com
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189244#comment-15189244
]
Ashish Singhi commented on HBASE-15433:
---
You need to generate the patch from source
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189255#comment-15189255
]
Ted Yu commented on HBASE-15433:
I meant the 'else' keyword can be omitted since the if b
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190895#comment-15190895
]
Jianwei Cui commented on HBASE-15433:
-
Thanks for your comment, will make a new unit
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190901#comment-15190901
]
Jianwei Cui commented on HBASE-15433:
-
I get your point, Yes, it will be more concise
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190915#comment-15190915
]
Ashish Singhi commented on HBASE-15433:
---
{quote}
If the snapshot contains less regi
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192690#comment-15192690
]
Jianwei Cui commented on HBASE-15433:
-
Thanks for your comment and sorry to reply lat
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192813#comment-15192813
]
Ashish Singhi commented on HBASE-15433:
---
OK. Now I understood.
When QEE is thrown w
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193038#comment-15193038
]
Jianwei Cui commented on HBASE-15433:
-
{quote}
When QEE is thrown we will still end u
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193091#comment-15193091
]
Ashish Singhi commented on HBASE-15433:
---
bq. Here, the checkAndUpdateNamespaceRegio
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193148#comment-15193148
]
Jianwei Cui commented on HBASE-15433:
-
The table must be disabled during restoreSnaps
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193177#comment-15193177
]
Ashish Singhi commented on HBASE-15433:
---
I was not saying about concurrent restoreS
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194691#comment-15194691
]
Jianwei Cui commented on HBASE-15433:
-
Thanks for your comment.
{quote}
Not required
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194785#comment-15194785
]
Ashish Singhi commented on HBASE-15433:
---
Your idea sounds good to me.
{quote}
4. c
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194845#comment-15194845
]
Jianwei Cui commented on HBASE-15433:
-
Reasonable for this case IMO. It seems there a
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194849#comment-15194849
]
Ashish Singhi commented on HBASE-15433:
---
Sure. I am ok with it.
> SnapshotManager#
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194966#comment-15194966
]
Jianwei Cui commented on HBASE-15433:
-
Upload patch v3 according to comments. There h
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194977#comment-15194977
]
Ashish Singhi commented on HBASE-15433:
---
Instead of getting table region count from
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195033#comment-15195033
]
Jianwei Cui commented on HBASE-15433:
-
{quote}
Instead of getting table region count
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195474#comment-15195474
]
Hadoop QA commented on HBASE-15433:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197071#comment-15197071
]
Hadoop QA commented on HBASE-15433:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201155#comment-15201155
]
Jianwei Cui commented on HBASE-15433:
-
Run the failed tests locally and passed, seems
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201414#comment-15201414
]
Ted Yu commented on HBASE-15433:
Jianwei:
I looked at the scenario (region counts of 8 an
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203833#comment-15203833
]
Jianwei Cui commented on HBASE-15433:
-
Sorry to reply late and thanks for your review
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203848#comment-15203848
]
Jianwei Cui commented on HBASE-15433:
-
HBASE-15433-branch-1-v1.patch could also be ap
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203928#comment-15203928
]
Hadoop QA commented on HBASE-15433:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204012#comment-15204012
]
Ted Yu commented on HBASE-15433:
Integrated to master and branch-1.
Once Jenkins build c
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204198#comment-15204198
]
Hudson commented on HBASE-15433:
FAILURE: Integrated in HBase-1.4 #39 (See
[https://buil
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204214#comment-15204214
]
Ted Yu commented on HBASE-15433:
Thanks for the patch, Jianwei.
Thanks for the review, A
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204420#comment-15204420
]
Hudson commented on HBASE-15433:
SUCCESS: Integrated in HBase-1.3-IT #571 (See
[https://
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204483#comment-15204483
]
Hudson commented on HBASE-15433:
SUCCESS: Integrated in HBase-1.2-IT #468 (See
[https://
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204502#comment-15204502
]
Hudson commented on HBASE-15433:
FAILURE: Integrated in HBase-Trunk_matrix #794 (See
[ht
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204561#comment-15204561
]
Hudson commented on HBASE-15433:
SUCCESS: Integrated in HBase-1.1-JDK7 #1686 (See
[https
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204920#comment-15204920
]
Hudson commented on HBASE-15433:
SUCCESS: Integrated in HBase-1.3 #614 (See
[https://bui
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204933#comment-15204933
]
Hudson commented on HBASE-15433:
FAILURE: Integrated in HBase-1.2 #583 (See
[https://bui
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205441#comment-15205441
]
Hudson commented on HBASE-15433:
FAILURE: Integrated in HBase-1.1-JDK8 #1772 (See
[https
[
https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205607#comment-15205607
]
Jianwei Cui commented on HBASE-15433:
-
Thanks for the review, Ted and Ashish.
> Snap
43 matches
Mail list logo
