[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-04-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239132#comment-15239132 ] Hudson commented on HBASE-15481: FAILURE: Integrated in HBase-1.4 #85 (See

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-04-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239121#comment-15239121 ] Hudson commented on HBASE-15481: FAILURE: Integrated in HBase-Trunk_matrix #843 (See

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-04-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238727#comment-15238727 ] Hudson commented on HBASE-15481: SUCCESS: Integrated in HBase-1.3-IT #609 (See

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-04-12 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238390#comment-15238390 ] Duo Zhang commented on HBASE-15481: --- It was a -0... Yeah, let's make progress here. What [~mbertozzi]

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-04-12 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237550#comment-15237550 ] Sean Busbey commented on HBASE-15481: - bump, [~Apache9]. Could you give some feedback on my above

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-04-07 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231241#comment-15231241 ] Sean Busbey commented on HBASE-15481: - [~Apache9] does Matteo's reasoning above for the current state

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217283#comment-15217283 ] Hadoop QA commented on HBASE-15481: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-23 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209706#comment-15209706 ] Sean Busbey commented on HBASE-15481: - reasoning makes sense to me. > Add pre/post roll to

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-20 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201729#comment-15201729 ] Sean Busbey commented on HBASE-15481: - filed YETUS-336 for the inconsistent javadoc results. > Add

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202118#comment-15202118 ] Matteo Bertozzi commented on HBASE-15481: - we still have a rollWriter() in the WAL class. so I

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201092#comment-15201092 ] Hadoop QA commented on HBASE-15481: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Stephen Yuan Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201690#comment-15201690 ] Stephen Yuan Jiang commented on HBASE-15481: i like checkstyle to force {} on one-line IF -

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201731#comment-15201731 ] Sean Busbey commented on HBASE-15481: - Do we lose much by having the internal notifications just use

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202056#comment-15202056 ] Sean Busbey commented on HBASE-15481: - What happens if a WALProvider does not associate WALs with

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201648#comment-15201648 ] Matteo Bertozzi commented on HBASE-15481: - I think they are different. WALActionsListener is not

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202109#comment-15202109 ] Sean Busbey commented on HBASE-15481: - I think the problem with exposing this in the coprocessor

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200960#comment-15200960 ] Hadoop QA commented on HBASE-15481: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202224#comment-15202224 ] Matteo Bertozzi commented on HBASE-15481: - I want the "log I rolled". being able to see where it

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202062#comment-15202062 ] Matteo Bertozzi commented on HBASE-15481: - you worked on wal provider. you should provide an

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-19 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201624#comment-15201624 ] Sean Busbey commented on HBASE-15481: - with this change could we get rid of the WALActionsListener

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-18 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202558#comment-15202558 ] Matteo Bertozzi commented on HBASE-15481: - I think everyone is one the same page that exposing

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-18 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202556#comment-15202556 ] Sean Busbey commented on HBASE-15481: - I'd also love to kill WALActionListener. The problem with it

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202547#comment-15202547 ] Duo Zhang commented on HBASE-15481: --- I agree with [~busbey] that we may have a WAL which does not rely

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-18 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202167#comment-15202167 ] Sean Busbey commented on HBASE-15481: - What use case are we trying to solve? Is including the Path

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-18 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202528#comment-15202528 ] Sean Busbey commented on HBASE-15481: - backup and replication can get that via the WALActionListener,

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202434#comment-15202434 ] Hadoop QA commented on HBASE-15481: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15481) Add pre/post roll to WALObserver

2016-03-18 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201977#comment-15201977 ] Matteo Bertozzi commented on HBASE-15481: - no you add extra stuff that does not make sense. Since