[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820624#comment-16820624 ] Hudson commented on HBASE-15560: Results for branch branch-2 [build #1826 on bu

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820559#comment-16820559 ] Hudson commented on HBASE-15560: Results for branch master [build #941 on build

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-17 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820448#comment-16820448 ] Eshcar Hillel commented on HBASE-15560: --- Congratulations!! Great to see this final

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-17 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820436#comment-16820436 ] Ben Manes commented on HBASE-15560: --- Thank you [~apurtell], [~busbey], [~stack], [~ebo

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-17 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820348#comment-16820348 ] Andrew Purtell commented on HBASE-15560: Thanks I will try to commit this today

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815950#comment-16815950 ] Sean Busbey commented on HBASE-15560: - okay in that case I'm +1 > TinyLFU-based Blo

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815849#comment-16815849 ] Andrew Purtell commented on HBASE-15560: [~zyork] Sorry, that was my misundersta

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Zach York (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815799#comment-16815799 ] Zach York commented on HBASE-15560: --- I don't think the changes required to make it wor

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815788#comment-16815788 ] Andrew Purtell commented on HBASE-15560: There is no need to break out TinyLFU t

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815786#comment-16815786 ] Sean Busbey commented on HBASE-15560: - I had been waiting to review this because bef

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815785#comment-16815785 ] Andrew Purtell commented on HBASE-15560: {quote}but the fact that tests were cha

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Zach York (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815779#comment-16815779 ] Zach York commented on HBASE-15560: --- [~apurtell] I am making claim that based on the s

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815768#comment-16815768 ] Andrew Purtell commented on HBASE-15560: {quote}I think it will require a signif

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815767#comment-16815767 ] Andrew Purtell commented on HBASE-15560: {quote}Also the test 'fixes' for existi

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-11 Thread Zach York (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815737#comment-16815737 ] Zach York commented on HBASE-15560: --- Minor: - LOG.info(BlockCacheUtil.toJSON(e.g

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-10 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814706#comment-16814706 ] Andrew Purtell commented on HBASE-15560: After the downgrade this looks better.

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809438#comment-16809438 ] Hadoop QA commented on HBASE-15560: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-03 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809144#comment-16809144 ] Ben Manes commented on HBASE-15560: --- That's wonderful, thank you. > TinyLFU-based Blo

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-03 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809136#comment-16809136 ] Andrew Purtell commented on HBASE-15560: Good news is I've been testing TinyLFU

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-03 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809112#comment-16809112 ] Andrew Purtell commented on HBASE-15560: Oh thanks [~ben.manes]. Sorry, I came b

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-03 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809108#comment-16809108 ] Ben Manes commented on HBASE-15560: --- [~apurtell], I'm sorry for the hassle. In [2.7.0

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-04-03 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809100#comment-16809100 ] Andrew Purtell commented on HBASE-15560: org.checkerframework is not a dependenc

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804591#comment-16804591 ] Hadoop QA commented on HBASE-15560: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-28 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804458#comment-16804458 ] Andrew Purtell commented on HBASE-15560: I stand corrected about that LICENSE fi

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802323#comment-16802323 ] Andrew Purtell commented on HBASE-15560: I don't think so. I looked at the error

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802320#comment-16802320 ] Sean Busbey commented on HBASE-15560: - the build failures for shaded client, hadoop

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802316#comment-16802316 ] Andrew Purtell commented on HBASE-15560: Let's get this committed. I need a +1,

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802314#comment-16802314 ] Andrew Purtell commented on HBASE-15560: I filed HBASE-22114 for the branch-1 wo

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802305#comment-16802305 ] Sean Busbey commented on HBASE-15560: - that more or less sounds like the approach I'

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802304#comment-16802304 ] Andrew Purtell commented on HBASE-15560: If you want to try that Sean that's fin

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802303#comment-16802303 ] Andrew Purtell commented on HBASE-15560: I see [~busbey], you want to make this

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802300#comment-16802300 ] Sean Busbey commented on HBASE-15560: - If this is still in place as an optional add-

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802268#comment-16802268 ] Andrew Purtell commented on HBASE-15560: I thought we might straddle the line...

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802263#comment-16802263 ] Hadoop QA commented on HBASE-15560: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802250#comment-16802250 ] Ben Manes commented on HBASE-15560: --- Caffeine is very much dependent on Java 8 to impl

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802248#comment-16802248 ] Andrew Purtell commented on HBASE-15560: TinyLfuBlockCache is implemented with l

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802220#comment-16802220 ] Hadoop QA commented on HBASE-15560: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802094#comment-16802094 ] Andrew Purtell commented on HBASE-15560: I'm going to work on a branch-1 patch n

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802093#comment-16802093 ] Andrew Purtell commented on HBASE-15560: Master patch will apply to branch-2 wit

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802042#comment-16802042 ] Andrew Purtell commented on HBASE-15560: Update caffeine dependency version to 2

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801995#comment-16801995 ] Ben Manes commented on HBASE-15560: --- Thanks [~apurtell] and [~busbey]. Can you please

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801965#comment-16801965 ] Andrew Purtell commented on HBASE-15560: Thanks [~busbey] . I'll make a pass ove

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-26 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801881#comment-16801881 ] Sean Busbey commented on HBASE-15560: - the javac complaints I think are fall out fro

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801363#comment-16801363 ] Hadoop QA commented on HBASE-15560: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792076#comment-16792076 ] stack commented on HBASE-15560: --- Ok. > TinyLFU-based BlockCache > ---

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-13 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792071#comment-16792071 ] Andrew Purtell commented on HBASE-15560: It is perhaps not ideal but if an optio

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792028#comment-16792028 ] stack commented on HBASE-15560: --- On it being an option, there is my comment above and othe

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-13 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791980#comment-16791980 ] Andrew Purtell commented on HBASE-15560: Ok, but that isn't going to happen as w

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791961#comment-16791961 ] stack commented on HBASE-15560: --- Pardon if not clear. Yes, wanted this to be perf tested f

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-13 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791941#comment-16791941 ] Andrew Purtell commented on HBASE-15560: Cancelling the patch is not an expressi

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2019-03-12 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791215#comment-16791215 ] Ben Manes commented on HBASE-15560: --- Sorry to hear that. Thanks for trying to move thi

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2018-12-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711870#comment-16711870 ] stack commented on HBASE-15560: --- Scheduled this on 1.5 too (smile). > TinyLFU-based Block

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2018-12-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711856#comment-16711856 ] Andrew Purtell commented on HBASE-15560: We could make it default in 3.0 for sur

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2018-12-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711823#comment-16711823 ] stack commented on HBASE-15560: --- Thanks [~apurtell]. Was just hoping it was better in most

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2018-12-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711804#comment-16711804 ] Andrew Purtell commented on HBASE-15560: I came to say the feature is additive (

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2018-12-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710992#comment-16710992 ] stack commented on HBASE-15560: --- I put a petition for a volunteer on our dev list. > Tiny

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2018-12-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710991#comment-16710991 ] stack commented on HBASE-15560: --- bq. Sorry that this dropped off my radar. Smile. Two yea

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2018-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710976#comment-16710976 ] Hadoop QA commented on HBASE-15560: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2018-12-05 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710972#comment-16710972 ] Ben Manes commented on HBASE-15560: --- Sorry that this dropped off my radar. I can summa

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-12-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762027#comment-15762027 ] stack commented on HBASE-15560: --- Thanks for update [~ben.manes] Understood. > TinyLFU-base

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-12-19 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15760517#comment-15760517 ] Ben Manes commented on HBASE-15560: --- Sorry that I haven't had time to investigate this

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-10 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653675#comment-15653675 ] Yu Li commented on HBASE-15560: --- Thank you boss, will wait for your update then. :-) > Tin

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-08 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648404#comment-15648404 ] stack commented on HBASE-15560: --- I start an hbase regionserver. I make sure that the datase

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-08 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648257#comment-15648257 ] Ben Manes commented on HBASE-15560: --- If you can give me the steps to reproduce your obs

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646586#comment-15646586 ] stack commented on HBASE-15560: --- No problem [~carp84] I'm on something else but can put up

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-07 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646359#comment-15646359 ] Yu Li commented on HBASE-15560: --- Interesting one and nice work [~ben.manes]. One question

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644673#comment-15644673 ] stack commented on HBASE-15560: --- bq. Are the access keys not in the data set so that it is

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-06 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643283#comment-15643283 ] Ben Manes commented on HBASE-15560: --- Are the access keys not in the data set so that it

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643272#comment-15643272 ] stack commented on HBASE-15560: --- Right. How you going to simulate my case where lots of cac

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-06 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643270#comment-15643270 ] Ben Manes commented on HBASE-15560: --- In the last run, {{Optimal}} is {{55.50%}}. Sorry

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-06 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643265#comment-15643265 ] Ben Manes commented on HBASE-15560: --- {{quote} Would you want the same dataset loaded to

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643247#comment-15643247 ] stack commented on HBASE-15560: --- bq. Sorry for not getting to this over the weekend. A bit

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-06 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643227#comment-15643227 ] Ben Manes commented on HBASE-15560: --- Sorry for not getting to this over the weekend. A

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643207#comment-15643207 ] stack commented on HBASE-15560: --- How do I do the 'access trace' [~ben.manes] Let me know ho

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-04 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15638231#comment-15638231 ] Ben Manes commented on HBASE-15560: --- I think my first step is to get an access trace (l

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637663#comment-15637663 ] Hadoop QA commented on HBASE-15560: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637631#comment-15637631 ] stack commented on HBASE-15560: --- No rush [~ben.manes] I have a test bench up now so easy en

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-04 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637546#comment-15637546 ] Ben Manes commented on HBASE-15560: --- Thanks [~stack]! I won't be able to dig into this

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637069#comment-15637069 ] stack commented on HBASE-15560: --- Here is the key to reading the diagrams from YCSB workload

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-11-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637034#comment-15637034 ] stack commented on HBASE-15560: --- I tried this patch. It looks good. Seems faithful replacem

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-31 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623191#comment-15623191 ] stack commented on HBASE-15560: --- My bad. Yes. I MUST do this. > TinyLFU-based BlockCache >

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-30 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621071#comment-15621071 ] Ben Manes commented on HBASE-15560: --- [~stack], will you have time to test this soon? >

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-13 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571276#comment-15571276 ] Ben Manes commented on HBASE-15560: --- The update latencies, except for average, were ver

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-13 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571153#comment-15571153 ] Anoop Sam John commented on HBASE-15560: Can we test and compare both when the ca

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-13 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571144#comment-15571144 ] Eshcar Hillel commented on HBASE-15560: --- Also, the request distribution is zipfian.

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-12 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570386#comment-15570386 ] stack commented on HBASE-15560: --- Thanks Ben. Let me try it here. Should be able in next day

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-12 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570364#comment-15570364 ] Ben Manes commented on HBASE-15560: --- YCSB workload B states that each record is 1kb, so

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-12 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570204#comment-15570204 ] stack commented on HBASE-15560: --- Did all fit in memory when you ran this test [~ben.manes]?

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-08 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559308#comment-15559308 ] Ben Manes commented on HBASE-15560: --- 1. I performed "git revert b952e64" 2. Configured

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-06 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553051#comment-15553051 ] Eshcar Hillel commented on HBASE-15560: --- No unfortunately we currently don't have a

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-05 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549840#comment-15549840 ] Ben Manes commented on HBASE-15560: --- I can take another stab at (1) and work with [~esh

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549177#comment-15549177 ] stack commented on HBASE-15560: --- Thanks [~eshcar] I was going to do a basic #1 but if Ben

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-05 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549086#comment-15549086 ] Eshcar Hillel commented on HBASE-15560: --- Hi, can I add my view of this issue ? I

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546910#comment-15546910 ] Ted Yu commented on HBASE-15560: This was reverted in the morning. I have been in a supp

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546856#comment-15546856 ] stack commented on HBASE-15560: --- Thanks. Yeah, we owe you the last mile. Let us do that. [

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-04 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546678#comment-15546678 ] Ben Manes commented on HBASE-15560: --- I know the frustration and agree that feature flag

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546617#comment-15546617 ] stack commented on HBASE-15560: --- bq. This flag was to simplify evaluation. Understood. Tha

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546582#comment-15546582 ] stack commented on HBASE-15560: --- If you are saying that the old cache remains the default,

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-04 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546599#comment-15546599 ] Ben Manes commented on HBASE-15560: --- This flag was to simplify evaluation. It can eithe

[jira] [Commented] (HBASE-15560) TinyLFU-based BlockCache

2016-10-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546408#comment-15546408 ] Hudson commented on HBASE-15560: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix

  1   2   >