[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416560#comment-15416560
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416557#comment-15416557
]
stack commented on HBASE-16267:
---
I took a look. Build times seem erratic:
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416524#comment-15416524
]
Ted Yu commented on HBASE-16267:
Timed out tests were not related to patch.
I ran a few
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416513#comment-15416513
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416460#comment-15416460
]
Ted Yu commented on HBASE-16267:
I wonder what took root test(s) over two hours (4 hours since tests
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416067#comment-15416067
]
stack commented on HBASE-16267:
---
+1 on patch. Fix the release note. Doesn't make mention of why and doesn't
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416012#comment-15416012
]
stack commented on HBASE-16267:
---
To remove dependency on commons-httpclient (and HttpURLConnection) by test
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415967#comment-15415967
]
Ted Yu commented on HBASE-16267:
bq. It seems like HttpURLConnection is using httpclient as a provider.
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415769#comment-15415769
]
stack commented on HBASE-16267:
---
bq.hbase doesn't import any sun.net.* classes - hadoop does.
You miss the
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415713#comment-15415713
]
Ted Yu commented on HBASE-16267:
Updated the description with relevant JIRAs and CVE.
> Remove
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415702#comment-15415702
]
Josh Elser commented on HBASE-16267:
bq. If security vulnerability, whats difference if included
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415673#comment-15415673
]
Ted Yu commented on HBASE-16267:
bq. shouldn't we add explicit dependency on commons-httpclient?
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415661#comment-15415661
]
stack commented on HBASE-16267:
---
Looks good in all but one regard. Looks like lots of work.
Can you not
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415614#comment-15415614
]
Ted Yu commented on HBASE-16267:
[~stack]:
What do you think of the above ?
Thanks
> Remove
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412630#comment-15412630
]
Ted Yu commented on HBASE-16267:
If there is no objection, planning to commit v14 to master branch again
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412627#comment-15412627
]
Ted Yu commented on HBASE-16267:
{code}
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412618#comment-15412618
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410729#comment-15410729
]
stack commented on HBASE-16267:
---
Ok. It doesn't say that in subject. Sounds important to fix.
> Remove
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410700#comment-15410700
]
Hudson commented on HBASE-16267:
FAILURE: Integrated in HBase-Trunk_matrix #1366 (See
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410668#comment-15410668
]
Ted Yu commented on HBASE-16267:
The commons-httpclient dependency brought in by hbase-rest module
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410664#comment-15410664
]
stack commented on HBASE-16267:
---
What is this issue trying to fix?
> Remove commons-httpclient dependency
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410654#comment-15410654
]
Ted Yu commented on HBASE-16267:
Reverted from master.
Pending appropriate hadoop release before putting
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410652#comment-15410652
]
Ted Yu commented on HBASE-16267:
I spent some time (upgrading hadoop dependency to 2.7.3 RC) but
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410645#comment-15410645
]
stack commented on HBASE-16267:
---
Oh, this issue also needs a release note. It does more than the subject
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404256#comment-15404256
]
Ted Yu commented on HBASE-16267:
Test failure was due to:
TestVersionResource.setUpBeforeClass:60 ยป
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403033#comment-15403033
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402423#comment-15402423
]
Josh Elser commented on HBASE-16267:
On v12, you still have some commented out code, [~tedyu].
In
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390293#comment-15390293
]
Ted Yu commented on HBASE-16267:
The failed tests are not in hbase-rest module.
> Remove
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390290#comment-15390290
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390087#comment-15390087
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390004#comment-15390004
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389952#comment-15389952
]
Josh Elser commented on HBASE-16267:
Looks pretty good, [~tedyu]. Some quick comments.
Nit,
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389526#comment-15389526
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388998#comment-15388998
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388776#comment-15388776
]
Hadoop QA commented on HBASE-16267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
35 matches
Mail list logo
