[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2018-06-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511629#comment-16511629 ] Hudson commented on HBASE-16490: Results for branch branch-1.4 [build #353 on b

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2018-06-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510919#comment-16510919 ] Hudson commented on HBASE-16490: Results for branch branch-1 [build #347 on bui

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2018-04-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427236#comment-16427236 ] stack commented on HBASE-16490: --- This got committed with a wonky commit message making it h

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2016-08-26 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440514#comment-15440514 ] Heng Chen commented on HBASE-16490: --- commit to master > Fix race condition between Sna

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2016-08-26 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440487#comment-15440487 ] Heng Chen commented on HBASE-16490: --- Thanks [~tedyu], will address your comments when c

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2016-08-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439166#comment-15439166 ] Ted Yu commented on HBASE-16490: Looks good overall. For CleanerChore.java , the followi

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2016-08-26 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439085#comment-15439085 ] Matteo Bertozzi commented on HBASE-16490: - v2 looks good to me, +1 > Fix race co

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2016-08-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438792#comment-15438792 ] Hadoop QA commented on HBASE-16490: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2016-08-25 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436950#comment-15436950 ] Matteo Bertozzi commented on HBASE-16490: - can we use KeyLocker instead of the cu

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2016-08-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436720#comment-15436720 ] Hadoop QA commented on HBASE-16490: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2016-08-24 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435288#comment-15435288 ] Matteo Bertozzi commented on HBASE-16490: - yeah something along this line seems g

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

2016-08-24 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434424#comment-15434424 ] Heng Chen commented on HBASE-16490: --- Currently, there is no way to pass some instance