[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618733#comment-15618733
]
Hudson commented on HBASE-16891:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618295#comment-15618295
]
Duo Zhang commented on HBASE-16891:
---
It will but it could only happen in testcase. In A
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618205#comment-15618205
]
stack commented on HBASE-16891:
---
Is this a create of a Runnable per byte written? eve
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618033#comment-15618033
]
Duo Zhang commented on HBASE-16891:
---
Thanks. Will commit later if no other objections.
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617552#comment-15617552
]
ramkrishna.s.vasudevan commented on HBASE-16891:
Am ffine and +1 if tests
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617052#comment-15617052
]
Duo Zhang commented on HBASE-16891:
---
Any concerns on the new patch? [~anoopsamjohn] [~r
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615684#comment-15615684
]
Hadoop QA commented on HBASE-16891:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615279#comment-15615279
]
Duo Zhang commented on HBASE-16891:
---
Let me check the failed UTs.
> Try copying to the
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615257#comment-15615257
]
Hadoop QA commented on HBASE-16891:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615057#comment-15615057
]
Duo Zhang commented on HBASE-16891:
---
The implementation throws IOException which will m
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615019#comment-15615019
]
Anoop Sam John commented on HBASE-16891:
That is ok. I mean instead of java BAOS
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614999#comment-15614999
]
Duo Zhang commented on HBASE-16891:
---
This is used to make the behavior the same with Fa
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614990#comment-15614990
]
Anoop Sam John commented on HBASE-16891:
In AsyncFSOutputHelper
{code}
@Overrid
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614951#comment-15614951
]
ramkrishna.s.vasudevan commented on HBASE-16891:
bq.But it does not matte
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614945#comment-15614945
]
Duo Zhang commented on HBASE-16891:
---
I'm not sure but I think it will change the bb's p
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614934#comment-15614934
]
ramkrishna.s.vasudevan commented on HBASE-16891:
LGTM. Just ensure that
{
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614900#comment-15614900
]
Duo Zhang commented on HBASE-16891:
---
It was removed by accident... I wanted to change i
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614866#comment-15614866
]
ramkrishna.s.vasudevan commented on HBASE-16891:
In patch in writeMagicA
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614821#comment-15614821
]
ramkrishna.s.vasudevan commented on HBASE-16891:
I think we will commit t
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614822#comment-15614822
]
Duo Zhang commented on HBASE-16891:
---
Got it. Thanks.
So here we should make the Output
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614818#comment-15614818
]
ramkrishna.s.vasudevan commented on HBASE-16891:
The magic lies here
{cod
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614811#comment-15614811
]
Anoop Sam John commented on HBASE-16891:
U can see in EnsureKvEncoder
{code}
publ
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614798#comment-15614798
]
Duo Zhang commented on HBASE-16891:
---
I do not know what you guys have done to the CellE
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614777#comment-15614777
]
ramkrishna.s.vasudevan commented on HBASE-16891:
I can make the patch for
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614756#comment-15614756
]
Anoop Sam John commented on HBASE-16891:
Good that we can avoid 2 copy now.
But t
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614729#comment-15614729
]
ramkrishna.s.vasudevan commented on HBASE-16891:
In fact if AsyncOutput c
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614710#comment-15614710
]
ramkrishna.s.vasudevan commented on HBASE-16891:
This looks good.
So you
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612582#comment-15612582
]
ramkrishna.s.vasudevan commented on HBASE-16891:
Oh, now I got what you m
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612581#comment-15612581
]
ramkrishna.s.vasudevan commented on HBASE-16891:
Oh, now I got what you m
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611971#comment-15611971
]
Anoop Sam John commented on HBASE-16891:
We have an OS extension mainly for writi
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611828#comment-15611828
]
Duo Zhang commented on HBASE-16891:
---
I do not think this is a good idea. You should fol
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611788#comment-15611788
]
ramkrishna.s.vasudevan commented on HBASE-16891:
bq.You change the semant
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611758#comment-15611758
]
Duo Zhang commented on HBASE-16891:
---
You change the semantic of {{void write(int b)}} m
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611746#comment-15611746
]
Duo Zhang commented on HBASE-16891:
---
Oh Codec is LimitedPrivate... And BaseEncoder is a
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611737#comment-15611737
]
ramkrishna.s.vasudevan commented on HBASE-16891:
If we add new methods in
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611706#comment-15611706
]
Duo Zhang commented on HBASE-16891:
---
I think we'd better add new methods to the CellEnc
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611615#comment-15611615
]
ramkrishna.s.vasudevan commented on HBASE-16891:
[~Apache9]
Is it ok to c
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604201#comment-15604201
]
ramkrishna.s.vasudevan commented on HBASE-16891:
The hack that I tried he
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600965#comment-15600965
]
ramkrishna.s.vasudevan commented on HBASE-16891:
Both are doing PureJava3
[
https://issues.apache.org/jira/browse/HBASE-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596736#comment-15596736
]
stack commented on HBASE-16891:
---
We doing native checksumming in both places?
> Try copyin
40 matches
Mail list logo
