[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669917#comment-15669917
]
Yu Li commented on HBASE-17110:
---
[~stack]/[~anoop.hbase]/[~enis]/[~ndimiduk]/[~busbey]/[~ma
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669931#comment-15669931
]
Charlie Qiangeng Xu commented on HBASE-17110:
-
Whoops, my bad, thank you for
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670010#comment-15670010
]
Guanghao Zhang commented on HBASE-17110:
+1 for this idea. We have a similar impl
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670116#comment-15670116
]
Anoop Sam John commented on HBASE-17110:
Interesting.. Why you think this can n
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670683#comment-15670683
]
Yu Li commented on HBASE-17110:
---
Thanks for chiming in [~anoop.hbase].
The reason we make
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670696#comment-15670696
]
Yu Li commented on HBASE-17110:
---
And also thanks [~zghaobac] for chiming in. Please open an
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671108#comment-15671108
]
Ted Yu commented on HBASE-17110:
The config should be on by default.
{code}
+private
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672653#comment-15672653
]
Charlie Qiangeng Xu commented on HBASE-17110:
-
Thank you for looking into the
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672688#comment-15672688
]
Ted Yu commented on HBASE-17110:
Please upload to reviewboard.
Thanks
> Add an "Overall
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672733#comment-15672733
]
Charlie Qiangeng Xu commented on HBASE-17110:
-
Just uploaded to review board
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673597#comment-15673597
]
Hadoop QA commented on HBASE-17110:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15675548#comment-15675548
]
Enis Soztutar commented on HBASE-17110:
---
Agreed with Anoop that instead of creating
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677159#comment-15677159
]
Yu Li commented on HBASE-17110:
---
Thanks [~enis] for chiming in.
After a second thought, ag
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15686836#comment-15686836
]
Hadoop QA commented on HBASE-17110:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687151#comment-15687151
]
Ted Yu commented on HBASE-17110:
Patch v4 looks good.
Please fix findbugs warning.
> Ad
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688729#comment-15688729
]
Charlie Qiangeng Xu commented on HBASE-17110:
-
Thanks for reviewing the patch
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688976#comment-15688976
]
Hadoop QA commented on HBASE-17110:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688981#comment-15688981
]
Guanghao Zhang commented on HBASE-17110:
{code}
protected Map>>
getAssignmentsB
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689060#comment-15689060
]
Charlie Qiangeng Xu commented on HBASE-17110:
-
Hi Guanghao, thanks for pointi
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691981#comment-15691981
]
Yu Li commented on HBASE-17110:
---
Patch v5 lgtm, +1.
[~zghaobac] do above answers from [~xh
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692058#comment-15692058
]
Guanghao Zhang commented on HBASE-17110:
Yeah, Thanks for the explanation. [~xhar
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692290#comment-15692290
]
Ashish Singhi commented on HBASE-17110:
---
Give me some time, I'm also checking it.
T
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692329#comment-15692329
]
Yu Li commented on HBASE-17110:
---
Ok, waiting for the comments (smile).
> Add an "Overall S
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692643#comment-15692643
]
Anoop Sam John commented on HBASE-17110:
Did not see in detail. A quick Q
{code}
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693275#comment-15693275
]
Charlie Qiangeng Xu commented on HBASE-17110:
-
Hi Anoop, ideal I shouldn't ad
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693274#comment-15693274
]
Charlie Qiangeng Xu commented on HBASE-17110:
-
Hi Anoop, ideal I shouldn't ad
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693301#comment-15693301
]
Anoop Sam John commented on HBASE-17110:
Am not very sure abt the code flow in LB
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693320#comment-15693320
]
Ted Yu commented on HBASE-17110:
w.r.t. dropping 'this.balancer instanceof SimpleLoadBala
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693574#comment-15693574
]
Anoop Sam John commented on HBASE-17110:
Thanks Ted. Ya we should be able to do r
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694615#comment-15694615
]
Charlie Qiangeng Xu commented on HBASE-17110:
-
Good suggestion!
Should I ad
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694890#comment-15694890
]
Yu Li commented on HBASE-17110:
---
I concur to add the {{balanceCluster}} interface to LB. Fr
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694901#comment-15694901
]
Ashish Singhi commented on HBASE-17110:
---
LB is an interface and it may break client
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694909#comment-15694909
]
Anoop Sam John commented on HBASE-17110:
It is private marked.. So we can break t
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696937#comment-15696937
]
Ted Yu commented on HBASE-17110:
Adding the above method should be fine.
As long as Stoc
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15700864#comment-15700864
]
Yu Li commented on HBASE-17110:
---
Probably this is covered in HBASE-17178, let me confirm th
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701462#comment-15701462
]
Hadoop QA commented on HBASE-17110:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701705#comment-15701705
]
Ted Yu commented on HBASE-17110:
{code}
+ * @param regionStates
+ */
+ void setClust
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701706#comment-15701706
]
Ted Yu commented on HBASE-17110:
Looks good overall.
> Add an "Overall Strategy" option(
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702074#comment-15702074
]
Hadoop QA commented on HBASE-17110:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702379#comment-15702379
]
Yu Li commented on HBASE-17110:
---
Please address below javadoc warnings reported by HadoopQA
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704277#comment-15704277
]
Hadoop QA commented on HBASE-17110:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704794#comment-15704794
]
Charlie Qiangeng Xu commented on HBASE-17110:
-
Checked the failed test "TestH
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705547#comment-15705547
]
Yu Li commented on HBASE-17110:
---
Latest patch LGTM, +1
[~ted_yu], [~enis] and [~anoop.hbas
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707354#comment-15707354
]
Yu Li commented on HBASE-17110:
---
Ok, planing to commit it soon if no objections. Will updat
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707921#comment-15707921
]
Ted Yu commented on HBASE-17110:
Test failure was not related to the patch.
Should be go
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708043#comment-15708043
]
Yu Li commented on HBASE-17110:
---
Thanks for review [~tedyu], will commit this soon.
> Add
46 matches
Mail list logo