[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-22 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688593#comment-15688593 ] Duo Zhang commented on HBASE-17132: --- Theoretically it is changed but actually it is not

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-22 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687831#comment-15687831 ] Enis Soztutar commented on HBASE-17132: --- bq. There is a catch CorruptedLogFileExcep

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687109#comment-15687109 ] Hudson commented on HBASE-17132: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685775#comment-15685775 ] Duo Zhang commented on HBASE-17132: --- Will commit the v1 patch later if no objections.

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685745#comment-15685745 ] Hadoop QA commented on HBASE-17132: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685524#comment-15685524 ] Duo Zhang commented on HBASE-17132: --- {quote} We were reading the PB WAL magic twice bef

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685357#comment-15685357 ] Duo Zhang commented on HBASE-17132: --- {quote} WALSplitter.getReader() still throws Corru

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684705#comment-15684705 ] stack commented on HBASE-17132: --- Sounds good (Man, still Writeables!) > Cleanup deprecated

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684601#comment-15684601 ] Enis Soztutar commented on HBASE-17132: --- bq. Purge HbaseObjectWritableFor96Migratio

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684592#comment-15684592 ] stack commented on HBASE-17132: --- Purge HbaseObjectWritableFor96Migration too. > Cleanup d

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684561#comment-15684561 ] Enis Soztutar commented on HBASE-17132: --- Great, the patch is a almost identical to

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684453#comment-15684453 ] Enis Soztutar commented on HBASE-17132: --- Sigh, I had the same patches at HBASE-1647

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684297#comment-15684297 ] stack commented on HBASE-17132: --- Skimmed. +1. This is excellent cleanup. Thanks [~Apache9]

[jira] [Commented] (HBASE-17132) Cleanup deprecated code for WAL

2016-11-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683712#comment-15683712 ] Hadoop QA commented on HBASE-17132: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||