[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-17 Thread Jianwei Cui (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756766#comment-15756766 ] Jianwei Cui commented on HBASE-17330: - In {{SnapshotFileCache#refreshCache}}, the mod

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756778#comment-15756778 ] Ted Yu commented on HBASE-17330: Interesting. I guess adding a unit test would be diffic

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-17 Thread Jianwei Cui (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15757119#comment-15757119 ] Jianwei Cui commented on HBASE-17330: - Thanks for the review [~tedyu]. As mentioned a

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15758387#comment-15758387 ] Hadoop QA commented on HBASE-17330: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-19 Thread Jianwei Cui (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763115#comment-15763115 ] Jianwei Cui commented on HBASE-17330: - The failed test passed locally, could you plea

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763151#comment-15763151 ] Ted Yu commented on HBASE-17330: lgtm > SnapshotFileCache will always refresh the file c

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-22 Thread Jianwei Cui (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769907#comment-15769907 ] Jianwei Cui commented on HBASE-17330: - Thanks for the review, Ted. > SnapshotFileCac

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770107#comment-15770107 ] Hudson commented on HBASE-17330: FAILURE: Integrated in Jenkins build HBase-1.4 #577 (See

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770330#comment-15770330 ] Hudson commented on HBASE-17330: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-22 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770633#comment-15770633 ] stack commented on HBASE-17330: --- [~cuijianwei] Have you tried your fix? Is mod time reliabl

[jira] [Commented] (HBASE-17330) SnapshotFileCache will always refresh the file cache

2016-12-22 Thread Jianwei Cui (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771727#comment-15771727 ] Jianwei Cui commented on HBASE-17330: - Thanks for pointing out the mod time problem,