[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999500#comment-15999500
]
Hudson commented on HBASE-17471:
SUCCESS: Integrated in Jenkins build HBase-1.4 #725 (See
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998032#comment-15998032
]
Yu Li commented on HBASE-17471:
---
Skimmed patch, LGTM, +1.
Since UT passed and the trunk version already
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994391#comment-15994391
]
Allan Yang commented on HBASE-17471:
{quote}
Allan Yang Please fix the findbugs issue and check
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994311#comment-15994311
]
Yu Li commented on HBASE-17471:
---
Seems HadoopQA has recovered, thanks for taking a look sir [~busbey].
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994258#comment-15994258
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993151#comment-15993151
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993147#comment-15993147
]
Sean Busbey commented on HBASE-17471:
-
this looks like the issue [~elserj] recent brought up on
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992602#comment-15992602
]
Yu Li commented on HBASE-17471:
---
Checking console output of the build, we could see below information:
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990680#comment-15990680
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990632#comment-15990632
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972004#comment-15972004
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971992#comment-15971992
]
Allan Yang commented on HBASE-17471:
{quote}
Back on this one...
Seems one findbugs issue left for
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946690#comment-15946690
]
Yu Li commented on HBASE-17471:
---
Back on this one...
Seems one findbugs issue left for the branch-1 patch,
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887953#comment-15887953
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887798#comment-15887798
]
Allan Yang commented on HBASE-17471:
hadoop.hbase.replication.TestSerialReplication passed locally
>
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887763#comment-15887763
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887347#comment-15887347
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885962#comment-15885962
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877647#comment-15877647
]
Yu Li commented on HBASE-17471:
---
bq. maybe several days later
Ok, thanks, good to know :-)
> Region Seqid
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877604#comment-15877604
]
Allan Yang commented on HBASE-17471:
Thanks for your perf data, [~carp84]. Sure, I will complete the
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877589#comment-15877589
]
Yu Li commented on HBASE-17471:
---
Since HBASE-16698 also went into branch-1, we also need this
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877550#comment-15877550
]
Yu Li commented on HBASE-17471:
---
Here is the performance data before/after change here in our customized
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837373#comment-15837373
]
Hadoop QA commented on HBASE-17471:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837325#comment-15837325
]
Yu Li commented on HBASE-17471:
---
bq. As we tested this patch in our custom HBase-1.1.2, there is no
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837237#comment-15837237
]
Duo Zhang commented on HBASE-17471:
---
{quote}
If not 'inMemstore', mvcc is just used for seqid assign,
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837229#comment-15837229
]
Allan Yang commented on HBASE-17471:
'inMemstore' is OK I think, mvcc is only needed to ensure data
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837226#comment-15837226
]
Duo Zhang commented on HBASE-17471:
---
I think the problem is the parameter name 'inMemstore'. If the
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837210#comment-15837210
]
Allan Yang commented on HBASE-17471:
Sorry, replay would expect some delays 'Cause Chinese spring
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837078#comment-15837078
]
Yu Li commented on HBASE-17471:
---
bq. yes, I'm using HDD for the test, we only need a comparison, right?
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836827#comment-15836827
]
stack commented on HBASE-17471:
---
[~allan163], what [~carp84] said regards tests passing though there are
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834695#comment-15834695
]
Ted Yu commented on HBASE-17471:
Allan:
Thanks for your effort.
Please start collecting performance
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834249#comment-15834249
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834205#comment-15834205
]
Duo Zhang commented on HBASE-17471:
---
{quote}
some unit tests haven't complete them after append
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834182#comment-15834182
]
Allan Yang commented on HBASE-17471:
Attached HBASE-17471.v4.patch based on [~Apache9]'s
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834181#comment-15834181
]
Duo Zhang commented on HBASE-17471:
---
[~allan163] I've already modified the UTs to always construct
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834058#comment-15834058
]
Allan Yang commented on HBASE-17471:
OK, Thanks a lot! [~Apache9]
> Region Seqid will be out of
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834047#comment-15834047
]
Duo Zhang commented on HBASE-17471:
---
{quote}
The main different is that, I think we don't have to
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834035#comment-15834035
]
Allan Yang commented on HBASE-17471:
[~Apache9] Thanks for your patch, your patch is more clear, and
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834030#comment-15834030
]
Duo Zhang commented on HBASE-17471:
---
Most UTs are failed because of NPE which is caused by lack of
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834019#comment-15834019
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833941#comment-15833941
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833930#comment-15833930
]
Yu Li commented on HBASE-17471:
---
bq. MVCC and region seqid are totally different concept, combing then
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833917#comment-15833917
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833886#comment-15833886
]
Allan Yang commented on HBASE-17471:
When I say 'a lot of problems'， I mean performance problem &
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833874#comment-15833874
]
Yu Li commented on HBASE-17471:
---
bq. I'd like to say, separating them can truly resolve a lot of problems.
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833865#comment-15833865
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833862#comment-15833862
]
Allan Yang commented on HBASE-17471:
Actually, we notice the performance regression after merging
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833858#comment-15833858
]
Yu Li commented on HBASE-17471:
---
bq. I still do not think we need a configurable preAssign...
Ok, maybe I'm
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833852#comment-15833852
]
Yu Li commented on HBASE-17471:
---
bq. Yu Li Could you please help testing the performance of the change as
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833844#comment-15833844
]
Allan Yang commented on HBASE-17471:
Thank you for your opinion [~carp84], will rebase the code and
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833842#comment-15833842
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833840#comment-15833840
]
Duo Zhang commented on HBASE-17471:
---
{quote}
I think we need only synchronize the acquirement of
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833836#comment-15833836
]
Yu Li commented on HBASE-17471:
---
Ok, so you've already take the new design, quick action (smile).
I
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833822#comment-15833822
]
Allan Yang commented on HBASE-17471:
I think we need only synchronize the acquirement of seqid/mvcc
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833816#comment-15833816
]
Duo Zhang commented on HBASE-17471:
---
I still do not think we need a configurable preAssign...
We can
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833811#comment-15833811
]
Hadoop QA commented on HBASE-17471:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829425#comment-15829425
]
Yu Li commented on HBASE-17471:
---
+1 on the fix. IIRC, [~enis] also mentioned not to include any
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828226#comment-15828226
]
Allan Yang commented on HBASE-17471:
Added a UT to show the disorder in the WAL, [~carp84] and
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828236#comment-15828236
]
Ted Yu commented on HBASE-17471:
Please upload the fix.
> Region Seqid will be out of order in WAL if
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823338#comment-15823338
]
Allan Yang commented on HBASE-17471:
Thank you, Ted, have changed the test name and the path name.
[
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823205#comment-15823205
]
Ted Yu commented on HBASE-17471:
I think we should maintain increasing sequence Id.
About the test, it
61 matches
Mail list logo
