[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834309#comment-15834309 ] Hudson commented on HBASE-17491: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833961#comment-15833961 ] Hadoop QA commented on HBASE-17491: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833943#comment-15833943 ] Yu Li commented on HBASE-17491: --- Pushed to master branch. Thanks all for review [~stack] [~

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833419#comment-15833419 ] Yu Li commented on HBASE-17491: --- bq. On commit, change the class comment so it says since 2

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833325#comment-15833325 ] Hadoop QA commented on HBASE-17491: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833308#comment-15833308 ] stack commented on HBASE-17491: --- +1 on v7. On commit, change the class comment so it says

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833266#comment-15833266 ] Yu Li commented on HBASE-17491: --- Ah, I see, will check and fix this. Thanks for the clarifi

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833257#comment-15833257 ] stack commented on HBASE-17491: --- Ugh. I meant to say the patch applied but does not build.

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833228#comment-15833228 ] Yu Li commented on HBASE-17491: --- I checked locally and patch v6 could apply cleanly to mast

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833071#comment-15833071 ] stack commented on HBASE-17491: --- FYI [~carp84], patch does not apply to master branch. > R

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832921#comment-15832921 ] Hadoop QA commented on HBASE-17491: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832906#comment-15832906 ] Yu Li commented on HBASE-17491: --- Thanks for chiming in [~enis]. bq. Will AsyncTableBuilder

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832579#comment-15832579 ] Enis Soztutar commented on HBASE-17491: --- Will AsyncTableBuilder extend TableBuilder

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832442#comment-15832442 ] Hadoop QA commented on HBASE-17491: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832300#comment-15832300 ] stack commented on HBASE-17491: --- bq. Yes, by means to trigger hbase-server UT and make sure

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832289#comment-15832289 ] Yu Li commented on HBASE-17491: --- bq. Just seems odd making an interface and not using it It

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832116#comment-15832116 ] stack commented on HBASE-17491: --- Just seems odd making an Interface and not using it. This

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831704#comment-15831704 ] Hadoop QA commented on HBASE-17491: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831434#comment-15831434 ] Yu Li commented on HBASE-17491: --- Thanks for the review [~tedyu] [~Apache9] and [~stack]. b

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831307#comment-15831307 ] stack commented on HBASE-17491: --- Remove this on commit: 2856// trivial change to t

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831286#comment-15831286 ] Duo Zhang commented on HBASE-17491: --- LGTM. +1. > Remove all setters from HTable interf

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830911#comment-15830911 ] Ted Yu commented on HBASE-17491: Patch v3 looks good. > Remove all setters from HTable i

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830905#comment-15830905 ] Yu Li commented on HBASE-17491: --- UT looks good, and will revert the trivial change for trig

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830433#comment-15830433 ] Hadoop QA commented on HBASE-17491: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830213#comment-15830213 ] Ted Yu commented on HBASE-17491: {code} 32 @InterfaceAudience.Public 33 @Interf

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830152#comment-15830152 ] Hadoop QA commented on HBASE-17491: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17491) Remove all setters from HTable interface and introduce a TableBuilder to build Table instance

[ https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829884#comment-15829884 ] Hadoop QA commented on HBASE-17491: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo