[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719329#comment-16719329
]
Lars Hofhansl commented on HBASE-17958:
---
I do like the address compare idea above,
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719318#comment-16719318
]
Lars Hofhansl commented on HBASE-17958:
---
Looking at this one again... Since it pop
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447538#comment-16447538
]
Vikas Vishwakarma commented on HBASE-17958:
---
Actually [~apurtell] [~lhofhansl]
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447481#comment-16447481
]
Andrew Purtell commented on HBASE-17958:
Ok just to confirm - 1.4 and up, not 1.3
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447456#comment-16447456
]
Vikas Vishwakarma commented on HBASE-17958:
---
[~lhofhansl] [~Apache9] we are ok
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447109#comment-16447109
]
Vikas Vishwakarma commented on HBASE-17958:
---
sure [~lhofhansl] [~Apache9] I wil
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447057#comment-16447057
]
Duo Zhang commented on HBASE-17958:
---
I still need to say that, never try to revert the
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446908#comment-16446908
]
Lars Hofhansl commented on HBASE-17958:
---
Seems we god stuck here. [~vik.karma] did
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210563#comment-16210563
]
Lars Hofhansl commented on HBASE-17958:
---
bq. sad thing is that, the indexed key cou
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210558#comment-16210558
]
Lars Hofhansl commented on HBASE-17958:
---
bq. How about we move optimize SEEK to SKI
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209077#comment-16209077
]
Guanghao Zhang commented on HBASE-17958:
File a new issue HBASE-19034 for this. T
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208930#comment-16208930
]
Duo Zhang commented on HBASE-17958:
---
+1 on move this optimization to StoreFileScanner.
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208921#comment-16208921
]
Guanghao Zhang commented on HBASE-17958:
bq. When the heap changed the current st
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208863#comment-16208863
]
Guanghao Zhang commented on HBASE-17958:
bq. The duplicate compares in trySkipToN
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208854#comment-16208854
]
Duo Zhang commented on HBASE-17958:
---
This is the code in patch v3.
{code}
pr
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208853#comment-16208853
]
Guanghao Zhang commented on HBASE-17958:
bq. But it seems to me we should check f
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208826#comment-16208826
]
Lars Hofhansl commented on HBASE-17958:
---
I can fairly easily eliminate the repeated
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208801#comment-16208801
]
Lars Hofhansl commented on HBASE-17958:
---
So I just ran a things through a profiler
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999274#comment-15999274
]
Hudson commented on HBASE-17958:
FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995531#comment-15995531
]
Hudson commented on HBASE-17958:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995160#comment-15995160
]
Hudson commented on HBASE-17958:
FAILURE: Integrated in Jenkins build HBase-1.4 #718 (See
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994779#comment-15994779
]
Duo Zhang commented on HBASE-17958:
---
+1.
> Avoid passing unexpected cell to ScanQueryM
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994744#comment-15994744
]
Hadoop QA commented on HBASE-17958:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994598#comment-15994598
]
Guanghao Zhang commented on HBASE-17958:
The failed UTs should be not related. I
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994353#comment-15994353
]
Duo Zhang commented on HBASE-17958:
---
[~zghaobac] Could you please verify if the failed
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994344#comment-15994344
]
Hadoop QA commented on HBASE-17958:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993273#comment-15993273
]
Hadoop QA commented on HBASE-17958:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992996#comment-15992996
]
Hadoop QA commented on HBASE-17958:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992398#comment-15992398
]
Duo Zhang commented on HBASE-17958:
---
One problem, BiFunction is introduced in java8 so
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992149#comment-15992149
]
Guanghao Zhang commented on HBASE-17958:
When the heap changed the current storef
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988623#comment-15988623
]
Hadoop QA commented on HBASE-17958:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988404#comment-15988404
]
Duo Zhang commented on HBASE-17958:
---
Oh, I see. We will pass a fake cell to SQM and SQM
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988395#comment-15988395
]
Duo Zhang commented on HBASE-17958:
---
I do not follow. What's the problem? The next scan
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988392#comment-15988392
]
Guanghao Zhang commented on HBASE-17958:
When optimize seek to skip, it will call
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986621#comment-15986621
]
Guanghao Zhang commented on HBASE-17958:
TestBlocksRead failed on my computer, to
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986534#comment-15986534
]
Hadoop QA commented on HBASE-17958:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986481#comment-15986481
]
Duo Zhang commented on HBASE-17958:
---
Is TestBlocksRead related?
> Avoid passing unexpe
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986380#comment-15986380
]
Hadoop QA commented on HBASE-17958:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986092#comment-15986092
]
Guanghao Zhang commented on HBASE-17958:
bq. Just like what we have done when swi
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986082#comment-15986082
]
Duo Zhang commented on HBASE-17958:
---
And if you really want to eliminate the extra comp
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986032#comment-15986032
]
Duo Zhang commented on HBASE-17958:
---
Yeah there will be one extra compare but I think i
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986024#comment-15986024
]
Lars Hofhansl commented on HBASE-17958:
---
bq. Can you imagine that, you call a seek
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986019#comment-15986019
]
Lars Hofhansl commented on HBASE-17958:
---
Looks good generally.
Are you sure we're n
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985989#comment-15985989
]
Duo Zhang commented on HBASE-17958:
---
Can avoid using lambda expression as I think the p
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985912#comment-15985912
]
Hadoop QA commented on HBASE-17958:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985798#comment-15985798
]
Duo Zhang commented on HBASE-17958:
---
The precommit admin job is broken. I have triggere
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984014#comment-15984014
]
Guanghao Zhang commented on HBASE-17958:
Code in ColumnCountGetFilter.
{code}
p
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984003#comment-15984003
]
Guanghao Zhang commented on HBASE-17958:
Add a ut testWithColumnCountGetFilter to
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983994#comment-15983994
]
Duo Zhang commented on HBASE-17958:
---
I do not think so.
Can you imagine that, you call
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983966#comment-15983966
]
Lars Hofhansl commented on HBASE-17958:
---
The problem is the order in which the filt
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983917#comment-15983917
]
Duo Zhang commented on HBASE-17958:
---
The idea is good, and converting seek to skip is a
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983320#comment-15983320
]
Lars Hofhansl commented on HBASE-17958:
---
It is expected that the column trackers so
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983308#comment-15983308
]
Lars Hofhansl commented on HBASE-17958:
---
Do you guys have a unit test to show this?
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982809#comment-15982809
]
Guanghao Zhang commented on HBASE-17958:
[~anoop.hbase] I found this problem when
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982801#comment-15982801
]
Duo Zhang commented on HBASE-17958:
---
[~zghaobac] hit the bug when implementing ColumnCo
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982738#comment-15982738
]
Anoop Sam John commented on HBASE-17958:
bq.In fact, if we decide that a skip is
[
https://issues.apache.org/jira/browse/HBASE-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982567#comment-15982567
]
Duo Zhang commented on HBASE-17958:
---
Yeah this is really a bad practice. The filter ret
57 matches
Mail list logo
