[jira] [Commented] (HBASE-18126) Increment class

2017-06-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039429#comment-16039429 ] Ted Yu commented on HBASE-18126: Addendum pushed into branch. > Increment class > --

[jira] [Commented] (HBASE-18126) Increment class

2017-06-06 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039403#comment-16039403 ] Enis Soztutar commented on HBASE-18126: --- Thanks Ted. Can you please do a little add

[jira] [Commented] (HBASE-18126) Increment class

2017-06-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037847#comment-16037847 ] Ted Yu commented on HBASE-18126: Added tests in bytes-util-test for large positive number

[jira] [Commented] (HBASE-18126) Increment class

2017-06-05 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037615#comment-16037615 ] Enis Soztutar commented on HBASE-18126: --- Can you please address these: - This shou

[jira] [Commented] (HBASE-18126) Increment class

2017-06-02 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035180#comment-16035180 ] Enis Soztutar commented on HBASE-18126: --- bq. This is the interesting part: though D

[jira] [Commented] (HBASE-18126) Increment class

2017-06-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034810#comment-16034810 ] Ted Yu commented on HBASE-18126: This is the interesting part: though DebugString() says

[jira] [Commented] (HBASE-18126) Increment class

2017-06-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033901#comment-16033901 ] Ted Yu commented on HBASE-18126: Debugging why mutate response conversion doesn't work. H

[jira] [Commented] (HBASE-18126) Increment class

2017-06-01 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033674#comment-16033674 ] Enis Soztutar commented on HBASE-18126: --- Looks good overall. A couple of comments:

[jira] [Commented] (HBASE-18126) Increment class

2017-05-30 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029876#comment-16029876 ] Enis Soztutar commented on HBASE-18126: --- Are you gonna do Append here as well, or t