[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-10-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195079#comment-16195079 ] Hudson commented on HBASE-18825: Results for branch HBASE-18467, done in 4 hr 24 min and counting

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178754#comment-16178754 ] Hudson commented on HBASE-18825: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3775 (See

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178677#comment-16178677 ] Hudson commented on HBASE-18825: FAILURE: Integrated in Jenkins build HBase-2.0 #574 (See

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178435#comment-16178435 ] Duo Zhang commented on HBASE-18825: --- Let me commit. > Use HStoreFile instead of StoreFile in our own

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178235#comment-16178235 ] Hadoop QA commented on HBASE-18825: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178149#comment-16178149 ] Hadoop QA commented on HBASE-18825: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177980#comment-16177980 ] stack commented on HBASE-18825: --- +1 on latest patch (I skimmed the difference). File a follow-on to

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177891#comment-16177891 ] Hadoop QA commented on HBASE-18825: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-23 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177869#comment-16177869 ] Chia-Ping Tsai commented on HBASE-18825: bq. I think so. Region is not something simple like

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1619#comment-1619 ] Duo Zhang commented on HBASE-18825: --- Went out for a business trip this week and just came back... Let

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-22 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177401#comment-16177401 ] stack commented on HBASE-18825: --- I'm good w/ the patch. Its great. Needs another go around I'd say but then

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-22 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177243#comment-16177243 ] stack commented on HBASE-18825: --- I started reviewing the patch again now I have the philosophy that drives

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-22 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177164#comment-16177164 ] stack commented on HBASE-18825: --- [~Apache9] bq. Region is not something simple like RegionSplitPolicy. It

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-21 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175950#comment-16175950 ] ramkrishna.s.vasudevan commented on HBASE-18825: bq.What about StoreFile? I'm thinking

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-21 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175924#comment-16175924 ] Anoop Sam John commented on HBASE-18825: bq.What about StoreFile? I'm thinking about alternate

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-21 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175918#comment-16175918 ] Anoop Sam John commented on HBASE-18825: bq.That Region and Store were made to feed CP is also an

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175917#comment-16175917 ] Duo Zhang commented on HBASE-18825: --- {quote} So, we disabuse ourselves of any notion that another might

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175472#comment-16175472 ] stack commented on HBASE-18825: --- Oh, yeah, as suggested above, needs airing on dev list if only to bring

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175470#comment-16175470 ] stack commented on HBASE-18825: --- Ok. Thanks for the philosophy. That helps. So, we disabuse ourselves of

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173134#comment-16173134 ] Duo Zhang commented on HBASE-18825: --- {quote} Not a fan of passing a heavy all-in-one object to

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-20 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173071#comment-16173071 ] Chia-Ping Tsai commented on HBASE-18825: bq. But we can argue that our coding is based on the

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172992#comment-16172992 ] Anoop Sam John commented on HBASE-18825: bq.And for the config of region implementation class, I

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172981#comment-16172981 ] Duo Zhang commented on HBASE-18825: --- Yes, RSS is a little different. We pass it everywhere as a service

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172973#comment-16172973 ] Anoop Sam John commented on HBASE-18825: What I said in 1st part of my reply is bq.For StoreFile,

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172965#comment-16172965 ] Duo Zhang commented on HBASE-18825: --- [~stack] [~anoopsamjohn] I think we both agree that we need to

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172815#comment-16172815 ] Anoop Sam John commented on HBASE-18825: bq.For StoreFile, Store, and Region, we will not have

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-19 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172703#comment-16172703 ] Chia-Ping Tsai commented on HBASE-18825: bq. The problem for now is that we also uses the

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172430#comment-16172430 ] Duo Zhang commented on HBASE-18825: --- For StoreFile, Store, and Region, we will not have multiple

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171975#comment-16171975 ] stack commented on HBASE-18825: --- What is the philosophy/motivation here [~Apache9]? I started to look at

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171631#comment-16171631 ] Hadoop QA commented on HBASE-18825: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171003#comment-16171003 ] Duo Zhang commented on HBASE-18825: --- [~anoopsamjohn] [~stack] PTAL. Thanks. > Use HStoreFile instead

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170409#comment-16170409 ] Hadoop QA commented on HBASE-18825: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170053#comment-16170053 ] Hadoop QA commented on HBASE-18825: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

2017-09-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169796#comment-16169796 ] Hadoop QA commented on HBASE-18825: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem