[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-10-18 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210114#comment-16210114 ] Appy commented on HBASE-18898: -- Spent few hours reading Guice user guide. So can do DI on constructors,

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-10-16 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206860#comment-16206860 ] Appy commented on HBASE-18898: -- bq. ...don't have to enforce particular method signatures. The consumers can

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-10-16 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1620#comment-1620 ] Andrew Purtell commented on HBASE-18898: I agree with [~mdrob] comments above. Often in JAX-RS

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-10-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206490#comment-16206490 ] Mike Drob commented on HBASE-18898: --- bq. That'll at least give power of compile time checks. Checking

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-10-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206487#comment-16206487 ] Mike Drob commented on HBASE-18898: --- Another benefit is that a single function can be annotated as

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-10-16 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206459#comment-16206459 ] Appy commented on HBASE-18898: -- Thinking about it more: By annotated methods, i assume you mean something

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-10-16 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206443#comment-16206443 ] Appy commented on HBASE-18898: -- I considered the annotation way earlier, but didn't suggest that because of

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-09-29 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186734#comment-16186734 ] Andrew Purtell commented on HBASE-18898: [~appy] A less ugly way to do what you propose is use

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-09-28 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185234#comment-16185234 ] Appy commented on HBASE-18898: -- The only way i can think of to do this is: Say we want to do this for

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-09-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184832#comment-16184832 ] stack commented on HBASE-18898: --- bq. Won't the hotspot optimize the no-op method calls out? If a CP in

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-09-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184799#comment-16184799 ] Mike Drob commented on HBASE-18898: --- Won't the hotspot optimize the no-op method calls out? > Provide

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-09-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184726#comment-16184726 ] stack commented on HBASE-18898: --- This is indeed a good one. I only recently realized (or remembered) that

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-09-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183707#comment-16183707 ] Anoop Sam John commented on HBASE-18898: Will try working on this post 2.0 > Provide way for the

[jira] [Commented] (HBASE-18898) Provide way for the core flow to know whether CP implemented each of the hooks

2017-09-27 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183692#comment-16183692 ] ramkrishna.s.vasudevan commented on HBASE-18898: bq.CPObject.hasPre(), then CPObject.