[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324810#comment-16324810 ] Hudson commented on HBASE-19752: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-12 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324797#comment-16324797 ] Andrew Purtell commented on HBASE-19752: bq. Somehow I used a partial branch-1 pa

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324746#comment-16324746 ] Ted Yu commented on HBASE-19752: Commit to branch-1 was correct. Somehow I used a partial

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324532#comment-16324532 ] Hadoop QA commented on HBASE-19752: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-12 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324516#comment-16324516 ] Andrew Purtell commented on HBASE-19752: +1 > RSGroupBasedLoadBalancer#getMispla

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324497#comment-16324497 ] Ted Yu commented on HBASE-19752: >From HBASE-19757 : bq. For HBASE-19752, change the log

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-12 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324458#comment-16324458 ] Andrew Purtell commented on HBASE-19752: The first new conditional in v8 patch in

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323242#comment-16323242 ] Hadoop QA commented on HBASE-19752: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323158#comment-16323158 ] Mike Drob commented on HBASE-19752: --- Add VisibleForTesting annotation please. I don't r

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323130#comment-16323130 ] Ted Yu commented on HBASE-19752: [~apurtell]: Do you have other comment ? > RSGroupBased

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322599#comment-16322599 ] Hadoop QA commented on HBASE-19752: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-10 Thread Guangxu Cheng (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321679#comment-16321679 ] Guangxu Cheng commented on HBASE-19752: --- lgtm > RSGroupBasedLoadBalancer#getMispla

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-10 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321584#comment-16321584 ] Andrew Purtell commented on HBASE-19752: Unit test, please > RSGroupBasedLoadBal

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320925#comment-16320925 ] Hadoop QA commented on HBASE-19752: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320812#comment-16320812 ] Mike Drob commented on HBASE-19752: --- bq. +LOG.debug("There is no assigned serve

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320737#comment-16320737 ] Hadoop QA commented on HBASE-19752: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320645#comment-16320645 ] Hadoop QA commented on HBASE-19752: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined

2018-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320499#comment-16320499 ] Hadoop QA commented on HBASE-19752: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo