[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-06-27 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525950#comment-16525950 ] Reid Chan commented on HBASE-20095: --- Thanks all, got it, just leave it. > Redesign single instance

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-06-27 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525949#comment-16525949 ] Reid Chan commented on HBASE-20095: --- I want to push HBASE-20732 to branch-2.0, but found it missed

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-06-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525948#comment-16525948 ] stack commented on HBASE-20095: --- bq. ... it is ok to ignore the 2.0 because 2.0 has been in

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-06-27 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525945#comment-16525945 ] Chia-Ping Tsai commented on HBASE-20095: {quote}Reopen to backport branch-2.0 {quote} If this

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-04-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430079#comment-16430079 ] Hudson commented on HBASE-20095: Results for branch HBASE-19064 [build #90 on

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-04-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428270#comment-16428270 ] Hudson commented on HBASE-20095: Results for branch master [build #285 on

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-04-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427652#comment-16427652 ] Hudson commented on HBASE-20095: Results for branch branch-2 [build #574 on

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-04-05 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427289#comment-16427289 ] Mike Drob commented on HBASE-20095: --- addendum looks fine > Redesign single instance pool in

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-04-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426954#comment-16426954 ] Reid Chan commented on HBASE-20095: --- Ted, i already applied your addendum in patch HBASE-20352 for

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-04-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424133#comment-16424133 ] Ted Yu commented on HBASE-20095: Ping [~mdrob] Please take a look at the addendum at your convenience.

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419785#comment-16419785 ] Ted Yu commented on HBASE-20095: Ping [~mdrob] Please take a look at the addendum. > Redesign single

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417444#comment-16417444 ] Ted Yu commented on HBASE-20095: Ping [~mdrob] > Redesign single instance pool in CleanerChore >

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416708#comment-16416708 ] Hudson commented on HBASE-20095: Results for branch HBASE-19064 [build #77 on

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415972#comment-16415972 ] Ted Yu commented on HBASE-20095: [~mdrob]: Please take a look at the addendum. > Redesign single

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415513#comment-16415513 ] Hudson commented on HBASE-20095: Results for branch master [build #274 on

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415192#comment-16415192 ] Ted Yu commented on HBASE-20095: The test failure was for load balancer which was not related to

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415143#comment-16415143 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414999#comment-16414999 ] Ted Yu commented on HBASE-20095: Addendum 2 incorporates the above suggestion. > Redesign single

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414989#comment-16414989 ] Reid Chan commented on HBASE-20095: --- BTW, {{wait}} without while loop will trigger {{findbugs}}

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414954#comment-16414954 ] Reid Chan commented on HBASE-20095: --- LGTM, thanks Ted. > Redesign single instance pool in CleanerChore

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414943#comment-16414943 ] Ted Yu commented on HBASE-20095: Please review this addendum: https://pastebin.com/Z8TCmzu1

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414938#comment-16414938 ] Reid Chan commented on HBASE-20095: --- Your simplification is to avoid updating immediately and leaves it

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414934#comment-16414934 ] Ted Yu commented on HBASE-20095: If you agree with what I said above, I have an addendum simplifying the

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414929#comment-16414929 ] Ted Yu commented on HBASE-20095: bq. If POOL.submit() is called first (also synchronized) That is where

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414927#comment-16414927 ] Reid Chan commented on HBASE-20095: --- O~, i'm taking a look, thanks [~yuzhih...@gmail.com] > Redesign

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414919#comment-16414919 ] Reid Chan commented on HBASE-20095: --- Looks like an edge case, pool in {{updatePool(long)}} is in

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414908#comment-16414908 ] Ted Yu commented on HBASE-20095: I am thinking about the following simplification:

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414897#comment-16414897 ] Ted Yu commented on HBASE-20095: Reid: Do you think the following scenario is possible ? Thread1: runs

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414787#comment-16414787 ] Hudson commented on HBASE-20095: Results for branch branch-2 [build #533 on

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414220#comment-16414220 ] Mike Drob commented on HBASE-20095: --- pushed to master and branch-2. [~stack] - ok for branch-2.0? >

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413441#comment-16413441 ] Reid Chan commented on HBASE-20095: --- {code} javac -1, NettyRpcServer.java:[148,45]

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413426#comment-16413426 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413342#comment-16413342 ] Reid Chan commented on HBASE-20095: --- Rebase master branch, and trigger QA again. > Redesign single

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-19 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405693#comment-16405693 ] Reid Chan commented on HBASE-20095: --- ping [~mdrob] > Redesign single instance pool in CleanerChore >

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-15 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401435#comment-16401435 ] Reid Chan commented on HBASE-20095: ---

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400853#comment-16400853 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-15 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400494#comment-16400494 ] Reid Chan commented on HBASE-20095: --- add {{@SuppressWarnings("FutureReturnValueIgnored")}}

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400294#comment-16400294 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399972#comment-16399972 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399879#comment-16399879 ] Reid Chan commented on HBASE-20095: --- Thanks Mike, you already did the rebase. Based on v12, v13 aims to

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399791#comment-16399791 ] Reid Chan commented on HBASE-20095: --- I just saw HBASE-20117 also updated few lines in HMaster.java,

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399644#comment-16399644 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399143#comment-16399143 ] Mike Drob commented on HBASE-20095: --- Had an issue applying it, posting what I ended up with. I think

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398245#comment-16398245 ] Reid Chan commented on HBASE-20095: --- Understand, i'm fine.:) There may be conflicts commits during this

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397481#comment-16397481 ] Mike Drob commented on HBASE-20095: --- Didn't get a chance to commit yesterday, probably sometime this

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395569#comment-16395569 ] Reid Chan commented on HBASE-20095: --- Thanks Mike, branch-2 only.

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395554#comment-16395554 ] Mike Drob commented on HBASE-20095: --- Thanks for pointing that out, didn't see it hidden in the

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395413#comment-16395413 ] Reid Chan commented on HBASE-20095: --- bq. Do we always wait the full timeout? Is there an interrupt

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395349#comment-16395349 ] Mike Drob commented on HBASE-20095: --- Do we always wait the full timeout? Is there an interrupt

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395003#comment-16395003 ] Reid Chan commented on HBASE-20095: --- ping [~mdrob], any concerns? > Redesign single instance pool in

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392716#comment-16392716 ] Hadoop QA commented on HBASE-20095: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-09 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392571#comment-16392571 ] Reid Chan commented on HBASE-20095: --- Rebase master branch. > Redesign single instance pool in

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392334#comment-16392334 ] Reid Chan commented on HBASE-20095: --- Unrelated UT. But am not sure about the hadoopcheck.., just

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391750#comment-16391750 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391337#comment-16391337 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391188#comment-16391188 ] Reid Chan commented on HBASE-20095: --- Checked the period between chore is 10 minutes for both

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389695#comment-16389695 ] Mike Drob commented on HBASE-20095: --- Yea, there is risk that we are overworking a solution here. Can

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-07 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389645#comment-16389645 ] Reid Chan commented on HBASE-20095: --- Same concern..., but considering only 2 cleaners {{LogCleaner}}

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389564#comment-16389564 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389552#comment-16389552 ] Mike Drob commented on HBASE-20095: --- Possible that we never update the pool? Tasks keep coming in so

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-07 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389391#comment-16389391 ] Reid Chan commented on HBASE-20095: --- v8 patch aims to fix findbugs and UTs. > Redesign single instance

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389383#comment-16389383 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-07 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389309#comment-16389309 ] Reid Chan commented on HBASE-20095: --- I'm afraid v6 has the same as v5, my mistake..., please review v7

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388682#comment-16388682 ] Mike Drob commented on HBASE-20095: --- v6 looks much cleaner, thanks for addressing my comments. Still

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388561#comment-16388561 ] Hadoop QA commented on HBASE-20095: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-06 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388170#comment-16388170 ] Reid Chan commented on HBASE-20095: --- You're right, thanks Mike! > Redesign single instance pool in

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-06 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388163#comment-16388163 ] Reid Chan commented on HBASE-20095: --- Got your point, let me see. > Redesign single instance pool in

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-06 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388155#comment-16388155 ] Reid Chan commented on HBASE-20095: --- The purpose of {{reconfig}} is to avoid updating pool while

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388151#comment-16388151 ] Mike Drob commented on HBASE-20095: --- {code} boolean canUpdateImmediately(Configuration conf) {

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-06 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388138#comment-16388138 ] Reid Chan commented on HBASE-20095: --- bq. the second one will return true second one will return false,

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388103#comment-16388103 ] Mike Drob commented on HBASE-20095: --- If there are two calls to canUpdateImmediately in a row while the

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386401#comment-16386401 ] Hadoop QA commented on HBASE-20095: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386143#comment-16386143 ] Reid Chan commented on HBASE-20095: --- v5 patch fixes {{LineLength}} checkstyle. And

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386059#comment-16386059 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385957#comment-16385957 ] Reid Chan commented on HBASE-20095: --- UTs passed on my machine. > Redesign single instance pool in

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385933#comment-16385933 ] Reid Chan commented on HBASE-20095: --- {quote} Does this method have to be public? {code} public static

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-02 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384137#comment-16384137 ] stack commented on HBASE-20095: --- bq. Only one updates the static pool. That makes sense [~reidchan].

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383620#comment-16383620 ] Hadoop QA commented on HBASE-20095: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-02 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383492#comment-16383492 ] Reid Chan commented on HBASE-20095: --- Remove unused import, and update justification. > Redesign single

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383392#comment-16383392 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-01 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383243#comment-16383243 ] Reid Chan commented on HBASE-20095: --- Only one updates the static pool. Because

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-01 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383226#comment-16383226 ] stack commented on HBASE-20095: --- [~reidchan] Hard part is what happens on config. change. All instances

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-01 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383128#comment-16383128 ] Reid Chan commented on HBASE-20095: --- bq. have static getPool(Configuration) method called from

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381852#comment-16381852 ] Hadoop QA commented on HBASE-20095: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-01 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381744#comment-16381744 ] Reid Chan commented on HBASE-20095: --- FYI:

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-03-01 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381697#comment-16381697 ] Mike Drob commented on HBASE-20095: --- bq. Chore's pool doesn't initialized, please call nit: grammar.

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

2018-02-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378011#comment-16378011 ] stack commented on HBASE-20095: --- Thanks you [~reidchan]. You are a gentleman. It might be tricky to do