[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430055#comment-16430055
]
Hudson commented on HBASE-20197:
Results for branch HBASE-19064
[build #90 on
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420651#comment-16420651
]
Hudson commented on HBASE-20197:
Results for branch branch-2
[build #549 on
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420572#comment-16420572
]
Ted Yu commented on HBASE-20197:
Beluga:
Thanks for the contribution.
In the future, please use
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420435#comment-16420435
]
Hudson commented on HBASE-20197:
Results for branch master
[build #278 on
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420222#comment-16420222
]
ramkrishna.s.vasudevan commented on HBASE-20197:
[~belugabehr]
Thanks for the patch.
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419533#comment-16419533
]
BELUGA BEHR commented on HBASE-20197:
-
[~anoop.hbase] [~yuzhih...@gmail.com] Please consider for
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404399#comment-16404399
]
ramkrishna.s.vasudevan commented on HBASE-20197:
the 8K or 4K change I don have an
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402210#comment-16402210
]
BELUGA BEHR commented on HBASE-20197:
-
For completeness sake...
{code}
Benchmark
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402068#comment-16402068
]
Hadoop QA commented on HBASE-20197:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401844#comment-16401844
]
Ted Yu commented on HBASE-20197:
Lgtm, pending QA
> Review of ByteBufferWriterOutputStream.java
>
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401624#comment-16401624
]
Ted Yu commented on HBASE-20197:
Patch v5 had a test failure.
Beluga:
Please check.
> Review of
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401523#comment-16401523
]
Anoop Sam John commented on HBASE-20197:
+1 for patch V5. Ping [~ram_krish],
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401156#comment-16401156
]
Hadoop QA commented on HBASE-20197:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401040#comment-16401040
]
BELUGA BEHR commented on HBASE-20197:
-
[~anoop.hbase] Thanks for the feedback. I made the change in
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400754#comment-16400754
]
Anoop Sam John commented on HBASE-20197:
Good analysis and find on the issue with Unsafe#copy..
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400739#comment-16400739
]
Hadoop QA commented on HBASE-20197:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400461#comment-16400461
]
BELUGA BEHR commented on HBASE-20197:
-
New patch...
# Hopefully fixed check-style error (my local
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400174#comment-16400174
]
Anoop Sam John commented on HBASE-20197:
bq.if (len > TEMP_BUF_LENGTH) {
Hmm that is bad..
We
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399500#comment-16399500
]
Ted Yu commented on HBASE-20197:
Can you address checkstyle warnings ?
Please also include trivial
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399449#comment-16399449
]
Hadoop QA commented on HBASE-20197:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399117#comment-16399117
]
Hadoop QA commented on HBASE-20197:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398992#comment-16398992
]
BELUGA BEHR commented on HBASE-20197:
-
[~mdrob] I couldn't explain it instruction, per instruction,
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398978#comment-16398978
]
BELUGA BEHR commented on HBASE-20197:
-
For me, the interesting mico-bench-marking shows a nice speed
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398930#comment-16398930
]
Mike Drob commented on HBASE-20197:
---
I don't understand why there is a difference between the small and
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398883#comment-16398883
]
BELUGA BEHR commented on HBASE-20197:
-
Randomized data... removed _rewind_
{code:java}
Benchmark Mode
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398832#comment-16398832
]
BELUGA BEHR commented on HBASE-20197:
-
Thanks [~mdrob] and [~yuzhih...@gmail.com] for the quick
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398828#comment-16398828
]
Hadoop QA commented on HBASE-20197:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398806#comment-16398806
]
Mike Drob commented on HBASE-20197:
---
Do you know if there's a JVM optimization about copying empty byte
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398780#comment-16398780
]
Ted Yu commented on HBASE-20197:
Interesting benchmark result.
{code}
@InterfaceAudience.Private
{code}
[
https://issues.apache.org/jira/browse/HBASE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398726#comment-16398726
]
BELUGA BEHR commented on HBASE-20197:
-
Bench-marking on my hardware shows:
{code:java}
# Run
30 matches
Mail list logo
