[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-12-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721158#comment-16721158 ] Hudson commented on HBASE-20404: Results for branch branch-1.3 [build #576 on

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-12-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720769#comment-16720769 ] Hudson commented on HBASE-20404: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #509 (See

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443136#comment-16443136 ] Hudson commented on HBASE-20404: Results for branch branch-1.4 [build #293 on

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442426#comment-16442426 ] Hudson commented on HBASE-20404: Results for branch master [build #303 on

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442158#comment-16442158 ] Hudson commented on HBASE-20404: Results for branch branch-1 [build #287 on

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441653#comment-16441653 ] Hudson commented on HBASE-20404: Results for branch branch-2.0 [build #189 on

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441105#comment-16441105 ] Mike Drob commented on HBASE-20404: --- +1 on v2, would very much like to see this in branch-2.0 as well

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-15 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438757#comment-16438757 ] Reid Chan commented on HBASE-20404: --- v2 is much clear, lgtm. > Ugly cleanerchore complaint that dir is

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438274#comment-16438274 ] Reid Chan commented on HBASE-20404: --- I prefer before checking, but i'm afraid it still chatty..   >

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-14 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438247#comment-16438247 ] Sean Busbey commented on HBASE-20404: - as I mentioned above, I don't think we can remove logging in

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438244#comment-16438244 ] Reid Chan commented on HBASE-20404: --- Remove is better since it is chatty... > Ugly cleanerchore

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438242#comment-16438242 ] Reid Chan commented on HBASE-20404: --- I can answer this question, because i wrote this. It's normal

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437866#comment-16437866 ] Andrew Purtell commented on HBASE-20404: Seeing this in the branch-1 backport too, was just going

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437810#comment-16437810 ] stack commented on HBASE-20404: --- If you do top-10 DEBUG I'll keep an eye on it and make a new issue w/

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437808#comment-16437808 ] Sean Busbey commented on HBASE-20404: - okay, maybe I should add more log information so we have a

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437616#comment-16437616 ] stack commented on HBASE-20404: --- bq. We end up in that block if we hit literally any kind of IOException. I

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437542#comment-16437542 ] Sean Busbey commented on HBASE-20404: - {quote}Patch looks good. Do we have to print the exception at

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437535#comment-16437535 ] Hadoop QA commented on HBASE-20404: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437516#comment-16437516 ] stack commented on HBASE-20404: --- Patch looks good. Do we have to print the exception at all, even at DEBUG?

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437246#comment-16437246 ] Sean Busbey commented on HBASE-20404: - -v1   - fix checkstyle complaint. > Ugly cleanerchore

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437097#comment-16437097 ] Hadoop QA commented on HBASE-20404: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436914#comment-16436914 ] Reid Chan commented on HBASE-20404: --- LGTM > Ugly cleanerchore complaint that dir is not empty >

[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436606#comment-16436606 ] Reid Chan commented on HBASE-20404: --- bq. Are they exceptions. Are they 'problems'? Both, no. bq. I as