[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-03 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462434#comment-16462434 ] Zheng Hu commented on HBASE-20481: -- Patch.v3: 1. Address Duo's above comment, but stil

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462350#comment-16462350 ] Hadoop QA commented on HBASE-20481: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-03 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462284#comment-16462284 ] Zheng Hu commented on HBASE-20481: -- OK , will update the patch to address the comment.

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462223#comment-16462223 ] Duo Zhang commented on HBASE-20481: --- OK, see the code. BTW, you can implement a method

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-03 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462195#comment-16462195 ] Zheng Hu commented on HBASE-20481: -- bq. And for serial replication, we will not consider

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462163#comment-16462163 ] Duo Zhang commented on HBASE-20481: --- And for serial replication, we will not consider t

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462159#comment-16462159 ] Duo Zhang commented on HBASE-20481: --- For the filterBatches method, if you want to use l

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-03 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462152#comment-16462152 ] Zheng Hu commented on HBASE-20481: -- Patch.v2: remove the setSerial method and replicate

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-02 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461860#comment-16461860 ] Zheng Hu commented on HBASE-20481: -- bq. so the current API is enough to tell the Replica

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1646#comment-1646 ] Hadoop QA commented on HBASE-20481: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-05-02 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460966#comment-16460966 ] Duo Zhang commented on HBASE-20481: --- Sorry, just notice that when calling ReplicationEn

[jira] [Commented] (HBASE-20481) Add a setSerial method to ReplicationEndpoint

2018-04-24 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449797#comment-16449797 ] Zheng Hu commented on HBASE-20481: -- Let me fix this. > Add a setSerial method to Repli