[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761377#comment-16761377 ] Hudson commented on HBASE-20485: Results for branch branch-2.0 [build #1322 on

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469111#comment-16469111 ] Hudson commented on HBASE-20485: Results for branch branch-2 [build #714 on

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468770#comment-16468770 ] Hudson commented on HBASE-20485: Results for branch master [build #325 on

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468562#comment-16468562 ] Chia-Ping Tsai commented on HBASE-20485: The failure should bot unrelated to the patch. Also loop

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464874#comment-16464874 ] Hadoop QA commented on HBASE-20485: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464814#comment-16464814 ] Nihal Jain commented on HBASE-20485: Sure. Attaching a new patch in a moment. > Copy constructor of

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464809#comment-16464809 ] Chia-Ping Tsai commented on HBASE-20485: The patch LGTM but it would be better to have tests of

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464805#comment-16464805 ] Nihal Jain commented on HBASE-20485: Gentle ping [~chia7712]. > Copy constructor of Scan doesn't

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456160#comment-16456160 ] Hadoop QA commented on HBASE-20485: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456111#comment-16456111 ] Nihal Jain commented on HBASE-20485: Fixed check-style issue. Please review. > Copy constructor of

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453350#comment-16453350 ] Hadoop QA commented on HBASE-20485: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453077#comment-16453077 ] Hadoop QA commented on HBASE-20485: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452516#comment-16452516 ] Anoop Sam John commented on HBASE-20485: Nice.. I too thought of having a reflection based UT

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452097#comment-16452097 ] Ashish Singhi commented on HBASE-20485: --- Good finding, [~nihaljain.cs]!! > Copy constructor of

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452093#comment-16452093 ] Nihal Jain commented on HBASE-20485: [~chia7712] Seems like we already have an API for this in 

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452083#comment-16452083 ] Mike Drob commented on HBASE-20485: --- Is reflection going to be slow? > Copy constructor of Scan

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451987#comment-16451987 ] Ashish Singhi commented on HBASE-20485: --- I think by some means if we can check the size of actual

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451985#comment-16451985 ] Chia-Ping Tsai commented on HBASE-20485: {quote}I think we can use reflection for a generic

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451974#comment-16451974 ] Nihal Jain commented on HBASE-20485: I think we can use reflection for a generic solution. Something

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451956#comment-16451956 ] Ashish Singhi commented on HBASE-20485: ---  Just thinking, is there any way to avoid such mistakes in

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451870#comment-16451870 ] Nihal Jain commented on HBASE-20485: Sure [~chia7712]. I will attach a new patch with the

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451839#comment-16451839 ] Chia-Ping Tsai commented on HBASE-20485: Nice testing! nit: Could we avoid use the deprecated

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451817#comment-16451817 ] Hadoop QA commented on HBASE-20485: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451739#comment-16451739 ] Nihal Jain commented on HBASE-20485: Hi I have attached a patch which sets readType and replicaId for

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451711#comment-16451711 ] Chia-Ping Tsai commented on HBASE-20485: {quote}Okay should we fix setting of replicaId for scan

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451704#comment-16451704 ] Nihal Jain commented on HBASE-20485: Okay should we fix setting of replicaId for scan (get/scan)

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451703#comment-16451703 ] Chia-Ping Tsai commented on HBASE-20485: {quote}I was writing some UT and found that copy

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451693#comment-16451693 ] Nihal Jain commented on HBASE-20485: Hi, I was writing some UT and found that copy constructor does

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType

[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451601#comment-16451601 ] Anoop Sam John commented on HBASE-20485: We should add a UT in testScan to make sure all fields