[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2019-02-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761377#comment-16761377 ] Hudson commented on HBASE-20485: Results for branch branch-2.0 [build #1322 on

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-05-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469111#comment-16469111 ] Hudson commented on HBASE-20485: Results for branch branch-2 [build #714 on buil

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-05-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468770#comment-16468770 ] Hudson commented on HBASE-20485: Results for branch master [build #325 on builds

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-05-09 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468562#comment-16468562 ] Chia-Ping Tsai commented on HBASE-20485: The failure should bot unrelated to the

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-05-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464874#comment-16464874 ] Hadoop QA commented on HBASE-20485: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-05-05 Thread Nihal Jain (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464814#comment-16464814 ] Nihal Jain commented on HBASE-20485: Sure. Attaching a new patch in a moment. > Copy

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-05-05 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464809#comment-16464809 ] Chia-Ping Tsai commented on HBASE-20485: The patch LGTM but it would be better to

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-05-05 Thread Nihal Jain (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464805#comment-16464805 ] Nihal Jain commented on HBASE-20485: Gentle ping [~chia7712]. > Copy constructor of

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456160#comment-16456160 ] Hadoop QA commented on HBASE-20485: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-27 Thread Nihal Jain (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456111#comment-16456111 ] Nihal Jain commented on HBASE-20485: Fixed check-style issue. Please review. > Copy

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453350#comment-16453350 ] Hadoop QA commented on HBASE-20485: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453077#comment-16453077 ] Hadoop QA commented on HBASE-20485: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452516#comment-16452516 ] Anoop Sam John commented on HBASE-20485: Nice.. I too thought of having a reflec

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452097#comment-16452097 ] Ashish Singhi commented on HBASE-20485: --- Good finding, [~nihaljain.cs]!! > Copy co

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Nihal Jain (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452093#comment-16452093 ] Nihal Jain commented on HBASE-20485: [~chia7712] Seems like we already have an API fo

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452083#comment-16452083 ] Mike Drob commented on HBASE-20485: --- Is reflection going to be slow? > Copy constructo

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451987#comment-16451987 ] Ashish Singhi commented on HBASE-20485: --- I think by some means if we can check the

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451985#comment-16451985 ] Chia-Ping Tsai commented on HBASE-20485: {quote}I think we can use reflection for

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Nihal Jain (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451974#comment-16451974 ] Nihal Jain commented on HBASE-20485: I think we can use reflection for a generic solu

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451956#comment-16451956 ] Ashish Singhi commented on HBASE-20485: ---  Just thinking, is there any way to avoid

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Nihal Jain (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451870#comment-16451870 ] Nihal Jain commented on HBASE-20485: Sure [~chia7712]. I will attach a new patch with

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451839#comment-16451839 ] Chia-Ping Tsai commented on HBASE-20485: Nice testing! nit: Could we avoid use th

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451817#comment-16451817 ] Hadoop QA commented on HBASE-20485: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId

2018-04-24 Thread Nihal Jain (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451739#comment-16451739 ] Nihal Jain commented on HBASE-20485: Hi I have attached a patch which sets readType a