[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501796#comment-16501796 ] Hudson commented on HBASE-20634: Results for branch master [build #356 on build

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501270#comment-16501270 ] Hudson commented on HBASE-20634: Results for branch branch-2 [build #824 on bui

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501226#comment-16501226 ] Duo Zhang commented on HBASE-20634: --- Will dig more this week. Need to finish some high

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501218#comment-16501218 ] stack commented on HBASE-20634: --- bq. stack Have you seen my last comments on rb? I did, j

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501133#comment-16501133 ] Duo Zhang commented on HBASE-20634: --- And I still think there are problems, though it i

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501077#comment-16501077 ] Duo Zhang commented on HBASE-20634: --- [~stack] Have you seen my last comments on rb? A

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500967#comment-16500967 ] Hudson commented on HBASE-20634: Results for branch branch-2.0 [build #388 on b

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500768#comment-16500768 ] Hudson commented on HBASE-20634: Results for branch branch-2 [build #823 on bui

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500758#comment-16500758 ] stack commented on HBASE-20634: --- Sorry about that. Here is addendum that I pushed: {code}

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500482#comment-16500482 ] Josh Elser commented on HBASE-20634: Great work, all!! I need to take the time to ch

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499846#comment-16499846 ] Hadoop QA commented on HBASE-20634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499840#comment-16499840 ] Hadoop QA commented on HBASE-20634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-03 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499736#comment-16499736 ] stack commented on HBASE-20634: --- .009 fixes unit test and addresses review comments by [~A

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498782#comment-16498782 ] Hadoop QA commented on HBASE-20634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-01 Thread Umesh Agashe (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498698#comment-16498698 ] Umesh Agashe commented on HBASE-20634: -- +1 lgtm > Reopen region while server crash

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-01 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498692#comment-16498692 ] stack commented on HBASE-20634: --- .007 addresses nice review by [~uagashe] > Reopen region

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-01 Thread Umesh Agashe (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498618#comment-16498618 ] Umesh Agashe commented on HBASE-20634: -- [~stack], I have posted comments on RB for

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498549#comment-16498549 ] Hadoop QA commented on HBASE-20634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498537#comment-16498537 ] Hadoop QA commented on HBASE-20634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-06-01 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498298#comment-16498298 ] stack commented on HBASE-20634: --- Retry patch 006; failed git checkout on precommit. > Reo

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497361#comment-16497361 ] Hadoop QA commented on HBASE-20634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-31 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497196#comment-16497196 ] stack commented on HBASE-20634: --- .005 Fix unit test. > Reopen region while server crash c

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497155#comment-16497155 ] Hadoop QA commented on HBASE-20634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497049#comment-16497049 ] Hadoop QA commented on HBASE-20634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-31 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496793#comment-16496793 ] stack commented on HBASE-20634: --- .003 fixes checkstyle and findbugs. Review please. Shout

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-31 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496740#comment-16496740 ] stack commented on HBASE-20634: --- bq. Add a SERVER_CRASH_HANDLE_RIT2 state can not solve th

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496235#comment-16496235 ] Hadoop QA commented on HBASE-20634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-30 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496072#comment-16496072 ] stack commented on HBASE-20634: --- On reexamination, HBASE-20173 IS this issue. The fix ther

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-30 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495872#comment-16495872 ] stack commented on HBASE-20634: --- HBASE-20173 is a version of this issue; it fixed 90% of c

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-29 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494524#comment-16494524 ] Duo Zhang commented on HBASE-20634: --- Add a SERVER_CRASH_HANDLE_RIT2 state can not solv

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-29 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494378#comment-16494378 ] stack commented on HBASE-20634: --- This is a good one. We've seen it before. In SCP we have

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492853#comment-16492853 ] stack commented on HBASE-20634: --- Great unit test. Assigned myself. This is a good one. Let

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-27 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492014#comment-16492014 ] Duo Zhang commented on HBASE-20634: --- PTAL sir [~stack]. I think this is a critical one

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-27 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492013#comment-16492013 ] Duo Zhang commented on HBASE-20634: --- I used a dummy procedure to hold the lock of the r

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490674#comment-16490674 ] Duo Zhang commented on HBASE-20634: --- Let me see if I can write a UT to reproduce it. >

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488715#comment-16488715 ] Duo Zhang commented on HBASE-20634: --- Oh, MoveRegionProcedure is not RITProcedure, so it

[jira] [Commented] (HBASE-20634) Reopen region while server crash can cause the procedure to be stuck

2018-05-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488688#comment-16488688 ] Duo Zhang commented on HBASE-20634: --- Ping [~stack]. > Reopen region while server crash