[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594362#comment-16594362
]
Mingliang Liu commented on HBASE-20642:
---
Thanks [~an...@apache.org]. After discussion with
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594353#comment-16594353
]
Ankit Singhal commented on HBASE-20642:
---
bq. Does it make sense to branch-1 as well? Thanks.
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594269#comment-16594269
]
Josh Elser commented on HBASE-20642:
{quote}Does it make sense to branch-1 as well? Thanks.
{quote}
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592168#comment-16592168
]
Mingliang Liu commented on HBASE-20642:
---
Does it make sense to branch-1 as well? Thanks.
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519350#comment-16519350
]
Hudson commented on HBASE-20642:
Results for branch branch-2.0
[build #453 on
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518938#comment-16518938
]
Hudson commented on HBASE-20642:
Results for branch branch-2
[build #886 on
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518855#comment-16518855
]
stack commented on HBASE-20642:
---
+1 for 2.0.2
> IntegrationTestDDLMasterFailover throws
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518852#comment-16518852
]
Hudson commented on HBASE-20642:
Results for branch master
[build #371 on
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518646#comment-16518646
]
Josh Elser commented on HBASE-20642:
[~stack], just to make sure: you'd like this for branch-2.0?
>
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518635#comment-16518635
]
Josh Elser commented on HBASE-20642:
+1 from me too.
Let me help by merging. Thanks for helping in
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517917#comment-16517917
]
Hadoop QA commented on HBASE-20642:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517820#comment-16517820
]
stack commented on HBASE-20642:
---
Skimmed. +1
> IntegrationTestDDLMasterFailover throws
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517810#comment-16517810
]
Ankit Singhal commented on HBASE-20642:
---
Thanks [~stack] and [~elserj] for all the help in getting
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517787#comment-16517787
]
Josh Elser commented on HBASE-20642:
{quote}Doing nonce creation outside the call method is what
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516676#comment-16516676
]
stack commented on HBASE-20642:
---
Doing nonce creation outside the call method is what makes it so we don't
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516281#comment-16516281
]
Hadoop QA commented on HBASE-20642:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516023#comment-16516023
]
Ankit Singhal commented on HBASE-20642:
---
[~stack],[~elserj], [~mdrob] , attaching a patch for your
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508792#comment-16508792
]
Josh Elser commented on HBASE-20642:
{quote}if we fix HBASE-20658 by releasing the latch after some
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497129#comment-16497129
]
stack commented on HBASE-20642:
---
bq. Thanks stack, What do you say for HBASE-20658?
Seems like latch is
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497023#comment-16497023
]
Ankit Singhal commented on HBASE-20642:
---
{quote} This is a general problem with the synchronous
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495357#comment-16495357
]
stack commented on HBASE-20642:
---
Re-reading the description, how would ensuring nonce-respect help? We'll
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495259#comment-16495259
]
stack commented on HBASE-20642:
---
bq. we are already rebuilding in-memory nonce map from the persisted
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494416#comment-16494416
]
Ankit Singhal commented on HBASE-20642:
---
bq. That is not my understanding. The nonces are in an
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491404#comment-16491404
]
stack commented on HBASE-20642:
---
bq. If the master is swapped, nonces map will be rebuilt from uncompleted
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491398#comment-16491398
]
Ankit Singhal commented on HBASE-20642:
---
bq.On their first submission, they get this? I don't
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491374#comment-16491374
]
stack commented on HBASE-20642:
---
bq. , it's just user will get InvalidFamilyOperationException even for
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491348#comment-16491348
]
Ankit Singhal commented on HBASE-20642:
---
bq. The procedure was submitted, right, and started to
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491340#comment-16491340
]
stack commented on HBASE-20642:
---
bq. so as the call is not completed,
The procedure was submitted,
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491337#comment-16491337
]
Ankit Singhal commented on HBASE-20642:
---
Thanks [~mdrob] for taking a look.
bq. I think the fix is
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491329#comment-16491329
]
Ankit Singhal commented on HBASE-20642:
---
bq. I don't see what is wrong. You are trying to modify a
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491313#comment-16491313
]
stack commented on HBASE-20642:
---
I don't see what is wrong. You are trying to modify a table adding a
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491192#comment-16491192
]
Mike Drob commented on HBASE-20642:
---
I think the fix is correct, but I also think we need a unit test
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491181#comment-16491181
]
Josh Elser commented on HBASE-20642:
Given my understanding, I'd say +1
[~stack], [~uagashe],
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489891#comment-16489891
]
Hadoop QA commented on HBASE-20642:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489628#comment-16489628
]
Josh Elser commented on HBASE-20642:
Also, the fix makes sense to me (and reminds me of the last time
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489609#comment-16489609
]
Josh Elser commented on HBASE-20642:
[~stack] ^
> IntegrationTestDDLMasterFailover throws
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489510#comment-16489510
]
Ankit Singhal commented on HBASE-20642:
---
@stack,[~elserj], [~tedyu], can you please review the
[
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489498#comment-16489498
]
Ankit Singhal commented on HBASE-20642:
---
I was analyzing the logs provided:-
Client tried to add
38 matches
Mail list logo
