[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521857#comment-16521857
]
huaxiang sun commented on HBASE-20710:
--
Thanks [~stack] for committing the change.
> extra
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521601#comment-16521601
]
Hudson commented on HBASE-20710:
Results for branch master
[build #375 on
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521475#comment-16521475
]
Hudson commented on HBASE-20710:
Results for branch branch-2.0
[build #466 on
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521473#comment-16521473
]
Hudson commented on HBASE-20710:
Results for branch branch-2
[build #900 on
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521367#comment-16521367
]
stack commented on HBASE-20710:
---
Pushed a checkstyle addendum to branch-2.0+
commit
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521353#comment-16521353
]
stack commented on HBASE-20710:
---
I tried the patch. Here is before... [^2.0621.2.12782.alloc.svg] and
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521351#comment-16521351
]
Hadoop QA commented on HBASE-20710:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521340#comment-16521340
]
stack commented on HBASE-20710:
---
Bit confusing but .001 is rebase (its [~huaxiang]'s .002 fixed so works
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521253#comment-16521253
]
stack commented on HBASE-20710:
---
+1
And +1 for branch-2.0.
Why tests fail?
Thanks [~huaxiang]
> extra
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519595#comment-16519595
]
Hadoop QA commented on HBASE-20710:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519592#comment-16519592
]
huaxiang sun commented on HBASE-20710:
--
reattach the patch as there is no test run against it.
>
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513182#comment-16513182
]
huaxiang sun commented on HBASE-20710:
--
Yeah, for the table.put path, we can save copyFamily as it
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512712#comment-16512712
]
Anoop Sam John commented on HBASE-20710:
I see.. In IndividualBytesFieldCell we dont copy family
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512575#comment-16512575
]
huaxiang sun commented on HBASE-20710:
--
Thanks [~anoop.hbase]. Checking at the following line of
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512241#comment-16512241
]
Anoop Sam John commented on HBASE-20710:
bq. if (cell instanceof IndividualBytesFieldCell) {
Why
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511458#comment-16511458
]
huaxiang sun commented on HBASE-20710:
--
I put a v2 which just adds an optimization for
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510064#comment-16510064
]
huaxiang sun commented on HBASE-20710:
--
If this is the case, I will upload a new patch which is a
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509990#comment-16509990
]
stack commented on HBASE-20710:
---
bq. Call this out in the doc that the caller needs to make sure the input
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509959#comment-16509959
]
huaxiang sun commented on HBASE-20710:
--
Thanks Stack and now I got [~chia7712]'s point. Do the
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509937#comment-16509937
]
huaxiang sun commented on HBASE-20710:
--
Thanks [~mdrob] for review, will address the comments. The
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509918#comment-16509918
]
stack commented on HBASE-20710:
---
Could the Cell family be different from the family passed in as an arg?
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509902#comment-16509902
]
Mike Drob commented on HBASE-20710:
---
Can you add javadoc for {{copyFamilyTo}}?
I'm having trouble
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509307#comment-16509307
]
Hadoop QA commented on HBASE-20710:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509286#comment-16509286
]
Chia-Ping Tsai commented on HBASE-20710:
{quote}Family can be different from Cell's family if
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509281#comment-16509281
]
huaxiang sun commented on HBASE-20710:
--
Thanks Chia-Ping. Family can be different from Cell's
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509280#comment-16509280
]
Chia-Ping Tsai commented on HBASE-20710:
Should we check that the family is same with the cell's
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509279#comment-16509279
]
Chia-Ping Tsai commented on HBASE-20710:
{code:java}
+// TODO: It is fraught with risk if
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507053#comment-16507053
]
stack commented on HBASE-20710:
---
@hsun do as you see best. Above was just confirmation that another sees
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507046#comment-16507046
]
huaxiang sun commented on HBASE-20710:
--
Thanks Stack. For the case of MutationProto (not cell
[
https://issues.apache.org/jira/browse/HBASE-20710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507030#comment-16507030
]
stack commented on HBASE-20710:
---
+1
I had this as a 'fix' in branch:
diff --git
30 matches
Mail list logo
