[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540764#comment-16540764
]
Sean Busbey commented on HBASE-20838:
-
+1
> Move all setStorage related UT cases from TestFSUtils
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540102#comment-16540102
]
Sean Busbey commented on HBASE-20838:
-
change looks good. let me test it out locally here. we'll
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539642#comment-16539642
]
Hadoop QA commented on HBASE-20838:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539477#comment-16539477
]
Hadoop QA commented on HBASE-20838:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539476#comment-16539476
]
Yu Li commented on HBASE-20838:
---
Patch v2 fixes shellcheck and checks whether root is included in
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539248#comment-16539248
]
Hadoop QA commented on HBASE-20838:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538669#comment-16538669
]
Sean Busbey commented on HBASE-20838:
-
{quote}
+1 unit202m 31sroot in the patch
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538575#comment-16538575
]
Hadoop QA commented on HBASE-20838:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538566#comment-16538566
]
Yu Li commented on HBASE-20838:
---
Thanks for the notes on local test [~busbey], will try it later.
>From
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538485#comment-16538485
]
Sean Busbey commented on HBASE-20838:
-
sure testing locally works as does attaching a patch here
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538352#comment-16538352
]
Hadoop QA commented on HBASE-20838:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537956#comment-16537956
]
Hadoop QA commented on HBASE-20838:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537939#comment-16537939
]
Yu Li commented on HBASE-20838:
---
btw, I've tested the shell lines locally and could assure the
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537937#comment-16537937
]
Yu Li commented on HBASE-20838:
---
Thanks for the instructions [~busbey]. I've uploaded a "semantically
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537053#comment-16537053
]
Sean Busbey commented on HBASE-20838:
-
the file that needs to change is at
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536513#comment-16536513
]
Yu Li commented on HBASE-20838:
---
bq. Let me know if you want help on figuring out the precommit changes to
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534795#comment-16534795
]
Sean Busbey commented on HBASE-20838:
-
Let me know if you want help on figuring out the precommit
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534786#comment-16534786
]
Sean Busbey commented on HBASE-20838:
-
we should also have a note in CommonFSUtils that its
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534506#comment-16534506
]
Yu Li commented on HBASE-20838:
---
bq. I presume there's a reason we can't move the setStoragePolicy stuff
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533632#comment-16533632
]
Sean Busbey commented on HBASE-20838:
-
definitely would not like to add an HDFS dependency on
[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533457#comment-16533457
]
Yu Li commented on HBASE-20838:
---
When trying to implement this, I find {{TestCommonFSUtils}} is in the
21 matches
Mail list logo
