[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532930#comment-16532930 ] Ted Yu commented on HBASE-20846: Please add license to TestSharedTableLockAfterRestartMa

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532979#comment-16532979 ] Hadoop QA commented on HBASE-20846: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532990#comment-16532990 ] Hadoop QA commented on HBASE-20846: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533158#comment-16533158 ] Duo Zhang commented on HBASE-20846: --- I do not think we go to the correct direction...

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533165#comment-16533165 ] Allan Yang commented on HBASE-20846: {quote} I do not think we go to the correct di

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533167#comment-16533167 ] Duo Zhang commented on HBASE-20846: --- Then this is what we need to fix. FWIW, your fix

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533174#comment-16533174 ] Allan Yang commented on HBASE-20846: {quote} Then this is what we need to fix. FWIW,

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533187#comment-16533187 ] Duo Zhang commented on HBASE-20846: --- To speak more clearly, as you said, always acquir

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533193#comment-16533193 ] Duo Zhang commented on HBASE-20846: --- Anyway, what I want to say is, if you want to cha

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533194#comment-16533194 ] Allan Yang commented on HBASE-20846: {quote}  as a shared lock should be reentrant,

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533197#comment-16533197 ] Duo Zhang commented on HBASE-20846: --- [~allan163] Do not need to start working immediat

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-04 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533204#comment-16533204 ] Allan Yang commented on HBASE-20846: Sure, the root cause here is that AMv2 don't re

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-09 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537085#comment-16537085 ] stack commented on HBASE-20846: --- What I appreciate about this patch is that it removes the

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540097#comment-16540097 ] Duo Zhang commented on HBASE-20846: --- I'm reading the code of WALProcedureStore... It i

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540152#comment-16540152 ] Duo Zhang commented on HBASE-20846: --- What I want to do is that, add a field called 'lo

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540528#comment-16540528 ] stack commented on HBASE-20846: --- Updating procedure store is expensive...takes time. Do w

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540955#comment-16540955 ] Duo Zhang commented on HBASE-20846: --- {quote} Do we need a new boolean? What cases do w

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540992#comment-16540992 ] stack commented on HBASE-20846: --- bq. We have already done one step, and we expect that no

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541048#comment-16541048 ] Duo Zhang commented on HBASE-20846: --- Anyway let me provide a patch first. The optimiza

[jira] [Commented] (HBASE-20846) Table's shared lock is not held by sub-procedures after master restart

2018-07-12 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541364#comment-16541364 ] Duo Zhang commented on HBASE-20846: --- OK, found another problem. I want to call acquire