[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742420#comment-16742420 ] Lars Hofhansl commented on HBASE-20928: --- In a microbenchmark I actually found that >>> is slightly

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741823#comment-16741823 ] Lars Hofhansl commented on HBASE-20928: --- Hey [~bashrc-real], I'm not saying that this is causing

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741808#comment-16741808 ] saurabh singh commented on HBASE-20928: --- description. I can investigate the perf impact of this

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741782#comment-16741782 ] Lars Hofhansl commented on HBASE-20928: --- The cited article _explicitly_ states that {{int mid =

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741001#comment-16741001 ] Hudson commented on HBASE-20928: Results for branch branch-1 [build #629 on

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558357#comment-16558357 ] Hudson commented on HBASE-20928: Results for branch master [build #409 on

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556410#comment-16556410 ] Hudson commented on HBASE-20928: Results for branch branch-2 [build #1026 on

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555614#comment-16555614 ] Hudson commented on HBASE-20928: Results for branch master [build #408 on

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555143#comment-16555143 ] saurabh singh commented on HBASE-20928: --- [~xucang] Thanks. Checked the patch. Looks good. >

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554755#comment-16554755 ] Hudson commented on HBASE-20928: Results for branch branch-2 [build #1022 on

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554658#comment-16554658 ] Xu Cang commented on HBASE-20928: - I found one more place with this issue. Uploaded an addendum patch.

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554362#comment-16554362 ] Hadoop QA commented on HBASE-20928: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554239#comment-16554239 ] Ted Yu commented on HBASE-20928: Test failure was unrelated. lgtm > Rewrite calculation of midpoint in

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554057#comment-16554057 ] saurabh singh commented on HBASE-20928: --- The test failure looks unrelated to this change.

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554013#comment-16554013 ] Hadoop QA commented on HBASE-20928: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553968#comment-16553968 ] Ted Yu commented on HBASE-20928: On https://builds.apache.org/job/PreCommit-HBASE-Build, you can see two

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553959#comment-16553959 ] saurabh singh commented on HBASE-20928: --- [~yuzhih...@gmail.com] How do I retrigger the validation

[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

[ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553952#comment-16553952 ] Ted Yu commented on HBASE-20928: Please checkout new javac warnings. > Rewrite calculation of midpoint