[
https://issues.apache.org/jira/browse/HBASE-20935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564465#comment-16564465
]
Andrew Purtell commented on HBASE-20935:
Ran out of time yesterday, looking at this now
>
[
https://issues.apache.org/jira/browse/HBASE-20935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562401#comment-16562401
]
Andrew Purtell commented on HBASE-20935:
This looks ready to go. Committing today where
[
https://issues.apache.org/jira/browse/HBASE-20935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16557993#comment-16557993
]
Hadoop QA commented on HBASE-20935:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556886#comment-16556886
]
Ted Yu commented on HBASE-20935:
+1
> HStore.removeCompactedfiles should log incase it unable to delete
[
https://issues.apache.org/jira/browse/HBASE-20935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556884#comment-16556884
]
Vishal Khandelwal commented on HBASE-20935:
---
Thanks [~yuzhih...@gmail.com] for review. I have
[
https://issues.apache.org/jira/browse/HBASE-20935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1693#comment-1693
]
Ted Yu commented on HBASE-20935:
lgtm
nit:
{code}
2608 }
2609 else {
{code}
[
https://issues.apache.org/jira/browse/HBASE-20935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555412#comment-16555412
]
Hadoop QA commented on HBASE-20935:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555156#comment-16555156
]
Hadoop QA commented on HBASE-20935:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555126#comment-16555126
]
Vishal Khandelwal commented on HBASE-20935:
---
Will submit the patch for log line change
>