[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603382#comment-16603382 ] Xu Cang commented on HBASE-21150: - Small question, why using  {code:java} synchronized (

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603403#comment-16603403 ] Ted Yu commented on HBASE-21150: ConcurrentHashMap doesn't give us benefit in this case:

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603470#comment-16603470 ] Xu Cang commented on HBASE-21150: - I think we rely on ConcurrentHashMap's "computeIfAbse

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603486#comment-16603486 ] Hadoop QA commented on HBASE-21150: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603490#comment-16603490 ] Ted Yu commented on HBASE-21150: computeIfAbsent is not needed. See how my patch achieve

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603501#comment-16603501 ] Andrew Purtell commented on HBASE-21150: FYI I'm committing an addendum to the c

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603505#comment-16603505 ] Xu Cang commented on HBASE-21150: - Now I see. Thanks. [~yuzhih...@gmail.com] +1. > Avoi

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603509#comment-16603509 ] Xu Cang commented on HBASE-21150: - [~apurtell] this Jira https://issues.apache.org/jira/

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603523#comment-16603523 ] Andrew Purtell commented on HBASE-21150: Oops, ok missed that and the considerat

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603584#comment-16603584 ] Xu Cang commented on HBASE-21150: - [~apurtell] Actually, Ted's fix in this Jira removed

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603714#comment-16603714 ] Duo Zhang commented on HBASE-21150: --- Please do not commit yet. There are obvious concu

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603756#comment-16603756 ] Xu Cang commented on HBASE-21150: - I put a patch for branch-1 here: https://issues.apac

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603769#comment-16603769 ] Duo Zhang commented on HBASE-21150: --- First, please use ConcurrentMap instead of Map Me

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603772#comment-16603772 ] Duo Zhang commented on HBASE-21150: --- Oh you will still do registration when getting, t

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603782#comment-16603782 ] Ted Yu commented on HBASE-21150: bq. you use a thread pool to execute the registration

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603783#comment-16603783 ] Andrew Purtell commented on HBASE-21150: Yes, my apologies for picking back the

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603784#comment-16603784 ] Hadoop QA commented on HBASE-21150: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603790#comment-16603790 ] Ted Yu commented on HBASE-21150: TestReplicationKillSlaveRSWithSeparateOldWALs passed lo

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603791#comment-16603791 ] Duo Zhang commented on HBASE-21150: --- What’s your point Ted? What is the delay? How lon

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603812#comment-16603812 ] Duo Zhang commented on HBASE-21150: --- OK I see the description. Then here the patch wil

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603852#comment-16603852 ] Duo Zhang commented on HBASE-21150: --- Please stop changing the issue type [~yuzhih...@g

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603862#comment-16603862 ] Hadoop QA commented on HBASE-21150: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604021#comment-16604021 ] Hadoop QA commented on HBASE-21150: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604100#comment-16604100 ] Ted Yu commented on HBASE-21150: >From >https://builds.apache.org/job/PreCommit-HBASE-B

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604116#comment-16604116 ] Ted Yu commented on HBASE-21150: I ran TestFromClientSide locally 3 times, TestFromClien

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604182#comment-16604182 ] Duo Zhang commented on HBASE-21150: --- What is the difference between the old getOrCreat

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604339#comment-16604339 ] Ted Yu commented on HBASE-21150: MetricsTableAggregateSource is marked Private. Adding t

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604347#comment-16604347 ] Duo Zhang commented on HBASE-21150: --- Anyway, why do you call a containsKey in register

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604373#comment-16604373 ] Ted Yu commented on HBASE-21150: In patch v5, I dropped the register() method from Metri

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604383#comment-16604383 ] Duo Zhang commented on HBASE-21150: --- {code} executorForMetrics.submit(new Callable() {

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604395#comment-16604395 ] Ted Yu commented on HBASE-21150: Looking at the javadoc for {{execute}}: {code} * E

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604401#comment-16604401 ] Duo Zhang commented on HBASE-21150: --- The submit method has the same problem. > Avoid

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604409#comment-16604409 ] Ted Yu commented on HBASE-21150: I read the javadoc for {{submit}}: {code} * Submit

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604426#comment-16604426 ] Duo Zhang commented on HBASE-21150: --- OK, I give up. You can write anything you want, a

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604443#comment-16604443 ] Ted Yu commented on HBASE-21150: bq. do not like the ugly code. Can you tell me which p

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604458#comment-16604458 ] Hadoop QA commented on HBASE-21150: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604614#comment-16604614 ] Hadoop QA commented on HBASE-21150: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604622#comment-16604622 ] stack commented on HBASE-21150: --- Where is the evidence that this is a problem? Is it just

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604628#comment-16604628 ] Ted Yu commented on HBASE-21150: bq. Where is evidence that the patch makes improvement?

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604665#comment-16604665 ] stack commented on HBASE-21150: --- bq. I will resolve this issue since the comment from othe

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604875#comment-16604875 ] Hadoop QA commented on HBASE-21150: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V