[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-16 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689421#comment-16689421 ] Sean Busbey commented on HBASE-21255: - heads up on HBASE-21489. please take a look.

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688329#comment-16688329 ] Hudson commented on HBASE-21255: Results for branch branch-2 [build #1504 on bu

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687866#comment-16687866 ] Hudson commented on HBASE-21255: Results for branch master [build #607 on build

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687449#comment-16687449 ] Reid Chan commented on HBASE-21255: --- Pushed to branch-2 and master. Thanks all for rev

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687318#comment-16687318 ] Reid Chan commented on HBASE-21255: --- The checkstyle is about {{ShadedAccessControlUti

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686791#comment-16686791 ] stack commented on HBASE-21255: --- Skimmed. +1. Fix checkstyle on commit? Looks good. Saved

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686445#comment-16686445 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686244#comment-16686244 ] Reid Chan commented on HBASE-21255: --- Retry v9. > [acl] Refactor TablePermission into

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686238#comment-16686238 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-13 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686047#comment-16686047 ] Reid Chan commented on HBASE-21255: --- bq. address code duplication As suggestion, it is

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685710#comment-16685710 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685461#comment-16685461 ] stack commented on HBASE-21255: --- You did not address code duplication in you last patch [~

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684636#comment-16684636 ] Reid Chan commented on HBASE-21255: --- Unrelated failure. > [acl] Refactor TablePermiss

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684370#comment-16684370 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684268#comment-16684268 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683995#comment-16683995 ] Reid Chan commented on HBASE-21255: --- Attached a wrong v8 patch Re-upload it. > [a

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683936#comment-16683936 ] Reid Chan commented on HBASE-21255: --- v8 addressed comments from [~stack] in RB. > [ac

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680751#comment-16680751 ] Reid Chan commented on HBASE-21255: --- bq. perhaps ping dev@hbase for volunteers Thanks

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-08 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680442#comment-16680442 ] Sean Busbey commented on HBASE-21255: - > I will commit it late this day if no furthe

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679232#comment-16679232 ] Reid Chan commented on HBASE-21255: --- I will commit it late this day if no further comm

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-07 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678066#comment-16678066 ] Reid Chan commented on HBASE-21255: --- Hoping more comments. > [acl] Refactor TablePerm

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677741#comment-16677741 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-06 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677569#comment-16677569 ] Reid Chan commented on HBASE-21255: --- v7 changes visibility of new method {{Permission

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676057#comment-16676057 ] Reid Chan commented on HBASE-21255: --- Thanks Sean! Would you mind taking a look at {{S

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-05 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675484#comment-16675484 ] Sean Busbey commented on HBASE-21255: - the precommit failures were probably the open

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675051#comment-16675051 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675006#comment-16675006 ] Reid Chan commented on HBASE-21255: --- ping sir [~stack], do you have free cycles to giv

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-01 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672506#comment-16672506 ] Reid Chan commented on HBASE-21255: --- Failed UTs are not related, v5 addressed Duo's co

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671722#comment-16671722 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-31 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670026#comment-16670026 ] Duo Zhang commented on HBASE-21255: --- Seems all the recent pre commit builds are broken

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-31 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670016#comment-16670016 ] Duo Zhang commented on HBASE-21255: --- Seems all the recent pre commit builds are broken

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-31 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669979#comment-16669979 ] Reid Chan commented on HBASE-21255: --- All modified UTs passed on local, and ShadedAcces

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-31 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669973#comment-16669973 ] Reid Chan commented on HBASE-21255: --- ping [~busbey] {code} [ERROR] Error occurred in s

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669955#comment-16669955 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669254#comment-16669254 ] Hadoop QA commented on HBASE-21255: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668354#comment-16668354 ] Reid Chan commented on HBASE-21255: --- Let's see what will QA says before updating RB.