[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652977#comment-16652977
]
stack commented on HBASE-21256:
---
This is a nice patch. Look forward to trying it out.
> Improve
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651528#comment-16651528
]
Hudson commented on HBASE-21256:
Results for branch branch-1.4
[build #509 on
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650071#comment-16650071
]
Hudson commented on HBASE-21256:
Results for branch branch-1
[build #509 on
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649671#comment-16649671
]
Duo Zhang commented on HBASE-21256:
---
Pushed to branch-1 after fixing the checkstyle issues. Thanks
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648264#comment-16648264
]
Hadoop QA commented on HBASE-21256:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648218#comment-16648218
]
Andrew Purtell commented on HBASE-21256:
Attached branch-1 port
> Improve
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647881#comment-16647881
]
Hudson commented on HBASE-21256:
Results for branch master
[build #541 on
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647684#comment-16647684
]
Hudson commented on HBASE-21256:
Results for branch branch-2
[build #1378 on
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647347#comment-16647347
]
Duo Zhang commented on HBASE-21256:
---
Thanks [~apurtell], I've added the line of code when pushing to
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647299#comment-16647299
]
Andrew Purtell commented on HBASE-21256:
I was trying this out with a branch-1 backport and
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647287#comment-16647287
]
Duo Zhang commented on HBASE-21256:
---
Sorry, will commit soon. Thanks for your patient.
> Improve
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647284#comment-16647284
]
Zephyr Guo commented on HBASE-21256:
Hello, [~Apache9]
Could you resolve this issue today?
Thanks.
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644879#comment-16644879
]
Duo Zhang commented on HBASE-21256:
---
Will commit tomorrow if no objections.
> Improve
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644339#comment-16644339
]
Zephyr Guo commented on HBASE-21256:
I did a test for this Random64 that ran to a trillion, and no
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644323#comment-16644323
]
Duo Zhang commented on HBASE-21256:
---
+1 on the latest patch. What do you think [~stack]?
> Improve
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643471#comment-16643471
]
Hadoop QA commented on HBASE-21256:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643083#comment-16643083
]
Duo Zhang commented on HBASE-21256:
---
Please fix the checkstyle and findbugs issues?
> Improve
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643072#comment-16643072
]
Hadoop QA commented on HBASE-21256:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642836#comment-16642836
]
Hadoop QA commented on HBASE-21256:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642835#comment-16642835
]
Zephyr Guo commented on HBASE-21256:
[~Apache9] thanks. I had uploaded the newest patch.
> Improve
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642740#comment-16642740
]
Duo Zhang commented on HBASE-21256:
---
[~gzh1992n] Please upload the newest patch here to try a pre
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641815#comment-16641815
]
Zephyr Guo commented on HBASE-21256:
[~Apache9]
If Random64 is not thread-safe, I could be hard to
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641814#comment-16641814
]
Zephyr Guo commented on HBASE-21256:
I saw your notes on rb. I ran 50B times nextLong for Random64,
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641640#comment-16641640
]
Duo Zhang commented on HBASE-21256:
---
Overall LGTM. The only concerns is about the AtomicLong in
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641487#comment-16641487
]
stack commented on HBASE-21256:
---
[~Apache9] thanks. Stick this in an?
> Improve
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640650#comment-16640650
]
Duo Zhang commented on HBASE-21256:
---
Hey [~stack] I've relied on review board, that the likelihood of
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636403#comment-16636403
]
stack commented on HBASE-21256:
---
Trying to follow along, I don't see listing of likelihood of collision on
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633263#comment-16633263
]
Zephyr Guo commented on HBASE-21256:
I uploaded the patch to review board (see issue links).
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633249#comment-16633249
]
Duo Zhang commented on HBASE-21256:
---
Mind uploading the patch to review board?
> Improve
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633238#comment-16633238
]
Hadoop QA commented on HBASE-21256:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633236#comment-16633236
]
Hadoop QA commented on HBASE-21256:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633219#comment-16633219
]
Hadoop QA commented on HBASE-21256:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633216#comment-16633216
]
Hadoop QA commented on HBASE-21256:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633207#comment-16633207
]
Zephyr Guo commented on HBASE-21256:
Hi, [~Apache9]
I attached the patch-v3, and use 64-bit LCG.
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633176#comment-16633176
]
Duo Zhang commented on HBASE-21256:
---
Just use the 64 bits LCG? It is very simple
next =
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633164#comment-16633164
]
Zephyr Guo commented on HBASE-21256:
[~Apache9]
After saw that page, I seem understand you means.
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633013#comment-16633013
]
Hadoop QA commented on HBASE-21256:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632977#comment-16632977
]
Duo Zhang commented on HBASE-21256:
---
{quote}
It is 48-bits seed algorithm (according to HBASE-13382
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632967#comment-16632967
]
Zephyr Guo commented on HBASE-21256:
{quote}On SecureRandom, what about the original argument that
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632958#comment-16632958
]
Ted Yu commented on HBASE-21256:
Zephyr:
{code}
450 if (multipleUnevenColumnFamilies) {
451
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632954#comment-16632954
]
Duo Zhang commented on HBASE-21256:
---
In HBASE-13382 we want to avoid collision on a large data set so
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632953#comment-16632953
]
Hadoop QA commented on HBASE-21256:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632923#comment-16632923
]
stack commented on HBASE-21256:
---
Thanks for working on this.
On SecureRandom, what about the original
43 matches
Mail list logo
