[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824033#comment-16824033 ] Hudson commented on HBASE-21401: Results for branch master [build #954 on

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798736#comment-16798736 ] Hudson commented on HBASE-21401: Results for branch branch-1 [build #732 on

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727172#comment-16727172 ] Hudson commented on HBASE-21401: Results for branch branch-2 [build #1571 on

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726896#comment-16726896 ] Hudson commented on HBASE-21401: Results for branch branch-2.0 [build #1184 on

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726892#comment-16726892 ] Hudson commented on HBASE-21401: Results for branch branch-2.1 [build #702 on

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726452#comment-16726452 ] Zheng Hu commented on HBASE-21401: -- bq. Please fix checkstyle on commit. Add a release note too saying

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726430#comment-16726430 ] stack commented on HBASE-21401: --- +1 let safety win. Let’s address the overparsing in other follow on

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726432#comment-16726432 ] stack commented on HBASE-21401: --- Please fix checkstyle on commit. Add a release note too saying what this

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726398#comment-16726398 ] Zheng Hu commented on HBASE-21401: -- bq. I don't like that we are adding friction to KV making because

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726378#comment-16726378 ] stack commented on HBASE-21401: --- [~openinx] As you can tell, I don't like that we are adding friction to

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725524#comment-16725524 ] Zheng Hu commented on HBASE-21401: -- Sorry for pinging again, [~stack] boss. I'm trying to push this

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724706#comment-16724706 ] Zheng Hu commented on HBASE-21401: -- bq. KeyValue does checks of lengths to make sure they are not

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724687#comment-16724687 ] stack commented on HBASE-21401: --- You have a point [~openinx] that doing checks inline will bulk up regular

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724637#comment-16724637 ] Zheng Hu commented on HBASE-21401: -- bq. I looked at the patch and I still see double-parse, no? (Once

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724291#comment-16724291 ] stack commented on HBASE-21401: --- Pardon me [~openinx] I missed this. So, I looked at the patch and I still

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723799#comment-16723799 ] Zheng Hu commented on HBASE-21401: -- Ping [~stack], [~Apache9], [~anoop.hbase]. > Sanity check when

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708703#comment-16708703 ] Zheng Hu commented on HBASE-21401: -- [~stack], any other concern ? > Sanity check when constructing

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708276#comment-16708276 ] Hadoop QA commented on HBASE-21401: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708155#comment-16708155 ] Zheng Hu commented on HBASE-21401: -- Patch.v7 Fixed all the failed UT > Sanity check when constructing

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703289#comment-16703289 ] Hadoop QA commented on HBASE-21401: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21401) Sanity check when constructing the KeyValue

[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702938#comment-16702938 ] Zheng Hu commented on HBASE-21401: -- Moved the sanity check into KV constructor, Let's see if hadoop QA