[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-15 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688393#comment-16688393 ] Ankit Singhal commented on HBASE-21440: --- bq. Pushed to branch-2.1. Thanks [~an...@apache.org] (Its

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687916#comment-16687916 ] Hudson commented on HBASE-21440: Results for branch branch-2.1 [build #608 on

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687546#comment-16687546 ] stack commented on HBASE-21440: --- Pushed to branch-2.1. Thanks [~an...@apache.org] (Its not for branch-2+

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687484#comment-16687484 ] Hudson commented on HBASE-21440: Results for branch branch-2.0 [build #1085 on

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687369#comment-16687369 ] Hadoop QA commented on HBASE-21440: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687328#comment-16687328 ] Hadoop QA commented on HBASE-21440: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-14 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687184#comment-16687184 ] Ankit Singhal commented on HBASE-21440: --- bq. I pushed to branch-2.0 but it won't go into

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686816#comment-16686816 ] stack commented on HBASE-21440: --- [~an...@apache.org] I pushed to branch-2.0 but it won't go into

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686172#comment-16686172 ] Hadoop QA commented on HBASE-21440: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-13 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686091#comment-16686091 ] Ankit Singhal commented on HBASE-21440: --- Thanks [~allan163] for the confirmation, Uploaded

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-13 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686060#comment-16686060 ] Allan Yang commented on HBASE-21440: +1 on v4 patch. Maybe it is HBASE-21468 making these test

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-13 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685628#comment-16685628 ] Ankit Singhal commented on HBASE-21440: --- bq. Legit failures then in your opinion sir? Related?

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685439#comment-16685439 ] stack commented on HBASE-21440: --- [~an...@apache.org] Legit failures then in your opinion sir? Related? >

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-12 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684810#comment-16684810 ] Ankit Singhal commented on HBASE-21440: --- Still the same failures on Jenkins, looking into it

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684706#comment-16684706 ] Hadoop QA commented on HBASE-21440: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-12 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684590#comment-16684590 ] Ankit Singhal commented on HBASE-21440: --- I see that

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-10 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682544#comment-16682544 ] Josh Elser commented on HBASE-21440: Ah, I think I see what the issue is. The change to

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-10 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682532#comment-16682532 ] Josh Elser commented on HBASE-21440: Let me try to put up a v4 :) > Assign procedure on the crashed

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-09 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682064#comment-16682064 ] stack commented on HBASE-21440: --- Patch is great. I like patches that remove stuff. My guess is that the

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682022#comment-16682022 ] Hadoop QA commented on HBASE-21440: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-09 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681898#comment-16681898 ] Ankit Singhal commented on HBASE-21440: --- Thank you guys, have updated the patch accordingly, there

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-09 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681853#comment-16681853 ] stack commented on HBASE-21440: --- Agree unit test is hard for this case. > Assign procedure on the crashed

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-09 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681709#comment-16681709 ] Josh Elser commented on HBASE-21440: {quote}rather than SCP have to know about AP states (and open

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-08 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680754#comment-16680754 ] Allan Yang commented on HBASE-21440: I think [~stack] has a very good idea about not exposing

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-08 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680655#comment-16680655 ] stack commented on HBASE-21440: --- Thanks for the ping. Patch looks good. One thought [~an...@apache.org]

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-08 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680638#comment-16680638 ] Josh Elser commented on HBASE-21440: Oh, one more tidbit of information from the environment which

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-08 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680605#comment-16680605 ] Josh Elser commented on HBASE-21440: Glancing through the code, I can't come up with a good

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-08 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680598#comment-16680598 ] Josh Elser commented on HBASE-21440: [~stack], also wanted to mention you – see if you have any

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679137#comment-16679137 ] Hadoop QA commented on HBASE-21440: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-08 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679927#comment-16679927 ] Josh Elser commented on HBASE-21440: {noformat} [ERROR] Errors: [ERROR]

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-07 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678797#comment-16678797 ] Josh Elser commented on HBASE-21440: Clicked the "Patch Available" button. Great synopsis Ankit,

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-06 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677712#comment-16677712 ] Allan Yang commented on HBASE-21440: You can add more comments about the check. Otherwise, the patch

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-06 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677667#comment-16677667 ] Ankit Singhal commented on HBASE-21440: --- bq. I think we only need to check AssignProcedure, for

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-06 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677531#comment-16677531 ] Allan Yang commented on HBASE-21440: {code} + if (rtp.getTransitionState() !=

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-06 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677444#comment-16677444 ] Ankit Singhal commented on HBASE-21440: --- bq. I think we can do this. if the procedure found in

[jira] [Commented] (HBASE-21440) Assign procedure on the crashed server is not properly interrupted

2018-11-05 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676234#comment-16676234 ] Allan Yang commented on HBASE-21440: Yes, I think it is possible. But it should be a very rare case.