[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790256#comment-16790256 ] Hudson commented on HBASE-21987: Results for branch branch-1 [build #715 on bui

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790141#comment-16790141 ] Xiang Li commented on HBASE-21987: -- Thanks Xu Cang for the review! > Simplify RSGroupI

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789968#comment-16789968 ] Xu Cang commented on HBASE-21987: - Pushed to branch-1. Thanks [~water]! > Simplify RSG

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788694#comment-16788694 ] Xiang Li commented on HBASE-21987: -- [~xucang] Please help to review patch v000 for bran

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788569#comment-16788569 ] Hudson commented on HBASE-21987: Results for branch branch-2.2 [build #96 on bu

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788561#comment-16788561 ] Hudson commented on HBASE-21987: Results for branch branch-2 [build #1740 on bu

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788543#comment-16788543 ] Hudson commented on HBASE-21987: Results for branch master [build #850 on build

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788487#comment-16788487 ] Hadoop QA commented on HBASE-21987: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788319#comment-16788319 ] Xu Cang commented on HBASE-21987: - applied to master, branch-2 , branch-2.2 [~water] Co

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786085#comment-16786085 ] Xu Cang commented on HBASE-21987: - +1 Will commit it today. Thanks. [~water] > Simpli

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785524#comment-16785524 ] Xiang Li commented on HBASE-21987: -- Patch v004 is uploaded to correct the check-style e

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785525#comment-16785525 ] Xiang Li commented on HBASE-21987: -- Hi [~xucang], patch v004 passes Hadoop QA. Could yo

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785518#comment-16785518 ] Hadoop QA commented on HBASE-21987: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785238#comment-16785238 ] Hadoop QA commented on HBASE-21987: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785226#comment-16785226 ] Xiang Li commented on HBASE-21987: -- Upload patch v003 to correct the error reported by

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785217#comment-16785217 ] Hadoop QA commented on HBASE-21987: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785211#comment-16785211 ] Xiang Li commented on HBASE-21987: -- bq. I still think we should follow the check-style

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785193#comment-16785193 ] Xu Cang commented on HBASE-21987: - I will try to apply to other branches, if they apply,

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785190#comment-16785190 ] Xiang Li commented on HBASE-21987: -- Hi [~xucang],thanks for your review and comments!

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785159#comment-16785159 ] Hadoop QA commented on HBASE-21987: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785151#comment-16785151 ] Xu Cang commented on HBASE-21987: - Then " !oldGroupMap.equals(newGroupMap)" becomes redu

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785134#comment-16785134 ] Xiang Li commented on HBASE-21987: -- Hi [~xucang] patch v001 is uploaded with some comm

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784958#comment-16784958 ] Xu Cang commented on HBASE-21987: - I like this simplification. Thanks [~water] Some brie

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784219#comment-16784219 ] Hadoop QA commented on HBASE-21987: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-21987) Simplify RSGroupInfoManagerImpl#flushConfig() for offline mode

[ https://issues.apache.org/jira/browse/HBASE-21987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784199#comment-16784199 ] Xiang Li commented on HBASE-21987: -- Upload patch v000, a small change. [~xucang] Would