[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157774#comment-17157774 ] Lars Hofhansl commented on HBASE-24742: --- There are two observations: 1. We do not

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157775#comment-17157775 ] Lars Hofhansl commented on HBASE-24742: --- Here's a patch. Please have a careful loo

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157776#comment-17157776 ] Bharath Vissapragada commented on HBASE-24742: -- To add more color, followin

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157779#comment-17157779 ] Lars Hofhansl commented on HBASE-24742: --- Passes the test added in HBASE-19863 and

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157787#comment-17157787 ] Duo Zhang commented on HBASE-24742: --- I think the discussion in HBASE-17958 is enough t

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157791#comment-17157791 ] Andrew Kyle Purtell commented on HBASE-24742: - There is an actual regression

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157807#comment-17157807 ] Bharath Vissapragada commented on HBASE-24742: -- > I think the discussion in

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157815#comment-17157815 ] Duo Zhang commented on HBASE-24742: --- And on the fake cell, maybe we should not pass it

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157890#comment-17157890 ] Lars Hofhansl commented on HBASE-24742: --- [~zhangduo] I'm with you there. The secon

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157895#comment-17157895 ] Lars Hofhansl commented on HBASE-24742: --- Upon second thought. Perhaps a seek (not

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158167#comment-17158167 ] Duo Zhang commented on HBASE-24742: --- {quote} I'm not sure how we can avoid passing the

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-15 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158497#comment-17158497 ] Lars Hofhansl commented on HBASE-24742: --- Created a PR for observation #1 above. >

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-16 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159385#comment-17159385 ] Lars Hofhansl commented on HBASE-24742: --- Merged into branch-1. I'll look into mas

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-16 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159444#comment-17159444 ] Lars Hofhansl commented on HBASE-24742: --- Master (and branch-2) patch. Will just ap

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159456#comment-17159456 ] Andrew Kyle Purtell commented on HBASE-24742: - Sounds good. The other issue

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159706#comment-17159706 ] Hudson commented on HBASE-24742: Results for branch branch-2 [build #2748 on bu

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159861#comment-17159861 ] Hudson commented on HBASE-24742: Results for branch master [build #1787 on buil

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159872#comment-17159872 ] Hudson commented on HBASE-24742: Results for branch branch-1 [build #1327 on bu

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160250#comment-17160250 ] Hudson commented on HBASE-24742: Results for branch branch-2.2 [build #915 on b

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162235#comment-17162235 ] Nick Dimiduk commented on HBASE-24742: -- I'm still retrying toward a passing precomm

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162268#comment-17162268 ] Bharath Vissapragada commented on HBASE-24742: -- Looks like HBASE-19863 add

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162382#comment-17162382 ] Nick Dimiduk commented on HBASE-24742: -- bq. Looks like HBASE-19863 added some cover

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162795#comment-17162795 ] Hudson commented on HBASE-24742: Results for branch branch-2.3 [build #189 on b

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-08-02 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169628#comment-17169628 ] Lars Hofhansl commented on HBASE-24742: --- Re: Tests. This is purely an internal opt