[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464199#comment-13464199 ] stack commented on HBASE-3896: -- [~cody.mar...@gmail.com] Look for other issues w/ noob. Than

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-26 Thread Cody Marcel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464144#comment-13464144 ] Cody Marcel commented on HBASE-3896: I still think it would be an overall cleaner solu

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464141#comment-13464141 ] stack commented on HBASE-3896: -- bq. Mockito already can just mock those out (eg. ServerManage

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-26 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464117#comment-13464117 ] Jesse Yates commented on HBASE-3896: bq. Other implementations would be mocks that imp

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464063#comment-13464063 ] stack commented on HBASE-3896: -- bq. I don't think that abstracting out the serverManger and c

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-26 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463995#comment-13463995 ] Jesse Yates commented on HBASE-3896: I don't think that abstracting out the serverMang

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-26 Thread Cody Marcel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463968#comment-13463968 ] Cody Marcel commented on HBASE-3896: I am making subtasks for this to break the change

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463962#comment-13463962 ] stack commented on HBASE-3896: -- [~cody.mar...@gmail.com] np. Was just a notion.

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-26 Thread Cody Marcel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463953#comment-13463953 ] Cody Marcel commented on HBASE-3896: I looked into splitting SM up a bit on the interf

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-24 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462444#comment-13462444 ] stack commented on HBASE-3896: -- [~cody.mar...@gmail.com] Go for it. Anything you can do to i

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-24 Thread Cody Marcel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462156#comment-13462156 ] Cody Marcel commented on HBASE-3896: Mockito allows you to work with the class directl

[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager

2012-09-24 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462114#comment-13462114 ] stack commented on HBASE-3896: -- [~cody.mar...@gmail.com] This is done. Check TestAssignmentM