[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105069#comment-13105069 ] Hudson commented on HBASE-4330: --- Integrated in HBase-TRUNK #2211 (See [https://builds.apach

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105012#comment-13105012 ] Ted Yu commented on HBASE-4330: --- So far the slab unit tests passed on MacBook and Linux. Int

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103673#comment-13103673 ] Ted Yu commented on HBASE-4330: --- +1 on patch v7. > Fix races in slab cache > --

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-12 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103010#comment-13103010 ] Li Pi commented on HBASE-4330: -- The change in v7 that fixes things: -scache.cacheBlock(b

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-12 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102908#comment-13102908 ] Li Pi commented on HBASE-4330: -- I'm looping mvn on the latest patch - I don't see any failure

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-09 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101989#comment-13101989 ] Li Pi commented on HBASE-4330: -- Yeah. This doesn't take care of it completely. I'll figure so

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101974#comment-13101974 ] Ted Yu commented on HBASE-4330: --- I don't see much difference for patch v6 on my MacBook: {co

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100971#comment-13100971 ] Ted Yu commented on HBASE-4330: --- We're getting close. The three tests passed on Linux. But o

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-08 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100866#comment-13100866 ] Li Pi commented on HBASE-4330: -- This should fix the problem as reported in your stack trace.

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100789#comment-13100789 ] Ted Yu commented on HBASE-4330: --- {code} Running org.apache.hadoop.hbase.io.hfile.slab.TestSl

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-08 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100773#comment-13100773 ] Li Pi commented on HBASE-4330: -- Woah, not sure what happened there. Fixing. > Fix races in s

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100769#comment-13100769 ] Ted Yu commented on HBASE-4330: --- Patch v3 contains way too many changes. Can you rebase and

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-08 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100765#comment-13100765 ] Li Pi commented on HBASE-4330: -- Done. > Fix races in slab cache > --- >

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100740#comment-13100740 ] Ted Yu commented on HBASE-4330: --- Please fix the following: {code} [INFO] Compilation failure

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-07 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099838#comment-13099838 ] Li Pi commented on HBASE-4330: -- The final test, TestCacheMultiThreadedEvictions, took around

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099610#comment-13099610 ] Ted Yu commented on HBASE-4330: --- How long did TestSingleSizeCache take, on average ? Thanks

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-07 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099602#comment-13099602 ] Li Pi commented on HBASE-4330: -- Ran 3 instances of the tests in a loop for 24 hours+. No erro

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-06 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097767#comment-13097767 ] Li Pi commented on HBASE-4330: -- Okay :) @Ted Yu - I can't recreate the hanging TestSingleSi

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-05 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097311#comment-13097311 ] Todd Lipcon commented on HBASE-4330: Let's not commit til we get all of them figured o

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-05 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097303#comment-13097303 ] Li Pi commented on HBASE-4330: -- Spoke to todd on these changes. +1. Some races remain, but I'

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-02 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096579#comment-13096579 ] Li Pi commented on HBASE-4330: -- Also, whats the advantage of using a synchronize block and ch

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-02 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096577#comment-13096577 ] Li Pi commented on HBASE-4330: -- Do we really need: contentBlock.serializedData.rewind

[jira] [Commented] (HBASE-4330) Fix races in slab cache

2011-09-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096573#comment-13096573 ] Ted Yu commented on HBASE-4330: --- When I ran TestSingleSizeCache, it seemed to hang. Here is