[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152700#comment-13152700
]
Hudson commented on HBASE-4485:
---
Integrated in HBase-TRUNK #2454 (See
[https://builds.apach
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152596#comment-13152596
]
Nicolas Spiegelberg commented on HBASE-4485:
+1 lgtm. went over this with kan
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152573#comment-13152573
]
jirapos...@reviews.apache.org commented on HBASE-4485:
--
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152450#comment-13152450
]
jirapos...@reviews.apache.org commented on HBASE-4485:
--
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152425#comment-13152425
]
Ted Yu commented on HBASE-4485:
---
@Amit:
Can you highlight the changes in the latest patch ?
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152413#comment-13152413
]
jirapos...@reviews.apache.org commented on HBASE-4485:
--
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132809#comment-13132809
]
Ted Yu commented on HBASE-4485:
---
In order to avoid using instanceof in useRWCC(), we have at
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132740#comment-13132740
]
jirapos...@reviews.apache.org commented on HBASE-4485:
--
bq. On 201
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132733#comment-13132733
]
jirapos...@reviews.apache.org commented on HBASE-4485:
--
bq. On 201
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132355#comment-13132355
]
jirapos...@reviews.apache.org commented on HBASE-4485:
--
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131994#comment-13131994
]
Ted Yu commented on HBASE-4485:
---
In StoreScanner.useRWCC(boolean flag):
{code}
List allS
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131988#comment-13131988
]
Ted Yu commented on HBASE-4485:
---
In Store.completeCompaction(), the following code is outsid
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131917#comment-13131917
]
jirapos...@reviews.apache.org commented on HBASE-4485:
--
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131845#comment-13131845
]
Amitanand Aiyer commented on HBASE-4485:
Btw, Ted also has a fix to this issue wh
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131844#comment-13131844
]
Amitanand Aiyer commented on HBASE-4485:
I am not clear on weather we need the not
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131833#comment-13131833
]
Amitanand Aiyer commented on HBASE-4485:
@Stack. The reason that I wanted to move
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127696#comment-13127696
]
Ted Yu commented on HBASE-4485:
---
Here is the related change w.r.t. ignoreNewerKVs():
{code}
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127164#comment-13127164
]
Jonathan Hsieh commented on HBASE-4485:
---
@Amitanand
I've applied HBASE-2856's from
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116660#comment-13116660
]
stack commented on HBASE-4485:
--
@Amit Great stuff. I like the reasoning above especially the
[
https://issues.apache.org/jira/browse/HBASE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114763#comment-13114763
]
Amitanand Aiyer commented on HBASE-4485:
One way to fix this issue, would be to sw
20 matches
Mail list logo