[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287244#comment-13287244
]
Hudson commented on HBASE-4720:
---
Integrated in HBase-0.92-security #109 (See
[https://build
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287171#comment-13287171
]
Hudson commented on HBASE-4720:
---
Integrated in HBase-0.94-security #33 (See
[https://builds
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286218#comment-13286218
]
Hudson commented on HBASE-4720:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #33 (See
[https:
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286151#comment-13286151
]
Hudson commented on HBASE-4720:
---
Integrated in HBase-0.92 #434 (See
[https://builds.apache.
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286045#comment-13286045
]
Hudson commented on HBASE-4720:
---
Integrated in HBase-0.94 #235 (See
[https://builds.apache.
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286033#comment-13286033
]
Hudson commented on HBASE-4720:
---
Integrated in HBase-TRUNK #2956 (See
[https://builds.apach
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285907#comment-13285907
]
Mubarak Seyed commented on HBASE-4720:
--
Thanks Jimmy for the patch.
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285877#comment-13285877
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285831#comment-13285831
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285780#comment-13285780
]
Andrew Purtell commented on HBASE-4720:
---
+1 except for small debug logging nit that
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285364#comment-13285364
]
stack commented on HBASE-4720:
--
Patch lgtm.
Andrew? What you reckon?
> Imp
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285352#comment-13285352
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285345#comment-13285345
]
Jimmy Xiang commented on HBASE-4720:
The patch is good for 0.94 and 0.92 too.
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285238#comment-13285238
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285183#comment-13285183
]
stack commented on HBASE-4720:
--
+1 on patch. Tests look good. Does it work for you Jimmy?
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285152#comment-13285152
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285125#comment-13285125
]
stack commented on HBASE-4720:
--
@Mubarak Do you like Jimmy's changes?
Jimmy, should you do a
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285118#comment-13285118
]
Mubarak Seyed commented on HBASE-4720:
--
Thanks Jimmy for taking care of this JIRA.
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285115#comment-13285115
]
Jimmy Xiang commented on HBASE-4720:
The new review request is here: https://reviews.a
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276993#comment-13276993
]
Mubarak Seyed commented on HBASE-4720:
--
Sure, will do Andy. Thanks.
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276983#comment-13276983
]
Andrew Purtell commented on HBASE-4720:
---
While you are in there Mubarak please make
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276971#comment-13276971
]
Mubarak Seyed commented on HBASE-4720:
--
Thanks Andy. Will fix your comments in test c
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276379#comment-13276379
]
Andrew Purtell commented on HBASE-4720:
---
Patch v7 still applies to trunk, but with s
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271976#comment-13271976
]
Mubarak Seyed commented on HBASE-4720:
--
Hi Andy,
Can you please review the patch? Th
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235977#comment-13235977
]
Lars Hofhansl commented on HBASE-4720:
--
FYI: Rest is not really my area, so I can't d
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235668#comment-13235668
]
Lars Hofhansl commented on HBASE-4720:
--
Needs to be reviewed today to get into 0.94.0
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234793#comment-13234793
]
Mubarak Seyed commented on HBASE-4720:
--
I was expecting Andy to review the new patch.
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205514#comment-13205514
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204998#comment-13204998
]
Mubarak Seyed commented on HBASE-4720:
--
The following scenarios are tested:
1. 5 nod
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195038#comment-13195038
]
Mubarak Seyed commented on HBASE-4720:
--
@Ted
I have tested with unit test suite (usin
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194401#comment-13194401
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194399#comment-13194399
]
Zhihong Yu commented on HBASE-4720:
---
@Mubarak:
Thanks for your persistence.
Please also
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193546#comment-13193546
]
Hudson commented on HBASE-4720:
---
Integrated in HBase-TRUNK #2646 (See
[https://builds.apach
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192876#comment-13192876
]
Hudson commented on HBASE-4720:
---
Integrated in HBase-TRUNK-security #89 (See
[https://build
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192349#comment-13192349
]
Mubarak Seyed commented on HBASE-4720:
--
Sure, will do. Thanks.
> Imp
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192335#comment-13192335
]
Zhihong Yu commented on HBASE-4720:
---
That is Okay, Andy.
I have reverted the patch.
Let
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192329#comment-13192329
]
Andrew Purtell commented on HBASE-4720:
---
Anyway, my apologies, but this commit must
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192328#comment-13192328
]
Andrew Purtell commented on HBASE-4720:
---
Ted, I raised a objection on this issue and
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192323#comment-13192323
]
Zhihong Yu commented on HBASE-4720:
---
@Andrew:
Glad to see your response.
Mubarak respon
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192308#comment-13192308
]
Andrew Purtell commented on HBASE-4720:
---
Actually Ted you should now honor my -1 and
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192309#comment-13192309
]
Andrew Purtell commented on HBASE-4720:
---
Either the current semantics for REST paths
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192307#comment-13192307
]
Andrew Purtell commented on HBASE-4720:
---
Ted, I am going to revert your commit.
{qu
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192290#comment-13192290
]
Zhihong Yu commented on HBASE-4720:
---
Integrated to TRUNK.
Thanks for the patch Mubarak.
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191700#comment-13191700
]
Zhihong Yu commented on HBASE-4720:
---
@Lars:
Feel free to create one JIRA for RowMutation
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191690#comment-13191690
]
Lars Hofhansl commented on HBASE-4720:
--
Should we add another jira for supporting the
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191564#comment-13191564
]
Zhihong Yu commented on HBASE-4720:
---
Patch v6 looks good.
Will integrate if Andrew doesn
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191388#comment-13191388
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190699#comment-13190699
]
Zhihong Yu commented on HBASE-4720:
---
Patch v5 looks good.
{code}
+ * @return Response
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190607#comment-13190607
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190168#comment-13190168
]
Zhihong Yu commented on HBASE-4720:
---
@Mubarak:
Now that Andy removed support for transfo
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189400#comment-13189400
]
Zhihong Yu commented on HBASE-4720:
---
@Andrew:
Can you please review patch v4 ?
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185164#comment-13185164
]
Zhihong Yu commented on HBASE-4720:
---
Minor comments:
{code}
+ * Validates the input re
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185150#comment-13185150
]
Zhihong Yu commented on HBASE-4720:
---
@Andrew:
Can you take a look at patch v4, please ?
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184737#comment-13184737
]
Zhihong Yu commented on HBASE-4720:
---
Latest patch passed unit tests.
>
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184717#comment-13184717
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184694#comment-13184694
]
Mubarak Seyed commented on HBASE-4720:
--
My local tests were keep failing on trunk, wi
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184671#comment-13184671
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184647#comment-13184647
]
Mubarak Seyed commented on HBASE-4720:
--
This patch does not cover the following from
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175233#comment-13175233
]
Mubarak Seyed commented on HBASE-4720:
--
Thanks Ted and Stack.
> Impl
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175231#comment-13175231
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175229#comment-13175229
]
Zhihong Yu commented on HBASE-4720:
---
The failed tests were due to NumberFormatException
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175226#comment-13175226
]
Hadoop QA commented on HBASE-4720:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175174#comment-13175174
]
Zhihong Yu commented on HBASE-4720:
---
@Mubarak:
Please resubmit patch for Hadoop QA - bui
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175105#comment-13175105
]
stack commented on HBASE-4720:
--
lgtm on cursory review. I'll commit in a few days. Maybe An
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174856#comment-13174856
]
stack commented on HBASE-4720:
--
@Mubarak Understood (re: formatter). Would suggest you not r
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174517#comment-13174517
]
Mubarak Seyed commented on HBASE-4720:
--
I addressed most of the review comments, will
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174351#comment-13174351
]
Zhihong Yu commented on HBASE-4720:
---
I used the formatter provided by Nicolas.
Please a
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174345#comment-13174345
]
Mubarak Seyed commented on HBASE-4720:
--
@Ted:
{{eclipse_formatter_apache.xml}} does n
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174236#comment-13174236
]
Zhihong Yu commented on HBASE-4720:
---
@Mubarak:
I think the rule you posted only governs
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174209#comment-13174209
]
Zhihong Yu commented on HBASE-4720:
---
I posted comment on review board.
@Andrew:
Can you
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173914#comment-13173914
]
Mubarak Seyed commented on HBASE-4720:
--
Thanks Stack.
bq. Suggest you not do stuff l
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173861#comment-13173861
]
stack commented on HBASE-4720:
--
On patch:
+ Suggest you not do stuff like below in future be
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173857#comment-13173857
]
stack commented on HBASE-4720:
--
@Mubarak That test fails for me too on a mac (I presume you a
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173650#comment-13173650
]
Zhihong Yu commented on HBASE-4720:
---
{code}
[ERROR]
/Users/zhihyu/trunk-hbase/src/main/
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173646#comment-13173646
]
Zhihong Yu commented on HBASE-4720:
---
Can you update https://reviews.apache.org/r/3250 wi
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173567#comment-13173567
]
Mubarak Seyed commented on HBASE-4720:
--
when i ran the tests, it fails at
{code}
Ru
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172991#comment-13172991
]
Mubarak Seyed commented on HBASE-4720:
--
Okay, i will work on patch for TRUNK then. Th
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172989#comment-13172989
]
Zhihong Yu commented on HBASE-4720:
---
For patch based on 0.90 branch, you can still uploa
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172988#comment-13172988
]
Zhihong Yu commented on HBASE-4720:
---
I suggest working on patch for TRUNK.
Once the revi
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172986#comment-13172986
]
Mubarak Seyed commented on HBASE-4720:
--
This JIRA request was opened by my colleague
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172889#comment-13172889
]
Zhihong Yu commented on HBASE-4720:
---
I tried applying patch v3 on 0.92 and TRUNK but enc
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172879#comment-13172879
]
Mubarak Seyed commented on HBASE-4720:
--
Uploaded the patch (HBASE-4720.v3.patch) to r
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172763#comment-13172763
]
Zhihong Yu commented on HBASE-4720:
---
I think adding test methods in TestRowResource make
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172758#comment-13172758
]
Mubarak Seyed commented on HBASE-4720:
--
Regarding unit test classes, i dont need sepa
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172743#comment-13172743
]
Mubarak Seyed commented on HBASE-4720:
--
Thanks Ted. I am done with refactor the code/
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172041#comment-13172041
]
Zhihong Yu commented on HBASE-4720:
---
The diff was made against 0.90.5
I got the followin
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171473#comment-13171473
]
Mubarak Seyed commented on HBASE-4720:
--
Code is posted at https://reviews.apache.org/
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171442#comment-13171442
]
Zhihong Yu commented on HBASE-4720:
---
Sounds good.
Keep us posted.
> I
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171436#comment-13171436
]
Mubarak Seyed commented on HBASE-4720:
--
Thanks Ted. This is what i think about refact
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171319#comment-13171319
]
Mubarak Seyed commented on HBASE-4720:
--
Sure, will refactor and post it on review boa
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171087#comment-13171087
]
Zhihong Yu commented on HBASE-4720:
---
The patch is of decent size, can you post on review
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169975#comment-13169975
]
Mubarak Seyed commented on HBASE-4720:
--
Thanks Stack. Yeah, i can pass the value-to-c
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169969#comment-13169969
]
stack commented on HBASE-4720:
--
Option 2 sounds better. How do you pass the value to check i
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169911#comment-13169911
]
Mubarak Seyed commented on HBASE-4720:
--
+1 for option 2
> Implement
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169887#comment-13169887
]
Zhihong Yu commented on HBASE-4720:
---
I think option 2 is more favorable.
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169164#comment-13169164
]
Mubarak Seyed commented on HBASE-4720:
--
Stack,
Option 1:
If we send ?check=true then
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168834#comment-13168834
]
stack commented on HBASE-4720:
--
Would using an attribute work?
?check=true
How you passing
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168641#comment-13168641
]
Mubarak Seyed commented on HBASE-4720:
--
My approach is to use a label in the URI path
[
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164046#comment-13164046
]
Mubarak Seyed commented on HBASE-4720:
--
Waiting for corporate approval to contribute
99 matches
Mail list logo
