[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230050#comment-13230050
]
stack commented on HBASE-5399:
--
I should have said, given you've repro'd in an older version
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230049#comment-13230049
]
stack commented on HBASE-5399:
--
If you were able to trigger it in a version before your patch
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230040#comment-13230040
]
nkeywal commented on HBASE-5399:
I've actually been able to reproduce the issue on a previ
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229476#comment-13229476
]
nkeywal commented on HBASE-5399:
You're right. It's a regression. I will fix this with 554
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229142#comment-13229142
]
Zhihong Yu commented on HBASE-5399:
---
TestZooKeeper fails quite often on Hadoop QA now.
H
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228816#comment-13228816
]
nkeywal commented on HBASE-5399:
It's ok, we're all in the same boat :-)
I've got the test
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228798#comment-13228798
]
Lars Hofhansl commented on HBASE-5399:
--
Yeah. Let's move the discussion to HBASE-5569
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228771#comment-13228771
]
nkeywal commented on HBASE-5399:
I'm going to rerun it on trunk and on a 2 weeks old trunk
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228753#comment-13228753
]
Lars Hofhansl commented on HBASE-5399:
--
Arrgghhh... That's not good!
Do you see above
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228662#comment-13228662
]
nkeywal commented on HBASE-5399:
@Lars, Stack:
After 50 tries, on trunk (fbd4bebd5cca129f4
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228587#comment-13228587
]
nkeywal commented on HBASE-5399:
@Stack; I think it fails 20% of the time. I run it alone,
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228488#comment-13228488
]
Lars Hofhansl commented on HBASE-5399:
--
Only testMultiRowMutationMultiThreads is fail
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228464#comment-13228464
]
stack commented on HBASE-5399:
--
bq. Yes, this test is flaky... I reproduce the error on the t
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228300#comment-13228300
]
nkeywal commented on HBASE-5399:
@stack
Yes, this test is flaky... I reproduce the error o
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228161#comment-13228161
]
stack commented on HBASE-5399:
--
@Nicolas What you make of Ted's comment above? You think it
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228160#comment-13228160
]
stack commented on HBASE-5399:
--
@Nicolas What you make of Ted's comment above? You think it
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228149#comment-13228149
]
Lars Hofhansl commented on HBASE-5399:
--
I should look at TestAtomicOperation.
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228148#comment-13228148
]
Lars Hofhansl commented on HBASE-5399:
--
Yeah!
> Cut the link between
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228106#comment-13228106
]
Hudson commented on HBASE-5399:
---
Integrated in HBase-TRUNK-security #135 (See
[https://buil
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228009#comment-13228009
]
Ted Yu commented on HBASE-5399:
---
>From test output:
{code}
Exception in thread "Thread-211"
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227997#comment-13227997
]
Ted Yu commented on HBASE-5399:
---
TestAtomicOperation failed in latest TRUNK build:
https://b
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227983#comment-13227983
]
Hudson commented on HBASE-5399:
---
Integrated in HBase-TRUNK #2676 (See
[https://builds.apach
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227455#comment-13227455
]
nkeywal commented on HBASE-5399:
Ok, even an empty patch gets these errors from hadoop-qa,
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227436#comment-13227436
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226927#comment-13226927
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226909#comment-13226909
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226903#comment-13226903
]
nkeywal commented on HBASE-5399:
I don't know. The errors are the same, but I don't reprod
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226522#comment-13226522
]
stack commented on HBASE-5399:
--
That looks ok N? Will I commit?
> Cut the l
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226245#comment-13226245
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226195#comment-13226195
]
nkeywal commented on HBASE-5399:
They're all different from the ones I got locally. It cou
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226180#comment-13226180
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226140#comment-13226140
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223857#comment-13223857
]
Lars Hofhansl commented on HBASE-5399:
--
Let's file a child jira for the 0.94 deprecat
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223664#comment-13223664
]
nkeywal commented on HBASE-5399:
I can do a patch with only the deprecated stuff, or it ca
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223660#comment-13223660
]
stack commented on HBASE-5399:
--
@nkeywal yes, agree, good to deprecate in 0.94 rather than 0.
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223662#comment-13223662
]
stack commented on HBASE-5399:
--
... so it seems like there needs to be a separate patch for 0
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223657#comment-13223657
]
nkeywal commented on HBASE-5399:
@all; Ok, I will provide an updated patch with the commen
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223615#comment-13223615
]
stack commented on HBASE-5399:
--
@LarsH I think its too radical a change in client behavior fo
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223606#comment-13223606
]
Zhihong Yu commented on HBASE-5399:
---
{code}
+// We put that all the possible setting
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223579#comment-13223579
]
Zhihong Yu commented on HBASE-5399:
---
Should the following be modified to reflect the cur
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223138#comment-13223138
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223089#comment-13223089
]
nkeywal commented on HBASE-5399:
TestRegionRebalancing: seems to be a flaky test. Will ret
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222436#comment-13222436
]
nkeywal commented on HBASE-5399:
org.apache.hadoop.hbase.TestZooKeeper is surprising, beca
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221995#comment-13221995
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221973#comment-13221973
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221911#comment-13221911
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221430#comment-13221430
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221389#comment-13221389
]
Zhihong Yu commented on HBASE-5399:
---
@N:
Can you update the patch on review board ?
It i
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220965#comment-13220965
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220964#comment-13220964
]
nkeywal commented on HBASE-5399:
@stack. A lot of variance, but not that much. So I know I
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220721#comment-13220721
]
stack commented on HBASE-5399:
--
Thats a wide variety in the types of failures. You get same k
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220317#comment-13220317
]
nkeywal commented on HBASE-5399:
fyi, here are the results on 4 runs.
HADOOP-QA 1
org.apa
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220222#comment-13220222
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220176#comment-13220176
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220171#comment-13220171
]
nkeywal commented on HBASE-5399:
@stack: done on https://reviews.apache.org/r/3967/
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220167#comment-13220167
]
stack commented on HBASE-5399:
--
@N Probably should post the patch up on reviewboard.. its cer
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220166#comment-13220166
]
stack commented on HBASE-5399:
--
@N 1 out of 29 hunks FAILED -- saving rejects to file
src/ma
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220156#comment-13220156
]
nkeywal commented on HBASE-5399:
The patch is still in progress. Submitted to the build to
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220154#comment-13220154
]
Hadoop QA commented on HBASE-5399:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219681#comment-13219681
]
nkeywal commented on HBASE-5399:
v16 (still in progress, some unit tests fail, indent & co
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218514#comment-13218514
]
stack commented on HBASE-5399:
--
On 1., yeah, the close should close the connection -- a clien
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218257#comment-13218257
]
nkeywal commented on HBASE-5399:
If we really want it, I found 3 options, and tried 2.
1)
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217311#comment-13217311
]
stack commented on HBASE-5399:
--
bq... If I don't want to do that, I need to add the method in
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217305#comment-13217305
]
nkeywal commented on HBASE-5399:
yes :-)
The user would code something like:
{noformat}
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217293#comment-13217293
]
stack commented on HBASE-5399:
--
bq. For HMasterInterface, I don't know: I need to modify the
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217289#comment-13217289
]
nkeywal commented on HBASE-5399:
yep, for zk it easy.
For HMasterInterface, I don't know:
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217266#comment-13217266
]
stack commented on HBASE-5399:
--
bq. ...but I didn't find an easy way to extend the master pro
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217267#comment-13217267
]
stack commented on HBASE-5399:
--
Ditto w/ zk? Can't we just add close to the HConnection Inte
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217177#comment-13217177
]
nkeywal commented on HBASE-5399:
bq. Do we have to have the getSharedZookeeperWatcher and
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215945#comment-13215945
]
stack commented on HBASE-5399:
--
Another thought:
Do we have to have the getSharedZookeeperWa
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212121#comment-13212121
]
stack commented on HBASE-5399:
--
@N Have a good holiday. When you get back, this seems good t
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211703#comment-13211703
]
nkeywal commented on HBASE-5399:
@Lars and all: done see https://reviews.apache.org/r/3967
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211612#comment-13211612
]
Lars Hofhansl commented on HBASE-5399:
--
@Nicolas: Could you upload the patch to RB? T
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211435#comment-13211435
]
nkeywal commented on HBASE-5399:
Moreover, v9 patch work on trunk as of today.
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211422#comment-13211422
]
nkeywal commented on HBASE-5399:
In v9 I added some comments and fixed some issues.
bq.
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211313#comment-13211313
]
nkeywal commented on HBASE-5399:
bq. Are we getting retrieveClusterId on startup? Can we n
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210616#comment-13210616
]
stack commented on HBASE-5399:
--
I don't follow:
{code}
+// todo stack nkeywal
+// We
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210561#comment-13210561
]
nkeywal commented on HBASE-5399:
It's not the last version (it needs more comments, unit t
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209565#comment-13209565
]
nkeywal commented on HBASE-5399:
After some thinking and different tries; I believe it mak
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208061#comment-13208061
]
stack commented on HBASE-5399:
--
bq. We can do that, it requires some work to do it well (ZooK
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208051#comment-13208051
]
nkeywal commented on HBASE-5399:
bq. Why are these deprecated: getHRegionConnection(HServe
[
https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208032#comment-13208032
]
stack commented on HBASE-5399:
--
Hurray on below:
{code}
+ @Deprecated
public ZooKeeperWa
82 matches
Mail list logo
