[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-05-09 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271614#comment-13271614 ] ramkrishna.s.vasudevan commented on HBASE-5654: --- Yes Jon. You can see the

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-05-07 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269634#comment-13269634 ] ramkrishna.s.vasudevan commented on HBASE-5654: --- Default should not throw

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-05-07 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269640#comment-13269640 ] ramkrishna.s.vasudevan commented on HBASE-5654: --- Because RS_ZK_REGION_SPLIT

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-23 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259434#comment-13259434 ] Jonathan Hsieh commented on HBASE-5654: --- @Ashotosh - sorry for the delay on review.

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259459#comment-13259459 ] Hadoop QA commented on HBASE-5654: -- +1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259486#comment-13259486 ] Hudson commented on HBASE-5654: --- Integrated in HBase-TRUNK #2797 (See

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-23 Thread Ashutosh Jindal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259498#comment-13259498 ] Ashutosh Jindal commented on HBASE-5654: @Jon Thanks for your review and patch you

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259760#comment-13259760 ] Hudson commented on HBASE-5654: --- Integrated in HBase-TRUNK-security #181 (See

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-19 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257645#comment-13257645 ] Hadoop QA commented on HBASE-5654: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-19 Thread Jonathan Hsieh (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257652#comment-13257652 ] Jonathan Hsieh commented on HBASE-5654: --- bq. -1 core tests. The patch failed these

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-19 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257743#comment-13257743 ] stack commented on HBASE-5654: -- @Jon Our hadoopqa has been hanging with a while. Its

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-19 Thread Jonathan Hsieh (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257871#comment-13257871 ] Jonathan Hsieh commented on HBASE-5654: --- @stack. Got it. Thanks.

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-17 Thread Ashutosh Jindal (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255475#comment-13255475 ] Ashutosh Jindal commented on HBASE-5654: @Jon bq.add bounds checks? Result of

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-17 Thread Jonathan Hsieh (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255719#comment-13255719 ] Jonathan Hsieh commented on HBASE-5654: --- There are a few match related entries:

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-16 Thread Ashutosh Jindal (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254578#comment-13254578 ] Ashutosh Jindal commented on HBASE-5654: @Uma Thank you for your review. I will

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-16 Thread Jonathan Hsieh (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254683#comment-13254683 ] Jonathan Hsieh commented on HBASE-5654: --- Ashutosh: Thanks for taking this on. I'm

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-16 Thread Jonathan Hsieh (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254802#comment-13254802 ] Jonathan Hsieh commented on HBASE-5654: --- I'm being pretty strict with excludes --

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-16 Thread Ashutosh Jindal (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255294#comment-13255294 ] Ashutosh Jindal commented on HBASE-5654: @Jonathan Hsieh Thanks for reviewing the

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-15 Thread Uma Maheswara Rao G (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254512#comment-13254512 ] Uma Maheswara Rao G commented on HBASE-5654: Hey Ashutosh, Looks there are

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-14 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254055#comment-13254055 ] Hadoop QA commented on HBASE-5654: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-14 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254055#comment-13254055 ] Hadoop QA commented on HBASE-5654: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

2012-04-13 Thread Jonathan Hsieh (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253552#comment-13253552 ] Jonathan Hsieh commented on HBASE-5654: --- Hi Ashutosh, I don't see an attachement --