[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284327#comment-13284327
]
ramkrishna.s.vasudevan commented on HBASE-5682:
---
@Lars
See HBASE-6115. As
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246904#comment-13246904
]
Hudson commented on HBASE-5682:
---
Integrated in HBase-0.94-security #7 (See
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243992#comment-13243992
]
Lars Hofhansl commented on HBASE-5682:
--
all-v3 is what I like to commit tomorrow if
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244093#comment-13244093
]
Jieshan Bean commented on HBASE-5682:
-
Everything seems good to me. Only a minor
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244359#comment-13244359
]
Lars Hofhansl commented on HBASE-5682:
--
Presumably close it not needed since the
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244363#comment-13244363
]
Lars Hofhansl commented on HBASE-5682:
--
Oh, and thanks for taking a look Jieshan :)
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244367#comment-13244367
]
stack commented on HBASE-5682:
--
@Nkeywal Hows' this relate to your TRUNK work (if at all)?
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244420#comment-13244420
]
Lars Hofhansl commented on HBASE-5682:
--
One other strangeness I found is that none of
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244436#comment-13244436
]
stack commented on HBASE-5682:
--
Can we add an isAlive to ZKW?
Allow
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1320#comment-1320
]
nkeywal commented on HBASE-5682:
.bq none of ZKUtil methods actually throw exceptions
From
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244468#comment-13244468
]
Lars Hofhansl commented on HBASE-5682:
--
Yeah, my comment was wrong. It's not
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244470#comment-13244470
]
Lars Hofhansl commented on HBASE-5682:
--
Even isAlive or waitForConnect would need to
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244484#comment-13244484
]
nkeywal commented on HBASE-5682:
In 0.96 this should work, with the restriction that the
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244577#comment-13244577
]
Lars Hofhansl commented on HBASE-5682:
--
Let me dig into 0.96 after I get this into
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243874#comment-13243874
]
stack commented on HBASE-5682:
--
On commit, change this '+ LOG.debug(Abort, t);' to
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243052#comment-13243052
]
Lars Hofhansl commented on HBASE-5682:
--
v2 passes all tests locally.
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243141#comment-13243141
]
Zhihong Yu commented on HBASE-5682:
---
+1 on patch.
Allow
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243222#comment-13243222
]
Lars Hofhansl commented on HBASE-5682:
--
Thanks Ted.
The last question is: Should we
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243227#comment-13243227
]
Zhihong Yu commented on HBASE-5682:
---
Application to other HConnection makes sense.
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243312#comment-13243312
]
stack commented on HBASE-5682:
--
This is a perversion.
If we pass in a connection from
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243589#comment-13243589
]
Lars Hofhansl commented on HBASE-5682:
--
perversion is hard word. :) It is just
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243605#comment-13243605
]
Lars Hofhansl commented on HBASE-5682:
--
The more I look at, the more I do like the
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243619#comment-13243619
]
stack commented on HBASE-5682:
--
bq. The problem I have seen in 0.94/0.92 without this patch
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243620#comment-13243620
]
stack commented on HBASE-5682:
--
I looked at the 'all' patch. Looks good to me. Am
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243637#comment-13243637
]
Lars Hofhansl commented on HBASE-5682:
--
I am not envisioning any API changes, just
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243665#comment-13243665
]
Lars Hofhansl commented on HBASE-5682:
--
bq. You think this should go into 0.92?
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243007#comment-13243007
]
Zhihong Yu commented on HBASE-5682:
---
For abort():
{code}
+if (managed) {
+
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243018#comment-13243018
]
Lars Hofhansl commented on HBASE-5682:
--
Thanks Ted.
# the condition is different,
[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243021#comment-13243021
]
Lars Hofhansl commented on HBASE-5682:
--
The gist of this change is that (1) the ZK
29 matches
Mail list logo
